Remove country support from DateFormatter

I'm going to do a similar naive removal here to help scope this issue and the related 3439439 📌 Remove country setting from the installer Fixed

Looks having a deprecation message for 10.3 is useful here

I added a deprecated tag, I'm not sure if 10.3 is correct.

I'm also unclear if I need to do anything for:

protected $country = NULL;

and

$create_settings = [
      'langcode' => $langcode,
      'country' => $this->country(),
    ];

Oh, I should have refreshed, it looks like andypost confirmed that 10.3 is correct, I'm not sure about the property though, I read through this:
https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... →

Ok I fixed the deprecation notice and added the trigger warning.

I removed the call to country in order to get past the phpstan for now.

I think the call to the method can be removed since it's not used, but I'm not entirely sure.

I'll add the deprecated unit test shortly.

Actually I'm not sure this needs a test for deprecation since it's a protected function only called in this class. I found another example of a protected method and there are no deprecation tests for that:

https://git.drupalcode.org/project/drupal/-/merge_requests/6224/diffs#2d...
getSerializer

Let me know if that is incorrect.

Binoli Lalani → made their first commit to this issue’s fork.

Deprecation seems straight forward. Wonder once this is merged if the ticket should just be kept open for the removal in 11.x. But lets get the deprecation merged first.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

I think it's easier still to do the removal in another issue (possibly combined with other removals), another option would have been separate 11.x and 10.3.x MRs here, but both need to be reviewed and RTBCed together if so.

I'll create the followup thanks!

Automatically closed - issue fixed for 2 weeks with no activity.