Fix the issues reported by phpcs

FILE: /paragraph_view_mode/src/Checker/WidgetSettingsCheckerInterface.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 22 | ERROR | Description for the @return value is missing ---------------------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/src/Checker/WidgetSettingsChecker.php ------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------- 20 | ERROR | [x] Data types in @var tags need to be fully namespaced 44 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/src/Plugin/Field/FieldWidget/ParagraphViewModeWidget.php -------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------- 103 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 182 | ERROR | [x] Expected 1 space after "="; 2 found 218 | ERROR | [x] Expected 1 blank line after function; 2 found -------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/src/ViewModeInterface.php ------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------- 10 | ERROR | [ ] Each @deprecated tag must have a @see tag immediately following it 14 | ERROR | [x] Additional blank lines found at end of doc comment ------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/src/Matcher/DisplayModeMatcherInterface.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] There must be one blank line after the namespace declaration ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/src/Matcher/DisplayModeMatcher.php ---------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------- 28 | ERROR | [ ] Missing parameter comment 62 | ERROR | [x] Data types in @var tags need to be fully namespaced 90 | ERROR | [ ] Description for the @return value is missing ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/paragraph_view_mode.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /paragraph_view_mode/paragraph_view_mode.module -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 47 | ERROR | [x] Expected 1 blank line after function; 0 found -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @Binoli Lalani
@binoli-lalani opened merge request.
Issue was unassigned.
Status changed to Needs review about 1 year ago9:25am 11 April 2023
Comment about 1 year ago →
🇮🇳India Binoli Lalani Gujarat
Hello,

I fixed PHPCS warnings and errors. Please review MR.

Thank you!
Status changed to Needs work about 1 year ago9:29am 11 April 2023
Comment about 1 year ago →
🇵🇱Poland sayco Toruń
Thanks, I've already made a release of the 3.1.2 version so this will stay for some time in dev, but before being merged please review and fix the comments, thank you!
Status changed to Needs review about 1 year ago9:37am 11 April 2023
Comment about 1 year ago →
🇮🇳India Binoli Lalani Gujarat
Hello @sayco,

Thank you for reviewing the code. I have changed the description as suggested. Please review.

Thank you!
Comment about 1 year ago →
System Message

sayco → committed 07d95303 on 3.x authored by Binoli Lalani →
Issue #3353395: Fix the issues reported by phpcs
Comment about 1 year ago →
🇵🇱Poland sayco Toruń
Status changed to Fixed about 1 year ago9:49am 25 April 2023
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities