Remove deprecated code from the entity system

Binoli Lalani → made their first commit to this issue’s fork.

Still a couple of unit test failures.

Also lots more:

core/lib/Drupal/Core/Entity/EntityTypeRepository.php:      @trigger_error('Calling EntityTypeRepository::__construct() without the $entityTypeBundleInfo argument is deprecated in drupal:10.3.0 and is required in drupal:11.0.0. See https://www.drupal.org/node/3365164', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueEntityStorage.php:    @trigger_error(__METHOD__ . '() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead. See https://www.drupal.org/node/3294237', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueEntityStorage.php:    @trigger_error(__METHOD__ . '() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use \Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision instead. See https://www.drupal.org/node/3294237', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php:            @trigger_error('Not providing a setDefaultTranslationEnforced() method when implementing \Drupal\Core\TypedData\TranslatableInterface is deprecated in drupal:10.2.0 and is required from drupal:11.0.0. See https://www.drupal.org/node/3376146', E_USER_DEPRECATED);
core/lib/Drupal/Core/Entity/Controller/EntityController.php:      @trigger_error('Calling ' . __METHOD__ . '() without the $route_match argument is deprecated in drupal:10.1.0 and it will be required in drupal:11.0.0. See https://www.drupal.org/node/3337782', E_USER_DEPRECATED);

Tried to address additional ones but could use some feedback about the KeyValueStorage

The KeyValue changes look sensible - removing methods from the non-revisionable storage and adding them to the ones that are.

@ binoli-lalani @longwave kindly please provide which tool you are using to check the deprecated code. so i can review this code. Because drupal-check is not working in drupal 11 setup

@Arun.k there is no special tooling, we are just grepping the relevant directories, like:

grep -r @deprecated core/lib/Drupal/Core/Entity/

Code that should be 'removed from drupal:11.0.0' is in scope for these issues. Code that says 'removed from drupal:12.0.0' should be left where it is for now.

Thankyou @catch for the knowledge and @smustgrave I have Verified and tested Merge request !7657 3442713-remove-deprecated-code on Drupal Version 11.x-dev & PHP Version 8.3

Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3442713 https://git.drupalcode.org/issue/drupal-3442713.git
3). git fetch drupal-3442713
4). git checkout -b '3442713-remove-deprecated-code' --track drupal-3442713/'3442713-remove-deprecated-code'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueContentEntityStorage.php
6). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/.phpstan-baseline.php to check deprecated code removed or not

Testing result:
Merge request !7657 3442713-remove-deprecated-code is fixed
Moved the issue to RTBC ++

Missed one earlier, I think core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php is in scope given it's the same revision methods we are deleting elsewhere in this issue.

Fixed #13, also re-added the comments back to EntityRepositoryInterface as that relates to code that is staying until Drupal 12.

Additional change seems good. Going to mark since this is blocking another deprecation ticket.

Got this started but missed so many here I think I'm still OK to commit. Committed/pushed to 11.x, thanks!

catch → closed merge request !7657

Automatically closed - issue fixed for 2 weeks with no activity.