I have created a custom module for this requirement and push code 3460930-installed-as-a on this branch
@samit.310@gmail.com i have checked and verified merge request MR !6768 and found that there is no warning showing.
steps to check
1. Install 11.x-dev on DDEV v1.22.6 and php 8.3.0
2. using git remote add drupal-3423775 https://git.drupalcode.org/issue/drupal-3423775.git
3. git fetch drupal-3423775
4. and then git checkout -b '3423775-symfony-mailer-description-fix' --track drupal-3423775/'3423775-symfony-mailer-description-fix'
5. install webform module and create form for mail sent.
6. Found no warning after going to branch 3423775-symfony-mailer-description-fix
@Soham Sengupta i have checked the merge request MR !8532 and found the refrence from the file core/modules/jsonapi/src/Normalizer/JsonApiDocumentTopLevelNormalizer.php has been removed and working fine.
Step to check
1. install drupal 11.x on DDEV v1.22.6 and php 8.3.0
2. use command git remote add drupal-3036284 https://git.drupalcode.org/issue/drupal-3036284.git
3. git fetch drupal-3036284
4. git checkout -b '3036284-clean-up-exceptionbuilderrors-returns' --track drupal-3036284/'3036284-clean-up-exceptionbuilderrors-returns'
and found removed refrence from the code
@Ibrahim Tameme i installed drupal 10.3.x on DDEV v1.22.6 and php 8.3.0 and apply the patch 3456536-fix-menu-expansion-7.patch which is working fine.
@quietone could you please explain the steps to reproduce this issue.
@RoloDMonkey i have install Drupal 11.x version on DDEV v1.22.6 and php 8.3.0 and reproduce the same criteria, but i didn't get this error on that version.
@joshuasosa when i installed drupal 11.x on DDEV v1.23.2 and PHP 8.3.8 version then i found no warning in this version of drupal. But yes i found warning on Drupal 11.0.x with installation on DDEV v1.23.2 with PHP 8.3.8 version. But we can remove this warning by doing the following changes in the file core/includes/theme.inc
diff --git a/core/includes/theme.inc b/core/includes/theme.inc
index 1603c5c65d..80182a1f59 100644
--- a/core/includes/theme.inc
+++ b/core/includes/theme.inc
@@ -1139,85 +1139,88 @@ function _template_preprocess_default_variables() {
* - page: A render element representing the page.
*/
function template_preprocess_html(&$variables) {
- $variables['page'] = $variables['html']['page'];
- unset($variables['html']['page']);
- $variables['page_top'] = NULL;
- if (isset($variables['html']['page_top'])) {
- $variables['page_top'] = $variables['html']['page_top'];
- unset($variables['html']['page_top']);
- }
- $variables['page_bottom'] = NULL;
- if (isset($variables['html']['page_bottom'])) {
- $variables['page_bottom'] = $variables['html']['page_bottom'];
- unset($variables['html']['page_bottom']);
- }
+ // Check if the 'html' array key exists.
+ if (isset($variables['html'])) {
+ $variables['page'] = $variables['html']['page'] ?? null;
+ unset($variables['html']['page']);
+ $variables['page_top'] = NULL;
+ if (isset($variables['html']['page_top'])) {
+ $variables['page_top'] = $variables['html']['page_top'];
+ unset($variables['html']['page_top']);
+ }
+ $variables['page_bottom'] = NULL;
+ if (isset($variables['html']['page_bottom'])) {
+ $variables['page_bottom'] = $variables['html']['page_bottom'];
+ unset($variables['html']['page_bottom']);
+ }
- $variables['html_attributes'] = new Attribute();
+ $variables['html_attributes'] = new Attribute();
- // element attributes.
- $language_interface = \Drupal::languageManager()->getCurrentLanguage();
- $variables['html_attributes']['lang'] = $language_interface->getId();
- $variables['html_attributes']['dir'] = $language_interface->getDirection();
+ // element attributes.
+ $language_interface = \Drupal::languageManager()->getCurrentLanguage();
+ $variables['html_attributes']['lang'] = $language_interface->getId();
+ $variables['html_attributes']['dir'] = $language_interface->getDirection();
- if (isset($variables['db_is_active']) && !$variables['db_is_active']) {
- $variables['db_offline'] = TRUE;
- }
+ if (isset($variables['db_is_active']) && !$variables['db_is_active']) {
+ $variables['db_offline'] = TRUE;
+ }
- // Add a variable for the root path. This can be used to create a class and
- // theme the page depending on the current path (e.g. node, admin, user) as
- // well as more specific data like path-frontpage.
- $is_front_page = \Drupal::service('path.matcher')->isFrontPage();
+ // Add a variable for the root path. This can be used to create a class and
+ // theme the page depending on the current path (e.g. node, admin, user) as
+ // well as more specific data like path-frontpage.
+ $is_front_page = \Drupal::service('path.matcher')->isFrontPage();
- if ($is_front_page) {
- $variables['root_path'] = FALSE;
- }
- else {
- $system_path = \Drupal::service('path.current')->getPath();
- $variables['root_path'] = explode('/', $system_path)[1];
- }
+ if ($is_front_page) {
+ $variables['root_path'] = FALSE;
+ }
+ else {
+ $system_path = \Drupal::service('path.current')->getPath();
+ $variables['root_path'] = explode('/', $system_path)[1] ?? null;
+ }
- $site_config = \Drupal::config('system.site');
- // Construct page title.
- if (isset($variables['page']['#title']) && is_array($variables['page']['#title'])) {
- // Do an early render if the title is a render array.
- $variables['page']['#title'] = (string) \Drupal::service('renderer')->render($variables['page']['#title']);
- }
- if (!empty($variables['page']['#title'])) {
- $head_title = [
- // Marking the title as safe since it has had the tags stripped.
- 'title' => Markup::create(trim(strip_tags($variables['page']['#title']))),
- 'name' => $site_config->get('name'),
- ];
- }
- // @todo Remove once views is not bypassing the view subscriber anymore.
- // @see
https://www.drupal.org/node/2068471 →
- elseif ($is_front_page) {
- $head_title = [
- 'title' => t('Home'),
- 'name' => $site_config->get('name'),
- ];
- }
- else {
- $head_title = ['name' => $site_config->get('name')];
- if ($site_config->get('slogan')) {
- $head_title['slogan'] = strip_tags($site_config->get('slogan'));
+ $site_config = \Drupal::config('system.site');
+ // Construct page title.
+ if (isset($variables['page']['#title']) && is_array($variables['page']['#title'])) {
+ // Do an early render if the title is a render array.
+ $variables['page']['#title'] = (string) \Drupal::service('renderer')->render($variables['page']['#title']);
+ }
+ if (!empty($variables['page']['#title'])) {
+ $head_title = [
+ // Marking the title as safe since it has had the tags stripped.
+ 'title' => Markup::create(trim(strip_tags($variables['page']['#title']))),
+ 'name' => $site_config->get('name'),
+ ];
+ }
+ // @todo Remove once views is not bypassing the view subscriber anymore.
+ // @see
https://www.drupal.org/node/2068471 →
+ elseif ($is_front_page) {
+ $head_title = [
+ 'title' => t('Home'),
+ 'name' => $site_config->get('name'),
+ ];
+ }
+ else {
+ $head_title = ['name' => $site_config->get('name')];
+ if ($site_config->get('slogan')) {
+ $head_title['slogan'] = strip_tags($site_config->get('slogan'));
+ }
}
- }
- $variables['head_title'] = $head_title;
+ $variables['head_title'] = $head_title;
- // Create placeholder strings for these keys.
- // @see \Drupal\Core\Render\HtmlResponseSubscriber
- $types = [
- 'styles' => 'css',
- 'scripts' => 'js',
- 'scripts_bottom' => 'js-bottom',
- 'head' => 'head',
- ];
- $variables['placeholder_token'] = Crypt::randomBytesBase64(55);
- foreach ($types as $type => $placeholder_name) {
- $placeholder = '<' . $placeholder_name . '-placeholder token="' . $variables['placeholder_token'] . '">';
- $variables['#attached']['html_response_attachment_placeholders'][$type] = $placeholder;
+ // Create placeholder strings for these keys.
+ // @see \Drupal\Core\Render\HtmlResponseSubscriber
+ $types = [
+ 'styles' => 'css',
+ 'scripts' => 'js',
+ 'scripts_bottom' => 'js-bottom',
+ 'head' => 'head',
+ ];
+ $variables['placeholder_token'] = Crypt::randomBytesBase64(55);
+ foreach ($types as $type => $placeholder_name) {
+ $placeholder = '<' . $placeholder_name . '-placeholder token="' . $variables['placeholder_token'] . '">';
+ $variables['#attached']['html_response_attachment_placeholders'][$type] = $placeholder;
+ }
}
}
Arun.k → changed the visibility of the branch 11.x to active.
Arun.k → changed the visibility of the branch 11.x to hidden.
hi @yovince we can solve this issue by doing in this way
$hltm = html_entity_decode($text, ENT_QUOTES, 'UTF-8');
// Remove empty paragraphs, including those with non-breaking spaces.
$text = preg_replace('/
( |\s|
)*<\/p>/', '', $html);
return $text;
Please check this i hope it works.
@smustgrave when i Tested this on a standard install of 11.x and added a link field to the basic content type and i didn't do anything in the field settings then i got trimmed url and when i did changes in the field settings link check the 'Url only' and 'Show URL as plain text' with trim at 80 chars, in that case i also got the trimmed url.
But alexpott when i tested the merge reuqest MR !6068 then i didn't get any trimmed url. And it's working fine.
@Vishal Choudhary i have tested and verified the issue ntc-3447046 and it is working fine. I have attached the screenshot regarding it.So i am move it to RTBC.
@maxilein need a more information and detail about it
@bradjones1 we need more information and steps, how to check it.
Hi @andypost i have tested MR !7836 3444232-8.4-fix-implicitly-ordering on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3444232 https://git.drupalcode.org/issue/drupal-3444232.git
3). git fetch drupal-3444232
4). git checkout -b '3444232-8.4-fix-implicitly-ordering' --track drupal-3444232/'3444232-8.4-fix-implicitly-ordering'
During testing the code i found some error on following files
1. core/lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/DefaultSelection.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/DefaultSelection.php, then i got the error
FILE: /var/www/html/drupal/core/lib/Drupal/Core/Entity/Plugin/EntityReferenceSelection/DefaultSelection.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
224 | WARNING | [x] '@todo: Use property labels instead of the column name.' should match the format '@todo Fix problem X here.'
227 | ERROR | [ ] The array declaration extends to column 157 (the limit is 120). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
2. core/lib/Drupal/Core/Template/TwigNodeTrans.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Template/TwigNodeTrans.php , then i got the error
FILE: /var/www/html/drupal/core/lib/Drupal/Core/Template/TwigNodeTrans.php
----------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------
95 | WARNING | [x] There must be no blank line following an inline comment
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
3. core/modules/content_moderation/src/Form/ContentModerationConfigureEntityTypesForm.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/modules/content_moderation/src/Form/ContentModerationConfigureEntityTypesForm.php , then i got the error
FILE: /var/www/html/drupal/core/modules/content_moderation/src/Form/ContentModerationConfigureEntityTypesForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
224 | ERROR | The array declaration extends to column 166 (the limit is 120). The array content should be split up over multiple lines
226 | ERROR | The array declaration extends to column 240 (the limit is 120). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------
4. core/modules/language/tests/src/Unit/ContentLanguageSettingsUnitTest.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/modules/language/tests/src/Unit/ContentLanguageSettingsUnitTest.php , then i got the error
FILE: /var/www/html/drupal/core/modules/language/tests/src/Unit/ContentLanguageSettingsUnitTest.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
154 | ERROR | [x] Missing function doc comment
183 | ERROR | [x] Missing function doc comment
217 | ERROR | [x] Missing function doc comment
284 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------
5. core/modules/node/src/NodeForm.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/modules/node/src/NodeForm.php , then i got the error
FILE: /var/www/html/drupal/core/modules/node/src/NodeForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
247 | ERROR | Missing parameter type
249 | ERROR | Missing parameter type
----------------------------------------------------------------------
6. core/tests/Drupal/Tests/Core/Entity/Routing/DefaultHtmlRouteProviderTest.php - checked this file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/tests/Drupal/Tests/Core/Entity/Routing/DefaultHtmlRouteProviderTest.php , then i got the error
FILE: /var/www/html/drupal/core/tests/Drupal/Tests/Core/Entity/Routing/DefaultHtmlRouteProviderTest.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
69 | ERROR | [x] Missing function doc comment
116 | ERROR | [x] Missing function doc comment
171 | ERROR | [ ] The array declaration extends to column 125 (the limit is 120). The array content should be split up over multiple lines
179 | ERROR | [ ] The array declaration extends to column 165 (the limit is 120). The array content should be split up over multiple lines
194 | ERROR | [ ] The array declaration extends to column 165 (the limit is 120). The array content should be split up over multiple lines
213 | ERROR | [x] Missing function doc comment
268 | ERROR | [x] Missing function doc comment
381 | ERROR | [ ] Missing short description in doc comment
385 | ERROR | [ ] Description for the @return value is missing
401 | ERROR | [x] Missing class doc comment
403 | WARNING | [ ] Possible useless method overriding detected
403 | ERROR | [x] Missing function doc comment
407 | WARNING | [ ] Possible useless method overriding detected
407 | ERROR | [x] Missing function doc comment
411 | WARNING | [ ] Possible useless method overriding detected
411 | ERROR | [x] Missing function doc comment
415 | WARNING | [ ] Possible useless method overriding detected
415 | ERROR | [x] Missing function doc comment
419 | WARNING | [ ] Possible useless method overriding detected
419 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------
@andypost Now then We Need to move RTBC
Thanks
Hi @andypost i have tested MR !7816 3444026-8.4-fix-null-modules on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3444026 https://git.drupalcode.org/issue/drupal-3444026.git
3). git fetch drupal-3444026
4). git checkout -b '3444026-8.4-fix-null-modules' --track drupal-3444026/'3444026-8.4-fix-null-modules'
During testing the code i found some error on following files
1. core/modules/node/src/NodeForm.php - when i cheked this file using php -d error_reporting="E_ALL" -l core/modules/node/src/NodeForm.php|grep deprecated then i didn't get anything but when i checked the same file using vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/modules/node/src/NodeForm.php then i got the error
FILE: /var/www/html/drupal/core/modules/node/src/NodeForm.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
240 | ERROR | Missing parameter type
242 | ERROR | Missing parameter type
----------------------------------------------------------------------
So i removed this error by adding parameter type like below :-
/**
* Form submission handler for the 'preview' action.
*
* @param array $form
* An associative array containing the structure of the form.
* @param \Drupal\Core\Form\FormStateInterface $form_state
* The current state of the form.
*/
before the above comment was like below :-
/**
* Form submission handler for the 'preview' action.
*
* @param $form
* An associative array containing the structure of the form.
* @param $form_state
* The current state of the form.
*/
except this all the files code are fine
@alexpott I have tested and Verified MR !7608 3413657-update-copyright.txt-for on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3413657 https://git.drupalcode.org/issue/drupal-3413657.git
3). git fetch drupal-3413657
4). git checkout -b '3413657-update-copyright.txt-for' --track drupal-3413657/'3413657-update-copyright.txt-for'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/COPYRIGHT.txt
to check the file, it showing no nothing just warning on line 29 i.e 'Line exceeds 80 characters; contains 102 characters'. So if we enter on the line like below then it removes the warning
'JavaScript Cookie - Copyright (c) 2018 Copyright 2018 Klaus Hartl,
Fagner Brack, GitHub Contributors'
Otherwise everything is fine
Testing result:
MR !7608 3413657-update-copyright.txt-for is fixed
Moved the issue to RTBC ++
Thankyou @catch for the knowledge and @smustgrave I have Verified and tested Merge request !7657 3442713-remove-deprecated-code on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3442713 https://git.drupalcode.org/issue/drupal-3442713.git
3). git fetch drupal-3442713
4). git checkout -b '3442713-remove-deprecated-code' --track drupal-3442713/'3442713-remove-deprecated-code'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueContentEntityStorage.php
6). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/.phpstan-baseline.php to check deprecated code removed or not
Testing result:
Merge request !7657 3442713-remove-deprecated-code is fixed
Moved the issue to RTBC ++
Hi nicxvan,
I have Verified and tested MR !7683 3443049-remove-deprecations-in on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3443049 https://git.drupalcode.org/issue/drupal-3443049.git
3). git fetch drupal-3443049
4). git checkout -b '3443049-remove-deprecations-in' --track drupal-3443049/'3443049-remove-deprecations-in'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php to check the that deprecated code removed or not and check the site afer that
Testing result:
MR !7683 3443049-remove-deprecations-in issue is fixed
Moved the issue to RTBC ++
@ binoli-lalani @longwave kindly please provide which tool you are using to check the deprecated code. so i can review this code. Because drupal-check is not working in drupal 11 setup
@nicxvan kindly please provide which tool you are using to check the deprecated code. so i can review this code.
Please right the steps to reproduce the problem and kindly please provide the proposed solution
thanks
@_renify_ i have tested this patch, its working fine and found no compatibility issue, but after activate the module, i used this module block on the region, then i didn't get any feeds through this module
budalokko → credited Arun.k → .
@webengr, Yes This module is not available on drupal 10 with the recommended installation by composer
@RenataBin Actually when its compatibility issue will fix then it is available in Drupal 10 and also get by composer.