- ๐ณ๐ฑNetherlands bbrala Netherlands
This issue is referenced in the code of json:api
core/modules/jsonapi/src/Normalizer/JsonApiDocumentTopLevelNormalizer.php:217
. If we decided this is not an issue we should use this issue to remove the reference. - ๐ฎ๐ณIndia Soham Sengupta
Soham Sengupta โ made their first commit to this issueโs fork.
- Merge request !8532Issue #3036284: Clean-up: *Exception::buildErrors returns an array of errors, but never returns >1 error. โ (Open) created by Soham Sengupta
- Status changed to Needs review
5 months ago 6:31am 25 June 2024 - ๐ฎ๐ณIndia Soham Sengupta
I have removed the reference from the code and created the MR. Moving the issue to Needs Review state.
Thank you. - ๐ฎ๐ณIndia onkararun
@Soham Sengupta i have checked the merge request MR !8532 and found the refrence from the file core/modules/jsonapi/src/Normalizer/JsonApiDocumentTopLevelNormalizer.php has been removed and working fine.
Step to check
1. install drupal 11.x on DDEV v1.22.6 and php 8.3.0
2. use command git remote add drupal-3036284 https://git.drupalcode.org/issue/drupal-3036284.git
3. git fetch drupal-3036284
4. git checkout -b '3036284-clean-up-exceptionbuilderrors-returns' --track drupal-3036284/'3036284-clean-up-exceptionbuilderrors-returns'
and found removed refrence from the code - Status changed to RTBC
5 months ago 10:20am 25 June 2024 - Status changed to Needs work
4 months ago 1:49am 19 July 2024 - ๐ณ๐ฟNew Zealand quietone
Not sure about this. The coding standards state
Usually, a corresponding Drupal.org issue should be created for the @todo and referenced in it.
That recommends that this @todo should link to the issue where the work is being done. That helps us find the work to do, a @todo without an issue tends to be forgotten. I'd much rather this have a link to an issue.
- ๐ณ๐ฑNetherlands bbrala Netherlands
You are right, not sure how i missed that.
The change did not so as per IS, remove the whole todo.