hussainweb โ credited soham sengupta โ .
I have added the fix, now the method createForSubform() throws an exception if the #tree property is not set, for non empty forms.
Moving the issue to Needs Review state.
Thank you.
Soham Sengupta โ made their first commit to this issueโs fork.
I have removed the reference from the code and created the MR. Moving the issue to Needs Review state.
Thank you.
Soham Sengupta โ made their first commit to this issueโs fork.
Hi, I have added the changes and created the MR. Moving the issue status to Needs Review.
Thank you.
Soham Sengupta โ made their first commit to this issueโs fork.
Soham Sengupta โ created an issue.
Hi, I have updated the param doc. Please review.
Hi, I have fixed the remaining issues.
Hi,
I have fixed the remaining phpcs error in this patch.
Hi,
I have updated the patch file with the remaining fixes.
Hi, I have created the patch with the proposed fix.
Thanks, I have updated the patch with the suggested changes, however I was unable to include the namespace of the class in the block constructor short description, as it was exceeding 80characters and the short description should be in a single line.
Hi, Updated the patch with the suggested changes.
Thanks, Updated the patch as per the suggestions.
Hi, I have updated the patch with the changes.
Hi, I have updated the patch with the changes
Hi, I have updated the patch with remaining error fixes
Thanks, I have updated the description as per your suggestion.
Hi, I have updated the patch with the changes
Hi, I have updated the parameter comments.
I checked that, $message is an unused variable as it was not being used anywhere in the function, hence, the line is commented.
Fixed the mentioned issues -
- corrected the misspelled class name
- added the namespace to class documentation comment
- reused the parent properties
I will try fixing the issues. Thanks,