๐Ÿ‡ฎ๐Ÿ‡ณIndia @Soham Sengupta

Account created on 23 December 2021, almost 3 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

I have added the fix, now the method createForSubform() throws an exception if the #tree property is not set, for non empty forms.
Moving the issue to Needs Review state.
Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

I have removed the reference from the code and created the MR. Moving the issue to Needs Review state.
Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have added the changes and created the MR. Moving the issue status to Needs Review.
Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have fixed the remaining issues.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi,

I have fixed the remaining phpcs error in this patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi,
I have updated the patch file with the remaining fixes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Thanks, I have updated the patch with the suggested changes, however I was unable to include the namespace of the class in the block constructor short description, as it was exceeding 80characters and the short description should be in a single line.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, Updated the patch with the suggested changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Thanks, Updated the patch as per the suggestions.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have updated the patch with the changes

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have updated the patch with remaining error fixes

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Thanks, I have updated the description as per your suggestion.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have updated the patch with the changes

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

Hi, I have updated the parameter comments.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

I checked that, $message is an unused variable as it was not being used anywhere in the function, hence, the line is commented.
Fixed the mentioned issues -
- corrected the misspelled class name
- added the namespace to class documentation comment
- reused the parent properties

๐Ÿ‡ฎ๐Ÿ‡ณIndia Soham Sengupta

I will try fixing the issues. Thanks,

Production build 0.71.5 2024