- Issue created by @urvashi_vora
- Status changed to Needs work
over 1 year ago 9:56am 29 April 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
/** - * Class PaymentOffsiteForm. + * Implements Class PaymentOffsiteForm. *
The short description for a class does not start with Implements nor doe it repeat the class name. (Also, saying that a class implements itself does not make sense.)
- "redirect_url" => Url::FromRoute('commerce_payment.checkout.return', ['commerce_order' => $order_id, 'step' => 'payment'], ['absolute' => TRUE])->toString(), + "redirect_url" => Url::FromRoute('commerce_payment.checkout.return', + ['commerce_order' => $order_id, 'step' => 'payment'], + ['absolute' => TRUE])->toString(),
Drupal coding standards say that lines are allowed to be longer than 80 character, if they are more readable. The changed code is not more readable and it is wrongly indented.
- Status changed to Needs review
over 1 year ago 2:29pm 29 April 2023 - Status changed to Needs work
over 1 year ago 6:50pm 29 April 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
/** - * Class PaymentOffsiteForm. + * Provides payment off site form.
Actually, it is the off-site payment form, which means the full description is Provides the off-site payment form.
- Status changed to Needs review
over 1 year ago 4:18am 1 May 2023 - 🇮🇳India Soham Sengupta
Thanks, I have updated the description as per your suggestion.
- Status changed to RTBC
over 1 year ago 7:12am 1 May 2023 - 🇮🇳India Mahima_Mathur23
Verified the patch.
The changes raised by @apaderno have been incorporated and there are no more Phpcs errors.Moving to RTBC.
- Assigned to i-trokhanenko
- Status changed to Downport
over 1 year ago 9:43pm 3 May 2023 -
i-trokhanenko →
committed ef8c3791 on 8.x-1.x
Issue #3357101 by Soham Sengupta, urvashi_vora: Fix the issues reported...
-
i-trokhanenko →
committed ef8c3791 on 8.x-1.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 4:50pm 4 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.