@avpaderno we can mark the issue as Fixed. Thank you!
@astonvictor I've just made you a co-maintainer. Thanks for your contribution!
Let's commit this issue first - ✨ Convert simple popup block to config entity Active
MR#12 needs to be rerolled to the 4.x branch.
Created a new 4.x branch as suggested in comment #3.
Thanks!
Thanks!
Thanks!
Thanks!
i-trokhanenko → made their first commit to this issue’s fork.
Committed, thanks!
i-trokhanenko → made their first commit to this issue’s fork.
Patch #14 works well for me.
+1 RTBC
i-trokhanenko → created an issue.
Rerolled the #5 patch
Thanks!
i-trokhanenko → made their first commit to this issue’s fork.
Thanks!
Thanks!
Committed. Thanks!
i-trokhanenko → made their first commit to this issue’s fork.
I see many changes in MH 13 that are not related to this issue
https://git.drupalcode.org/project/views_load_more/-/merge_requests/13.diff
I have the same error when importing pages created using the layout builder.
Patch #2 fixed the error for me. Thanks! +1 RTBC
Drupal core - 10.3.10
Single Content Sync - 1.4.8
@barry_fisher thank you! As there is a patch, this issue can be set on Needs Review so other people know they can review it.
Committed, thanks!
Committed to 2.x and 3.x branches. Thanks!
i-trokhanenko → made their first commit to this issue’s fork.
Thanks!
Thanks!
Thanks
Thanks!
Committed.
I've committed the
🐛
Remove unneeded role="navigation" attribute from element
Needs review
issue.
MR#13 needs to be updated as we have merge conflicts.
Thanks!
Committed, thanks!
Added one more fixed issue - 🐛 Reset button is not cleaning filters Active
Merged, thanks!
Thanks!
Merged. Thanks!
Thanks!
Created a MR from the patch #2
i-trokhanenko → made their first commit to this issue’s fork.
Moving this issue back to "Needs Review" status because merge request #24 was not merged.
Hi Igor, thank you for your interest in becoming a co-maintainer for this module. Since this project is covered by Drupal's security advisory policy, all co-maintainers must have the "Can opt projects into security advisory coverage" permission on their Drupal.org profile.
To obtain this permission, you will need to apply through the Drupal Security Team → . The process involves demonstrating your experience with Drupal and contributing to the community (e.g., submitting patches, resolving issues, or maintaining other projects). Once you’ve been granted this permission, let me know, and I’ll gladly proceed with adding you as a co-maintainer.
Thank you for your understanding, and feel free to reach out if you need assistance with the application process.
Added @mcdruid as co-maintainer. Thanks for your contribution.
MR #7 works well for me. Thanks!
+1 RTBC
@alexmarkley I committed the patch you mentioned
https://www.drupal.org/project/simple_popup_blocks/issues/3267864#commen...
🐛
Warning: htmlspecialchars() expects parameter 1 to be string, array given
RTBC
Let me know if you have any other issues.
Thanks!
Thanks, I'll commit the #9 patch.
Thanks!