Hi AppLEDaY,
Below is how I resolved third party cookie creation. Here is what you can try:
Make the categories available in your script: I chose to make a cookie, you can choose whatever you feel like according to your options.
Then make changes in the script to only create the cookie when the specific category is selected i.e. add an if condition that checks if your setup cookie contain that category or not and also add an else part to remove that cookie when the category is removed if you are giving access to the user to play with the categories again and again.
Hope this helps!
Mahima
I was able to replicate the issue too.
Although it will not be feasible to check the filesystem. And in case of using S3, if there is a lag, checking is even not going to be possible.
As a temporary solution, can we give an error message that is more descriptive like: "Unable to upload the file, please try again with a different file name" or something like this.
@Nilesh,
You need to be in the exact location before applying the patch, not in the base path.
The Current Password field is now optional as I can see in Drupal 9.5x.
The field becomes mandatory if you fill the Password and Confirm Password fields which means when you are trying to change your password you need to give the old password otherwise for any other change it is not required.
Changing status to Needs Review. Although I think this can be closed as this is already fixed.
I like the suggestion given in #49, Although the third sentence is kind of redundant because one-time login link actually means that it cannot be used again.
Also, I think that "Change your password now" is giving a very urgent message which is not required, because no matter what, the user can get a one-time login link again if he doesn't change the password just now.
So, if we could add something like Change your password to something you can remember the next time or rather Set up your secure password for the next time.
I don't think README file is just supposed to say what the module page says. It should have a more first hand usage description of the module.
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command generates.
@Ashutosh Ahirwal,
Can you also attach an interdiff that is there with the previous patch.
@keshav.k
Can you also check the logs for any error.
Refer tickets:
https://www.drupal.org/project/domain_path/issues/3357351
🐛
error when manually adding an alias
Active
If they have some similarities that can aid you.
@himanshu_jhaloya, Please work upon the previous patch and incorporate @apaderno's suggestions.
Otherwise we start from square one everytime.
I confirm that there is no phpcs issue after applying Patch #2.
Please refer the screenshot.
Some of the comments needs more description like the Constructor of "MenuTreeCompareController" class.
Verified the patch.
The changes raised by @apaderno have been incorporated and there are no more Phpcs errors.
Moving to RTBC.
Verified the patch.
The changes raised by @apaderno have been incorporated and there are no more Phpcs errors.
Moving to RTBC.
Reviewed the patch to be working as expected.
And can see that the issue summary has added command used to replicate the report.
Patch #29 seems to have incorporated the raised changes by @apaderno in #27 except the 1st one.
Changes suggested by @aparderno has been incorporated in the MR changes done in #20 by @mukesh88.
Reviewed the patch.
Attaching screenshot for reference.
Moving to RTBC
Reviewed the patch.
Attaching screenshot post patch application
Moving to RTBC.
Reviewed the Patch. All the Phpcs errors have been fixed. Attaching screenshot for reference.
Moving. to RTBC.
Reviewed the Patch, all the Phpcs errors have been addressed. Attaching screenshot for reference.
Moving to RTBC.
Patch applied successfully on Drupal 9.5.7
@Anmol_Specbee Which version you tried to test it on?
This module is not compatible with Drupal 10 if that is what you were using.
Reviewed the patch. It fixed some issues. Attaching the screenshot of the remaining ones.
@akshaydalvi212,
Please also attach the interdiff file.
@sakthi_dev, Still do not see the second change suggested by @apaderno in the MR.
Verified the MR. All the issues are resolved, post applying the patch. Attaching screenshot for reference.
Moving to RTBC.
Unable to apply patch in Drupal 10. Attaching the error screenshot.
Patch was applied successfully.
Proper nouns "Node Read Time" and "Twig" are capitalized in README file too.
Moving to RTBC.
Reviewed the MR, can see the Help text.
Although, I am a little doubtful regarding the format of this help text page. Attaching the screenshot for reference.
Let's get someone else's approval too. Post which it can be moved to RTBC.
Reviewed the MR. Attaching the screenshot of the help text page.
Moving to RTBC.
Changed the MR to use the README.md file to display help text as the previous help text was very limited and did not contain any additional detail than the module page.
Mahima_Mathur23 → made their first commit to this issue’s fork.
Please try to add more description in the help text or you can use the README.md file for the same. Please refer similar other issues for reference.
Reviewed the MR.
"Maxlength" has been changed to "MaxLength" in the labels/descriptions/comments.
Moving to RTBC.
Patch #11 does
Reviewed the Patch.
The spelling of "removed" has been rectified.
Moving to RTBC.
Reviewed the MR. Moving to RTBC.
The hook_help has been updated according to the README.txt file.
Review completed for MR !7 updated in #12.
Reviewed the patch.
The breadcrumb_builder service has been prioritised.
The help text doesn't say anything more than the module page. Please add some more description to it or use ReadME file for the same.
Verified the MR. Moving to RTBC.
Verified the MR. Moving to RTBC.
Incorporated #6 and #7 in the MR.
Mahima_Mathur23 → made their first commit to this issue’s fork.
The file has been successfully renamed. Moving to RTBC.
The patch was applied successfully, and the error has been resolved.
Moving to RTBC.
@akshaydalvi212
The patch failed to apply. Attaching screenshot for reference.
Reviewed the MR. Help text is available in the module. Attaching screenshot for reference.
Attaching the patch for changing the setting page to display EU, EEC countries and the UK rather than only EU countries.
As it is in Drupal 7 whose support will end in this year, I haven't made much changes, just some significantly required ones.
Reviewed the MR #7. Attaching before, after screenshots with help text.
Verified the updated MR by @elber in #16.
Wrong hook_help MR created. The module is Sticky and hook_help for ECK Bundle Permission module is created.
Reviewed the MR. Attaching the before_patch and after_patch screenshots.
Please ignore previous comment "#8". Posted in the wrong issue.
Reviewed the MR. Attaching the screenshots: before_patch and after_patch.
I am unable to replicate the issue too with Drupal 10 as well.
Any replication steps would be appreciated.
Does this seems like an accepted help text @apaderno:
"When we choose a field as autocomplete, we get the id associated with the name in the suggested list. For example, admin shows as admin (1).
This module hides that id using a simple JS while showing the list and restores it before sending it to the server. Hence, it implements a layer of security by hiding the id and only showing the name."
Once approved, I will create an MR.