- Issue created by @Kamlesh Kishor Jha
- @kamlesh-kishor-jha opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:44am 6 February 2023 - 🇮🇳India Kamlesh Kishor Jha Jaipur
Created MR for this issue.
Please review this.
Thanks. - 🇮🇳India Jaspreet-Kaur
hook_help() worked for me. MR! applied on Drupal 9.5.1
I am sharing the before and after screen shots for the references. Thanks!
- Status changed to Needs work
over 1 year ago 2:03pm 7 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ $output .= '<p>' . t('Hides drupal id from autocomplete results. Replaces admin (1) to admin in autocomplete widget.') . '</p>'; + $output .= '<p>' . t('Uses simple js to hide it, before submit ids restore and send to the server.') . '</p>';
That description does not make clear what the module does. There are words that are not spelled correctly. Also, repeating two sentences from the project page is not sufficient.
- Assigned to elber
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:38pm 7 March 2023 - Status changed to Needs work
over 1 year ago 3:37pm 7 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
What reported in my previous comment still holds true.
- 🇮🇳India Mahima_Mathur23
Does this seems like an accepted help text @apaderno:
"When we choose a field as autocomplete, we get the id associated with the name in the suggested list. For example, admin shows as admin (1).
This module hides that id using a simple JS while showing the list and restores it before sending it to the server. Hence, it implements a layer of security by hiding the id and only showing the name."
Once approved, I will create an MR.
- Assigned to himanshu_jhaloya
- @himanshu_jhaloya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:45am 28 March 2023 - 🇮🇳India Mahima_Mathur23
Reviewed the MR. Attaching the before_patch and after_patch screenshots.
- 🇧🇷Brazil elber Brazil
Hi I update the hook help following the Mahima's comment (#11).
I believe that description is very goog to the module, it is simple and describes which module does. Please revise.
- Status changed to RTBC
over 1 year ago 10:40am 24 April 2023 - Assigned to Bushra Shaikh
- Status changed to Needs review
over 1 year ago 12:34pm 24 May 2023 - Status changed to RTBC
over 1 year ago 12:51pm 24 May 2023 - 🇮🇳India Bushra Shaikh
I applied the MR !2 on Drupal 9.5.8 version. And it worked.
- Issue was unassigned.