- Issue created by @dineshreddymathuku
- @dineshreddymathuku opened merge request.
- Status changed to Needs review
almost 2 years ago 9:55am 6 February 2023 - ๐ฎ๐ณIndia Mahima_Mathur23
Wrong hook_help MR created. The module is Sticky and hook_help for ECK Bundle Permission module is created.
- Status changed to Needs work
over 1 year ago 9:34am 29 March 2023 - Assigned to akshaydalvi212
- ๐ฎ๐ณIndia akshaydalvi212
I will provide the patch file with the hook_help() implemented.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:42am 29 March 2023 - ๐ฎ๐ณIndia akshaydalvi212
providing the #7 patch with implementation of hook_help().
kindly review. - ๐ฎ๐ณIndia nayana_mvr
This module already has a hook_help function. In the latest patch, only the text which is displayed in the help page is changed. Is it really required to change that text? If so, then it will be good if we can get a confirmation about the same.
- Status changed to RTBC
over 1 year ago 10:19am 5 April 2023 - ๐ต๐ญPhilippines clarkssquared
Hi nayana_mvr
I confirmed that the Sticky module version 2.1.1 has a hook_help function already, I also applied patch #7 and compared the help page texts and I noticed that the default help page text is way more informative and helpful compared to the help page after patch #7.
Please look at the attached screenshot for your reference
Thank you.
- ๐ง๐ชBelgium f0ns
Thank you all for your input, I donโt think the initial patch adds any value to the module so Iโm closing this issue for now.
Thank you!
- Status changed to Closed: won't fix
over 1 year ago 11:11am 5 April 2023