- Issue created by @jay jangid
- @jay-jangid opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:33am 24 February 2023 - 🇮🇳India jay jangid Jaipur
Created MR for this issue , please review.
Thank you.
- Status changed to Needs work
almost 2 years ago 9:15am 24 February 2023 - 🇮🇳India adminazhar
@Jay
Updated the code. The pipeline seems to be failing, kindly try to fix it, otherwise it looks good.Tested on Drupal 9.5.3, and it is working good.
- 🇺🇸United States DamienMcKenna NH, USA
Two issues:
1. Text strings should be written on one line and not split at character 80, see https://www.drupal.org/docs/develop/standards/php/php-coding-standards#l... → for details.
2. This needs to describe more of how to use the module; it might be worth just loading the README.md file, as lots of other modules do. - First commit to issue fork.
- Assigned to akshaydalvi212
- Status changed to Needs review
over 1 year ago 1:28pm 3 April 2023 - 🇮🇳India akshaydalvi212
Update the MR and updated the implementation of hook_help().
- Issue was unassigned.
- 🇮🇳India akshaydalvi212
providing the screenshot for reference after the MR is updated.
kindly review. - Assigned to Mahima_Mathur23
- 🇮🇳India Mahima_Mathur23
@akshaydalvi212
The patch failed to apply. Attaching screenshot for reference.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 12:52pm 4 April 2023 - Assigned to elber
- Issue was unassigned.
- Status changed to RTBC
over 1 year ago 2:15pm 4 April 2023 - 🇧🇷Brazil elber Brazil
Hi I revised the MR changes there are good hook help is following DamienMcKenna suggestion.
Tests are already been failing before of this issue.
I will open another issue to fix the tests.
- Status changed to Needs review
over 1 year ago 5:48pm 5 April 2023 - 🇺🇸United States DamienMcKenna NH, USA
Let's take advantage of the Markdown module if it's present.
-
DamienMcKenna →
committed c7c09922 on 8.x-1.x
Issue #3344166 by Jay Jangid, DamienMcKenna, akshaydalvi212,...
-
DamienMcKenna →
committed c7c09922 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 5:59pm 19 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.