I will be pushing changes to the same MR soon, for all the 4 tasks, and for 5th we have to create a new new issue.
admin@azhark.com → made their first commit to this issue’s fork.
admin@azhark.com → made their first commit to this issue’s fork.
@yahyaalhamad Not sure why credits are not assigned to me.
- Reviewed the first version
- Provided the new complete text which needs be done in the help page
- Reviewed the revised version.
Created a new MR, since the last MR was on diff ver of core, also the help page contained D9 function but this is D7.
Kindly Review: Merge request !3
Thanks!
adminazhar → made their first commit to this issue’s fork.
I disagree with you @Prashant.c, the help page shows after installation, so there is no need to add the installation instructions etc in the help page.
It would be better to have a better help page by cleanup up few headings from readme and add better text.
Created a new MR with changes, since the old MR was directly has MR to dev branch instead of a issue branch.
Kindly Review: Merge request !7
Thanks
adminazhar → made their first commit to this issue’s fork.
Kindly Review the latest MR changes.
Re-did as per the suggestion.
@fago yeah, the code seems for other module. Redoing it.
adminazhar → made their first commit to this issue’s fork.
Opened a new MR, since I have re-written/formatted the whole content and it's good to have a separate branch for each issue for seamless merging.
Kindly Review: merge request !2
adminazhar → made their first commit to this issue’s fork.
Kindly Review: Merge request !10
Thanks!
adminazhar → made their first commit to this issue’s fork.
@Artyom Hovasapyan Not sure why the credits were not given me, I provided/written the help page content and reviewed the MR.
Re-did the whole text according to Drupal help page standards.
Kindly Review: Merge request !4
Thanks!
Re-wrote the help page.
Kindly Review: Merge request !7
Kindly Review: Merge request !1
adminazhar → made their first commit to this issue’s fork.
Kindly Review: Merge request !4
MR is merged. Closing this.
Re-did the help text with select entity encoding.
Kindly Review: Merge request !21
adminazhar → made their first commit to this issue’s fork.
Kindly Review: MR!4
adminazhar → made their first commit to this issue’s fork.
Added Issue Summary and raised new MR.
Kindly Review: Merge request !9
Kindly Review: MR!10
adminazhar → made their first commit to this issue’s fork.
Updated the Issue Summary and also Updated the help text with new MR!4.
Kindly review: Merge request !4
adminazhar → made their first commit to this issue’s fork.
Rewrote the help text: Merge request !2
Kindly Review, Thanks!
adminazhar → made their first commit to this issue’s fork.
@apaderno updated, as per your suggestion
Kindly Review: Merge request !14
Thanks
adminazhar → made their first commit to this issue’s fork.
Pushed MR for easy merging in the project.
Kindly Review: Merge request !1
Updated the help text.
Thanks
Kindly review: Merge request !7
Updated Text and cleanup up formatting.
Thanks!
adminazhar → made their first commit to this issue’s fork.
Kindly Review: Merge request !2
Thanks!
adminazhar → made their first commit to this issue’s fork.
Kindly review new Merge request !3
adminazhar → made their first commit to this issue’s fork.
Kindly Review new MR!5
adminazhar → made their first commit to this issue’s fork.
Kindly Review: merge request !6
adminazhar → made their first commit to this issue’s fork.
Kindly Review: MR!9
adminazhar → made their first commit to this issue’s fork.
Kindly review: merge request !9
Updated the help texts.
adminazhar → made their first commit to this issue’s fork.
Kindly Review: merge request !13
adminazhar → made their first commit to this issue’s fork.
@hchonov
Kindly review Merge request !4 , Removed Notes section as per suggestion.
adminazhar → made their first commit to this issue’s fork.
@apaderno Removed quotes as per suggestion.
@apaderno Corrected as per suggestion.
Thanks @spriya2896
LGTM. RTBC
Kindly Review Merge request !8
@Shubham
Kindly update the text with below:
Automatic Site Icon Picker module is a small tool designed to simplify the process of selecting a site icon for a web application. This module works in conjunction with the Faviconkit JavaScript library.
Advantages:
-Easy to use: The module is user-friendly and does not require advanced technical skills to operate.
-Small size: The module has a small footprint, minimizing its impact on website performance.
-Avoids redundant requests: The module does not download images that have already been retrieved, preventing redundant requests and reducing network traffic.
-Flexible icon display options: The module allows for the display of site icons in different formats
@spriya2896 The MR!3 looks good, kindly update the text to the below text instead of using the project first para:
The "360 Image Field Formatter" module is designed to improve the display and user experience of 360-degree images within a web application. When installed, this module creates a new field formatter that allows for the rendering of 360-degree images through the use of the Photo-Sphere-Viewer JavaScript library. This library, written by Jérémy Heleine, enables the interactive display of images, allowing users to zoom in and out, pan around, and explore the image from all angles.
Create new merge request !2 based on the feedback by @apaderno
Kindly review
adminazhar → made their first commit to this issue’s fork.
@apaderno
Correct.
Updated the MR with useful text.
adminazhar → made their first commit to this issue’s fork.
Reviewed and tested the Readme file, it works great.
It will be a big update in terms of formatting for the readme.
@Jay
Updated the code. The pipeline seems to be failing, kindly try to fix it, otherwise it looks good.
Tested on Drupal 9.5.3, and it is working good.
Instead of whole readme.txt file, it would be better if you can add only the 2 paragraphs of the Module Description:
This module generates a new field formatter for 360 images.
The images are rendered by the Photo-Sphere-Viewer JavaScript library written by Jérémy Heleine.LGTM.
Tested on Drupal 9.5.3, works as expected. Attached Screenshot.
LGTM.
Text Changed: From image field 360 to Image Field 360
Files Changed: image_field_360.info.yml
Tested on Drupal 9.5.3