- Issue created by @shubham rathore
- @shubham-rathore-0 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 5:18am 7 February 2023 - 🇮🇳India shubham rathore Jaipur
Created MR for the issue.
Please review.
Thanks - Assigned to Charchil Khandelwal
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 1:19pm 7 February 2023 - 🇮🇳India Charchil Khandelwal
MR !1 looks good to me.
So moving it to RTBC.Thanks.
- Status changed to Needs work
almost 2 years ago 1:38pm 7 February 2023 - 🇳🇱Netherlands ekes
If a `hook_help` is to be implemented in Drupal now it is only valuable if it includes the uses section as per documentation https://www.drupal.org/node/632280#s-help-page → Repeating the description of the module in the help page about section is only visible once the module has been installed. Where you can see the description itself before installing.
There's an issue for https://www.drupal.org/project/geo_entity/issues/3339631 📌 Add usage documentation Active adding the usage documentation. You can work from the existing https://github.com/localgovdrupal/localgov_geo/wiki/Locations-Module-(LocalGov-Geo) documentation, but it needs updating for this version.
Also this patch includes
'single quoted content'
inside a'single quoted content'
without escaping, so it will break - Assigned to elber
- @elber opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:43pm 27 February 2023 - 🇧🇷Brazil elber Brazil
Hi I just launched a suggestion to hook help please revise.
- Status changed to Needs work
over 1 year ago 2:53pm 27 February 2023 - 🇳🇱Netherlands ekes
The latest version of the PR will just dump the unformatted raw markdown into the help page. Kinda scarey and not really great UX.
I will repeat what I said above, and try explaining again. If a hook_help() is to be useful it needs to include help for a user who has installed the module. You can't see the help until it's actually installed... you can see the module page and readme on the web before it's installed.
If people would like to be helpful. Please update the documentation for this module (see existing issue for links), and include this with appropriate links to pages within the users site.
Anything else is just a waste of everyones time.
- Assigned to elber
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:16pm 27 February 2023 - 🇧🇷Brazil elber Brazil
Hi I update the hook help trying to follow your suggestions, please revise.
- Assigned to WagnerMelo
- Status changed to Needs work
over 1 year ago 11:21am 2 March 2023 - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:33pm 8 March 2023 - 🇧🇷Brazil elber Brazil
Hi I update hook help trying to follow the previous comments, please revise.
- 🇧🇷Brazil elber Brazil
Hi @Nupur Badola it is expected because the branch is compatible just with drupal 10.
- 🇮🇳India kavitha@specbee.com
Verified the MR4 on 10.1.0, help() is added. Added screenshots for reference & it can be moved to RTBC
Thank you.
- Status changed to RTBC
over 1 year ago 10:14am 4 August 2023