Recife, Pernambuco
Account created on 2 February 2022, almost 3 years ago
  • Developer at CI&T 
#

Recent comments

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll review it. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i reviewed this issue and found a error, after appleyed the oldest patch in my environment, so i'm sending other patch.
Please revise that. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i reviewed this issue, and the module keep work as expected, and all links related on help page are working.
I'll move this issue to RTBC

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll review it. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i worked in this issue, and the test are sucessfull now. Was tested in two diferents environments.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

I hope helped with my comment.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hello, when I got this problem I noticed that all the errors pointed out by phpcs were resolved in #4, but the tests failed, I tried to solve the tests but now I don't have enough knowledge to solve these errors. And I don't know if it's correct to resolve this test error in this issue or create another one just to solve tests.
If it is necessary to create another issue to resolve the tests, I believe this issue can be moved to RTBC as the phpcs errors are gone.
I'll let this issue in needs works, and waiting someone with more experience to point which is the best way to proceed with that.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll work on that. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i reviewed this issue, and the code added in #8 work correctly, and attends the proposed solution.
So i'll move this issue to RTBC.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll review it. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i reviewed this issue in two differents environments, one in D9.5.x and the other in D10.
The environment with D10 all the testes implemented work and pass succesfully, but the environment with D9.5.x presents a different result from the tests...
I'll let here some screenshots with the result.
By the way, i'll move this issue to RTBC, but if was needed any change on code the, i'll be happy to try help with that.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i reviewed this issue, and the code implemented work correctly, and attends whats was asked on issue sumary.
So i'll move this issue to RTBC.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll review it. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll review it.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i forget i few changes in the code, so i'm sending another patch and a interdiff.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hello I made some mistakes, sent the patch incomplete.
So now i'm sending another patch with all correctly changes.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Please revise the patch.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

The first patch went wrong, so i'm sending another , i hope that now works property.

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i'll work on it. XD

🇧🇷Brazil WagnerMelo Recife, Pernambuco

Hi, i late a little to finish this issues, but i thinks that i could solve the patch problem.
So i'll send my patch and if it pass in all tests, i'll move this issue to needs review.
I needed rewrite the ExposedFilterViewsAjaxGetTest class, to solve the problem and because i do not has a git repository in my local environment, so i needed create.

Production build 0.71.5 2024