The hero_block.module does not implement hook_help()

Created on 29 July 2019, over 5 years ago
Updated 4 February 2023, almost 2 years ago

The hero_block.module does not implement hook_help().

Please see:
https://www.drupal.org/docs/develop/documenting-your-project/module-docu...

📌 Task
Status

RTBC

Version

1.3

Component

Code

Created by

🇧🇬Bulgaria vuil Bulgaria 🇧🇬 🇪🇺 🌍

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇧🇷Brazil elber Brazil

    I will work on it.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • 🇧🇷Brazil elber Brazil

    Hi I update the hook help, please review.

  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
    +      $output .= '<p>' . t('This module create block with hero image, title and subtitle options.') . '</p>';
    +      $output .= '<p>' . t('You can choose the image style for the image. You can manage multiple hero image blocks for multiple pages.') . '</p>';
    +      $output .= '<p>' . t('You can see more information in module <a href=":project_link">Project page </a>', [
    

    Neither the first nor the last sentence are grammatically correct.
    There is a space before the closing </a> tag and the final period is missing.

  • Status changed to Needs review almost 2 years ago
  • 🇧🇷Brazil elber Brazil

    Hi I update the patch please revise.

  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
    +      $output .= '<p>' . t('You can see more information on the module <a href=":project_link">Project page</a>.', [
    

    It is sufficient to use on the <a href=":project_link">project page</a>. (project is lower case, since it is not at the beginning of a sentence.)

  • Status changed to Needs review almost 2 years ago
  • 🇧🇷Brazil elber Brazil

    Hi I did the change requested on the comment 18, please revise.

  • Assigned to WagnerMelo
  • 🇧🇷Brazil WagnerMelo Recife, Pernambuco

    Hi, i'll review it. XD

  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    I meant that You can see more information on the <a href=":project_link">project page</a>. should be used.

  • Issue was unassigned.
  • Status changed to Needs work almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India sourabhjain

    I have fixed the issue mentioned in #22. Please review.

  • Status changed to RTBC almost 2 years ago
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    The last patch is good to go, as it fixes what reported in the previous comments.

Production build 0.71.5 2024