- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:44pm 1 February 2023 - Status changed to Needs work
almost 2 years ago 10:26pm 1 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ $output .= '<p>' . t('This module create block with hero image, title and subtitle options.') . '</p>'; + $output .= '<p>' . t('You can choose the image style for the image. You can manage multiple hero image blocks for multiple pages.') . '</p>'; + $output .= '<p>' . t('You can see more information in module <a href=":project_link">Project page </a>', [
Neither the first nor the last sentence are grammatically correct.
There is a space before the closing</a>
tag and the final period is missing. - Status changed to Needs review
almost 2 years ago 10:49am 2 February 2023 - Status changed to Needs work
almost 2 years ago 11:56am 3 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ $output .= '<p>' . t('You can see more information on the module <a href=":project_link">Project page</a>.', [
It is sufficient to use
on the <a href=":project_link">project page</a>
. (project is lower case, since it is not at the beginning of a sentence.) - Status changed to Needs review
almost 2 years ago 12:41pm 3 February 2023 - 🇧🇷Brazil elber Brazil
Hi I did the change requested on the comment 18, please revise.
- Assigned to WagnerMelo
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I meant that
You can see more information on the <a href=":project_link">project page</a>.
should be used. - Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 9:42pm 3 February 2023 - Status changed to Needs review
almost 2 years ago 9:10am 4 February 2023 - 🇮🇳India sourabhjain
I have fixed the issue mentioned in #22. Please review.
- Status changed to RTBC
almost 2 years ago 10:05am 4 February 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The last patch is good to go, as it fixes what reported in the previous comments.