- Issue created by @shubham rathore
- @shubham-rathore-0 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:55am 21 February 2023 - ๐ฎ๐ณIndia shubham rathore Jaipur
Create MR for the issue.
Please review.
Thanks. - Status changed to Needs work
almost 2 years ago 10:30am 21 February 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ $output .= '<h3>' . t('About') . '</h3>'; + $output .= '<p>' . t('This module provide customization to Amazon Product widgets') . '</p>'; + $output .= '<p>' . t('This module adding amazon products to your site, with custom theming, caching, automated fetching, storing & renewal of product data.') . '</p>'; + return $output;
In English, each sentence ends with a period. I would also avoid using & instead of and.
- ๐ฎ๐ณIndia rassoni Bangalore
Rashmisoni โ made their first commit to this issueโs fork.
- @rashmisoni opened merge request.
- Status changed to Needs review
almost 2 years ago 6:35am 22 February 2023 - Status changed to Needs work
almost 2 years ago 12:10pm 22 February 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ $output .= '<p>' . t('This module provide customization to Amazon Product widgets') . '</p>'; + $output .= '<p>' . t('This module adding amazon products to your site, with custom theming, caching, automated fetching, storing & renewal of product data.') . '</p>';
The period has been added just to a sentence.
This module provide customization to Amazon Product widgets does not seem correct, as least because it should use for Amazon Product widgets and This module provide customizations.
This module adding amazon products is not correct, since there is no verb after the subject. (The Present Participle is a verbal form used as noun, not as verb.) amazon is not spelled correctly.
& is still used instead of and.
- First commit to issue fork.
- @adminazhar opened merge request.
- Status changed to Needs review
over 1 year ago 11:12am 24 February 2023 - ๐ฎ๐ณIndia adminazhar
Kindly review: merge request !9
Updated the help texts. - Status changed to RTBC
over 1 year ago 3:48pm 24 February 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The last MR contains a better implementation.