str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in modal_page_preprocess_html() (line 159

Issue created by @mrddthi
Issue was unassigned.
Status changed to Needs work about 2 years ago12:50pm 23 February 2023

🇧🇷Brazil renatog Campinas

Thank you so much for the contribution

+++ b/modal_page.module
@@ -155,13 +155,15 @@ function modal_page_preprocess_html(&$variables) {
+    if ($modalVideoLink) {

On this case I'd suggest verify with !empty and I think we can join the Ifs, for example:

if (!empty($modalVideoLink) && (str_contains($modalVideoLink, "watch?v=") || str_contains($modalVideoLink, ".be"))) {
  $modalVideoLink = str_replace(
    ["watch?v=", ".be"],
    ["embed/", "be.com/embed"],
    $modalVideoLink
  );
}

First commit to issue fork.
@adminazhar opened merge request.
Status changed to Needs review almost 2 years ago8:14pm 2 March 2023
Comment almost 2 years ago →
🇮🇳India adminazhar
Comment almost 2 years ago →
🇺🇸United States bygeoffthompson
Patch resolves the `str_contains()` Drupal error seen on my website (same as in issue description). Thanks for this!

Drupal 9.5.2

Modal Page 5.0.1

PHP 8.1.3

RTBC
Status changed to RTBC almost 2 years ago3:28pm 10 March 2023
Comment almost 2 years ago →
🇺🇸United States bygeoffthompson

str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in modal_page_preprocess_html() (line 159

Comments & Activities