🇺🇸United States @bygeoffthompson

bygeoffthompson → created an issue.

Release Candidate → was published this afternoon.

Thanks

bygeoffthompson → created an issue. See original summary → .

Patch attached.

After some time I will move this fix and the project into a RC version.

Thanks

bygeoffthompson → created an issue.

Patch attached makes all administrative labels consistent.

Thanks

bygeoffthompson → created an issue.

Attached patch converts old README text format to `md` and adds installation and configuration details. Ready for review.

bygeoffthompson → created an issue.

Drupal 8 compatibility has been added back to the beta release of the project via beta2.

bygeoffthompson → created an issue.

bygeoffthompson → created an issue.

Encountered this issue today while upgrading from 4.0.1 to recommended/support 5.0.

Here's what I see after upgrading directly to 5.0:

interpathway@system76-pc:~/projects/vt(VT-44)$ ddev drush cr && ddev drush updb
 [success] Cache rebuild complete.
 [error]  The installed version of the /Module Filter/ module is too old to update. 
Update to an intermediate version first (last removed version: 9403, 
installed version: 8000).
 

 Requirements check reports errors. Do you wish to continue? (yes/no) [yes]:
 > yes

 [success] No pending updates.

After encountering this issue I adjusted my version constraint to get 4.1 which allowed the database updates to apply:

interpathway@system76-pc:~/projects/vt(VT-44)$ ddev composer update drupal/module_filter -W
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies                                 
Lock file operations: 0 installs, 1 update, 0 removals
  - Downgrading drupal/module_filter (5.0.0 => 4.1.1)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading drupal/module_filter (4.1.1)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Downgrading drupal/module_filter (5.0.0 => 4.1.1): Extracting archive
Generating optimized autoload files
68 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> DrupalProject\composer\ScriptHandler::createRequiredFiles
No security vulnerability advisories found.
interpathway@system76-pc:~/projects/vt(VT-44)$ ddev drush cr && ddev drush updb
 [success] Cache rebuild complete.
 --------------- ----------- --------------- -------------------------------------------------------------------- 
  Module          Update ID   Type            Description                                                         
 --------------- ----------- --------------- -------------------------------------------------------------------- 
  module_filter   9401        hook_update_n   9401 - Add the filters_enabled.permission default configuration.    
  module_filter   9402        hook_update_n   9402 - Ensure that the 'path' configuration property is a boolean.  
  module_filter   9403        hook_update_n   9403 - Enable jQuery UI Autocomplete module.                        
 --------------- ----------- --------------- -------------------------------------------------------------------- 


 Do you wish to run the specified pending updates? (yes/no) [yes]:
 > yes

>  [notice] Update started: module_filter_update_9401
>  [notice] Update completed: module_filter_update_9401
>  [notice] Update started: module_filter_update_9402
>  [notice] Update completed: module_filter_update_9402
>  [notice] Update started: module_filter_update_9403
>  [notice] Update completed: module_filter_update_9403
 [success] Finished performing updates.

I agree that upgrading to major version 5 from before 4.1 requires two steps which isn't ideal. LMK if anyone needs any other information.

Thanks

I encountered this same error today while upgrading TVI to 2.0.0alpha2 from 1.0.0-rc4. My system is running PHP 7.4.

Patch (#2) resolved my Drush error and restored a working environment. Thanks!

I can confirm the issue fork here resolves the issue. My client uses Bartik as their D9 frontend theme and in prepping the website for D10 I noticed the theme's logo was refusing to load in my browser. The issue fork adjusts the SVG file to avoid the render error and I now see the old Drupal droplet displaying as expected from the contrib Bartik theme.

Patch to fix the label is attached. Thanks

bygeoffthompson → created an issue.

The latest patch here (2986810-17-change-validation-custom-links.patch) is working as expected for me.

I found this issue when trying to added view page paths (/news) and custom HTML file paths (/custom-folder/index.html) to XML Sitemap. Each time I encountered the error "The custom link /example is either invalid or it can not be accessed by anonymous users." despite that fact that the paths I was defining did exist and they could be accessed by anonymous users.

Applying the patch has now allowed me to save these custom paths, fixing the issue encountered. I believe this work is ready to go.

Thanks

Patch added

bygeoffthompson → created an issue.

Patch attached.

Thanks

bygeoffthompson → created an issue.

This capitalization can be extended to the module's README.md file as well. Proper nouns "Node Read Time" and "Twig" should be capitalized there as well. Patch attached, ready for review.

Thanks to everyone here.

I can confirm this issue and the suggested workaround. Changing the SSH URL I received from Gitlab from

git clone git@git.drupalcode.org:project/node_read_time.git .

to

git clone git@git.drupal.org:project/node_read_time.git .

finally allowed me to pull the repo locally. Hopefully the Gitlab issue can be resolved to avoid this.

Thanks

Patch resolves the `str_contains()` Drupal error seen on my website (same as in issue description). Thanks for this!

• Drupal 9.5.2
• Modal Page 5.0.1
• PHP 8.1.3

RTBC