Review implementation, check config and create README.md / hook_help

Created on 8 May 2023, about 1 year ago
Updated 25 September 2023, 9 months ago

Problem/Motivation

@Grevil: Could you please

  1. review the implementation
  2. check if the config is correct
  3. fill the README.md template with the text from the module page
  4. add hook_help from README.md
  5. add install / uninstall test
  6. anything else?

I guess writing a test for the functionality might be too complex currently, while I hope core will fix it.
Perhaps we should simply add a minor task for that? Not sure how complicated that might be and if it can be tested with non-node core entities like taxonomy term or user rendered in a view...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ“Œ Task
Status

Active

Version

0.0

Component

Code

Created by

๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia adminazhar

    admin@azhark.com โ†’ made their first commit to this issueโ€™s fork.

  • Open on Drupal.org โ†’
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    Waiting for branch to pass
  • @adminazharkcom opened merge request.
  • Open on Drupal.org โ†’
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update 9 months ago
    Waiting for branch to pass
  • ๐Ÿ‡ณ๐Ÿ‡ดNorway gisle Norway

    MR opened by Azhar Khan just proposes the following change without any explanation:

    - * Primary module hooks for Views entity_access check module.
    + * Primary MODULE TEST hooks for Views entity_access check module.

    The proposed change seems unrelated to the tasks described in the issue summary, and without any explanation, it does not even make sense to me.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia adminazhar

    I will be pushing changes to the same MR soon, for all the 4 tasks, and for 5th we have to create a new new issue.

  • ๐Ÿ‡ณ๐Ÿ‡ดNorway gisle Norway

    For the future, please delay opening a MR until you have code that makes sense and can be reviewed. You're wasting other people's time by committing nonsense MRs. Also: Explain what you're trying to do.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany Anybody Porta Westfalica

    I bet it was for credits and helpful additions will never happen, but let's see...
    Please remember you're wasting other person's time with such spam activity.

Production build 0.69.0 2024