Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

-    foreach ($files_with_crop as ['crop_settings' => $crop_settings, 'file' => $file]) {
+    foreach ($files_with_crop as [
+      'crop_settings' => $crop_settings,
+      'file' => $file,
+    ]
+      ) {

There are lines that do not need to be truncated to 80 characters. The coding standards describe exactly which are the exceptions. Splitting that code does not make it more readable.

Reviewed the patch to be working as expected.
And can see that the issue summary has added command used to replicate the report.

The patch seemed to be working as expected, moving it to RTBC.

-    foreach ($files_with_crop as ['crop_settings' => $crop_settings, 'file' => $file]) {
+    foreach ($files_with_crop as [
+      'crop_settings' => $crop_settings,
+      'file' => $file,
+    ]) {

-    foreach ($this->getFilesWithCropSettings($entity) as ['crop_settings' => $crop_settings, 'file' => $file]) {
+    foreach ($this->getFilesWithCropSettings($entity) as [
+      'crop_settings' => $crop_settings,
+      'file' => $file,
+    ]) {

See my previous comment: As per coding standards, control structure conditions may be written on a single line, if they are simpler to read and understand.

Control structure conditions may exceed 80 characters, if they are simple to read and understand

The existing code is simpler to understand.

Addressed #18. Updated patch.

Remaining issues:

FILE: /home/yashaswi/contribs/thumbor_effects_crop/src/ThumborCropManager.php
------------------------------------------------------------------------------------------------------------------------FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------ 52 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over
    |       | multiple lines
 62 | ERROR | The array declaration extends to column 109 (the limit is 80). The array content should be split up over
    |       | multiple lines
------------------------------------------------------------------------------------------------------------------------

Command used :
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml thumbor_effects_crop/

silvi.addweb → made their first commit to this issue’s fork.

Resolved all issues that phpcs has reported. Please review since MR was also raised for the same.

apaderno → changed the visibility of the branch 3304209-phpcs-coding-standard to hidden.

All the PHP_CodeSniffer warnings/errors have been fixed.