Patch seems to be working fine, Moving it to RTBC.
The patch seems to be working fine. Moving to RTBC.
The patch is applying cleanly, Moving it to RTBC.
The patch is applying cleanly, moving it to RTBC.
The patch mentioned in MR!3 seems to be working fine. Moving it to RTBC.
Patch mentioned in MR!1 seems to be working fine. Moving to RTBC.
Patch mentioned in merge!1 seems to be working fine.
Patch in merge!4 seems to be working fine. Moving to RTBC.
Patch seems to be applying cleanly, moving to RTBC.
The patch didn't apply. Got following error message:-
error: patch failed: src/Form/DeskNetContentTypeMatching.php:17
error: src/Form/DeskNetContentTypeMatching.php: patch does not apply
Moving back to Needs Work
The patch is applying cleanly, Moving to RTBC.
Patch isn't applying cleanly, Moving to needs work.
The patch provided in comment #9 seems to be working fine, Moving to RTBC.
The patch#20 mentioned in the comment#21 is working and is resolving all the issues.
The patch seemed to be working as expected, moving it to RTBC.
The patch seems to be working fine, Moving it to RTBC.
The patch mentioned in comment#4 resolves all the errors. Moving it to RTBC.
The patch is applying cleanly and issues mentioned are getting resolved by it. Moving it to RTBC.
The patch#2 seems to be working fine, Moving it to RTBC
The patch seems to be working fine, Moving it to RTBC.
MR!3 added in comment#9 seems to be working fine, Moving to RTBC.
MR#1 is applying cleanly, Moving to RTBC.
As mentioned by @nitin_lama above, the patch applies cleanly. Moving it to RTBC.
The patch from MR#5 seems to be working as expected. Moving it to RTBC.
The patch is working as expected, moving to RTBC.
The patch#18 seems to working fine. Moving to RTBC.
The patch does not apply cleanly and not all the issues reported by phpcs are fixed. Attaching a screenshot for reference.
The patch is not able to resolve all the issues reported by phpcs. Attaching a screenshot for reference, Moving it back to needs work.
The patch mentioned in comment #2 applies cleanly. Moving to RTBC.
The patch is applying cleanly and the logo size is getting changed according to the design. Moving to RTBC.
Hello, here are a few of my suggestions for changes in the "fixed" version of the description mentioned in the issue by the reporter.
In the second line,
This subtheme overrides almost every CSS from Drupal and replaces where possible Bootstrap variables in order to generate from roots a new set of CSS files.
"in order to" can be replaced by just "to".
In the fourth line,
For variables override an SCSS file is defined, changing the whole Bootstrap definition according to personalizations set.
"to personalizations" can be replaced by "to the personalizations".
The design issue is fixed by applying Patch #8. Moving to RTBC.
The patch file mentioned in comment#15 is resolving the issue. Moving to RTBC.
The patch is resolving all the above-mentioned issues. Moving to RTBC.
The Patch did not apply. Adding screenshot for reference.
The patch seems to be working as expected, moving to RTBC.
The patch is not solving all the issues. Adding a screenshot for reference.
The patch file 3352113-coding-standard-9.patch didn't apply successfully. Adding a screenshot for reference.
After applying the patch, the icon is visible. Attaching a screenshot of the same. Moving to RTBC.
The patch is working as expected. Moving to RTBC.
The patch is working as expected, Moving to RTBC.
The patch is working as expected and readme.md is getting created after applying the patch.
The patch is working as expected. Moving to RTBC.
Patch #26 seems to be working as expected and can be moved to RTBC.
Hey @urvashi_vora,
The majority of the errors are fixed but found the following error after applying your patch:-
FILE: C:\xampp\htdocs\sandboxD9\modules\contrib\active_role_switch\src\Form\ActiveRoleConfigForm.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\sandboxD9\modules\contrib\active_role_switch\src\Form\ActiveRoleSwitchForm.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\sandboxD9\modules\contrib\active_role_switch\src\Plugin\Block\ActiveRolesSwitchBlock.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------
The patch is working as expected, Moving to RTBC.
The patch is working partially, it's removing some issues but needed to run phpcbf command to make all the warning and errors go away. Moving to need work.
The patch is working fine, Moving it to RTBC.
The patch is working as expected. Moving it to RTBC.
The patch is working as expected. Moving it to RTBC.
After applying the patch, the $(context).find('input[type="file"]').removeOnce('webform-auto-file-upload').each(function () { in js/webform.element.managed_file.js is getting changed to const removedElements = once.remove('webform-auto-file-upload', 'input[type="file"]', context);.
The patch is working as expected, Moving to RTBC.
The patch is working as expected. Moving to RTBC.
After applying the patch, the readme.txt file is getting removed. Moving to RTBC.
The MR !3 is working as expected. Moving to RTBC.
The MR !7 seems to be working as expected. Moving to RTBC.
The MR !6 doesn't replace the readme.txt with readme.md.
MR !1 is working as expected. Moving to RTBC
The patch is working as expected and the dropdown menu is closed by default. Moving to RTBC.
The patch is not working as expected. Moving to "Needs Work".
The patch is not working as expected. Moving to "Needs work".
The patch seems to be working as expected. Moving to RTBC.
The patch is working as expected. Moving to RTBC.
The patch is working as expected. Moving to RTBC.
The patch is working as expected. Moved to RTBC
Patch is working as expected. Moving to RTBC.
Patch is working as expected. Moving to RTBC.
The patch is working as expected. Moving to RTBC.
The Patch works as expected. Marking it to RTBC.