- Issue created by @arti_parmar
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:46am 20 June 2023 - Status changed to RTBC
about 1 year ago 8:34am 20 June 2023 - ๐ฎ๐ณIndia Anmol_Specbee
The patch is applying cleanly and issues mentioned are getting resolved by it. Moving it to RTBC.
- Status changed to Needs work
about 1 year ago 11:50am 22 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+2. Place the module directory in the "modules" folder of your Drupal +installation.
-7. The custom links will be associated with the corresponding user roles and used when rendering the menu. +7. The custom links will be associated with the corresponding user roles +and used when rendering the menu.
+- The "menu_link_by_role_form_alter" function alters the menu link content form +and adds custom link fields for each role.
Since that text is part of a list, the second line must be indented.
+This module is licensed under the [GNU General Public License version 2 +or later](https://www.gnu.org/licenses/gpl-2.0.html).
A link markup cannot be split in two lines.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:59am 23 June 2023 - Status changed to RTBC
about 1 year ago 7:34am 26 June 2023 - ๐ฎ๐ณIndia Anmol_Specbee
Patch seems to be applying cleanly, moving to RTBC.
- Status changed to Needs work
about 1 year ago 7:48am 26 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- // Fetch the stored custom link and set as the default value if it exists. + // Fetch the stored custom link and set as the default + // value if it exists.
Since that comment is changed, and set as needs to be corrected (and set it as).
/** - * + * Form submission handler for menu_link_by_role form. */
A definite article is missing before menu_link_by_role.
- Assigned to nitin_lama
- Status changed to RTBC
about 1 year ago 11:01am 26 June 2023 - ๐ฎ๐ณIndia Harshita mehra
Hello arti_parmar,
Your patch #2 is working fine. - Issue was unassigned.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 7:33pm 26 June 2023 - Status changed to Needs work
about 1 year ago 7:42pm 26 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * + * Implements hook_link_by_role_load_custom_link(). */ -function menu_link_by_role_loadCustomLink($menu_link_plugin_id, $user_role) {
Looking at the module code, I gather that is not a hook implementation; otherwise, it would not be called directly.
- // Assume loadCustomLink is a function that fetches the custom links based on the menu link and role. - $custom_link = menu_link_by_role_loadCustomLink($item['original_link']->getPluginId(), $user_role); + // Assume loadCustomLink is a function that fetches the custom links + // based on the menu link and role. + $custom_link = menu_link_by_role_load_custom_link($item['original_link']->getPluginId(), $user_role);
I would rather remove that comment, simply because it does not make sense. Assume loadCustomLink is a function is referring to a function this very module implements. There is no need to assume that function exists: The module knows it exists.
- Status changed to Needs review
12 months ago 6:18pm 30 June 2023 - ๐ฎ๐ณIndia PrasadDeole
Changes suggested in #19 have been fixed in this patch.
- Status changed to Needs work
12 months ago 7:51pm 30 June 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * + * Function fetches the custom links based on the menu link and role. */ -function menu_link_by_role_loadCustomLink($menu_link_plugin_id, $user_role) { +function menu_link_by_role_load_custom_link($menu_link_plugin_id, $user_role) {
Without Function at the beginning, that description would be fine.
The parameter and the return value descriptions are missing.For the rest, the patch would be good to go.
- First commit to issue fork.
- Assigned to Neha-Verma
- @sonam_sharma opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia kbk1992 Hyderabad
bharath-kondeti โ made their first commit to this issueโs fork.
- Status changed to Needs review
12 months ago 7:50am 3 July 2023 - ๐ฎ๐ณIndia kbk1992 Hyderabad
Updated the MR with fixes commit and addressed #21. Please review