Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Fixed most of the phpcs error reported by Gitlab CI.
Issues remaining:
FILE: ...es/custom/packthub_ebook_integration-3424238/src/Plugin/ProductsAssets.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
77 | ERROR | [x] Space found after square bracket; expected "[CURLOPT_URL" but
| | found "[
| | CURLOPT_URL"
| | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket)
86 | ERROR | [x] Space found before square bracket; expected ",]" but found ",
| | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../modules/custom/packthub_ebook_integration-3424238/src/Plugin/Products.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
158 | ERROR | [x] Space found after square bracket; expected "[CURLOPT_URL"
| | but found "[
| | CURLOPT_URL"
| | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket)
167 | ERROR | [x] Space found before square bracket; expected ",]" but found
| | ",
| | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
271 | ERROR | [ ] Public method name "Products::setProductID" is not in
| | lowerCamel format
| | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ustom/packthub_ebook_integration-3424238/src/Form/EbookContentTypeForm.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
61 | ERROR | [x] Space found after square bracket; expected "['#type'" but
| | found "[
| | '#type'"
| | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket)
71 | ERROR | [x] Space found before square bracket; expected ",]" but found ",
| | ]"
| | (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
72 | ERROR | [x] Space found before square bracket; expected ",]" but found ",
| | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
77 | ERROR | [x] Space found before square bracket; expected ",]" but found ",
| | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
85 | ERROR | [x] Space found after square bracket; expected "['#type'" but
| | found "[
| | '#type'"
| | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket)
88 | ERROR | [x] Space found before square bracket; expected ",]" but found ",
| | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
Neha-Verma → changed the visibility of the branch 3424238-Fix-phpcs to hidden.
Hi @DishaKatariya, After adding the field in content type, go to the structure > content type- article > Manage form display. Then click on the Manage Form settings gear for the relevant Media field using the Media LIbrary widget and enable the "Show edit" option. See the attached screenshot.
No more stylelint errors were reported by Gitlab CI. Will move to RTBC.
I have reviewed the module. After enabling the module, I went to this route: /admin/config/packt/dashboard. Now, it's not showing any errors.
Neha-Verma → made their first commit to this issue’s fork.
I have tried the Media Library Edit module. The edit link is visible with the Olivero theme.
Neha-Verma → made their first commit to this issue’s fork.
Replace README.txt with README.md and update README.md file. Please review MR !1. Thanks
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Please review MR !1.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Sections are covered according to README.md template suggestions.
Please review.
Thanks
Neha-Verma → made their first commit to this issue’s fork.
Update Radme.md file. Please review.
Neha-Verma → made their first commit to this issue’s fork.
Fixed phpstan issues in MR !8, few errors still needs to be fixed.
Line src/EntityHandlers/MicrocontentModerationHandler.php
------ ------------------------------------------------------------------
11 Class
Drupal\microcontent\EntityHandlers\MicrocontentModerationHandler
extends @internal class
Drupal\content_moderation\Entity\Handler\ModerationHandler.
------ ------------------------------------------------------------------
------ -------------------------------------------------------------------------
Line src/Plugin/BackFillQuery/MicroContentHandler.php
------ -------------------------------------------------------------------------
15 Class Drupal\microcontent\Plugin\BackFillQuery\MicroContentHandler
extends unknown class
Drupal\backfill_formatter\Plugin\BackFillQuery\PermissionStatusHandler.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
------ -------------------------------------------------------------------------
Neha-Verma → made their first commit to this issue’s fork.
Hi kenyoOwen
Thank you for your review. I have implemented the changes you mentioned.
Neha-Verma → made their first commit to this issue’s fork.
Updated README.md file in MR !2.
Please review.
Thanks
Neha-Verma → changed the visibility of the branch 01141ddeb5d3f3b01fba4c1b8c565b7478a17dd3 to hidden.
Neha-Verma → made their first commit to this issue’s fork.
Some errors still needs to be fixed.
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/first_assign/eat.module
-----------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------
127 | ERROR | The text '@deprecated - use Eat::loadTid. Load entity tid.' does not match
| | the standard format: @deprecated in %deprecation-version% and is removed from
| | %removal-version%. %extra-info%.
127 | ERROR | Each @deprecated tag must have a @see tag immediately following it
153 | ERROR | The text '@deprecated - use Eat::addTerm(). eat_add_term' does not match the
| | standard format: @deprecated in %deprecation-version% and is removed from
| | %removal-version%. %extra-info%.
153 | ERROR | Each @deprecated tag must have a @see tag immediately following it
193 | WARNING | Code after the RETURN statement on line 192 cannot be executed
-----------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/first_assign/src/Form/EatAdminSettingsForm.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------
33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
71 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency
| | injection instead
142 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------
Neha-Verma → made their first commit to this issue’s fork.
Fixed the issues reported by phpcs. Please review. Thanks.
Neha-Verma → made their first commit to this issue’s fork.
Fixed some PHPCS issues in MR !2, still there are \Drupal calls error that needs to be fixed.
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Service/QRImage.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
420 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldEventWidget.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------
115 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
175 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
190 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldWifiWidget.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
160 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldPhoneWidget.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
142 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldEmailWidget.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
167 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldvCardWidget.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
211 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldSmsWidget.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
148 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldUrlWidget.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
142 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldMeCardWidget.php
--------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
204 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Field/FieldWidget/QRFieldTextWidget.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
141 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/QR/src/Plugin/Block/QREventBlock.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
100 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Fixed some PHPCS issues, still there are some warnings and errors that needs to be fixed.
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Controller/Pages.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
72 | WARNING | Only string literals should be passed to t() where possible
114 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
156 | WARNING | Code after the EXIT statement on line 154 cannot be executed
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/PaymentForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
72 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
92 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
93 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
105 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
121 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
127 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
141 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
145 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/MonobankPaymentsForm.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
38 | ERROR | [x] Whitespace found at end of line
43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
69 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
116 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
160 | WARNING | [ ] Possible useless method overriding detected
187 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
222 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/SettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------
38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
43 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
113 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
117 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Plugin/Basket/Payment/BasketMonobank.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
85 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Monobank.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
160 | ERROR | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
185 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
213 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/monobank.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/README.md
--------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
10 | ERROR | Doc comment is empty
13 | ERROR | Invalid function name, expected h_oo_k_monobank_payment_params_alter but found HOOK_monobank_payment_params_alter
22 | ERROR | Doc comment is empty
25 | ERROR | Invalid function name, expected h_oo_k_monobank_api_alter but found HOOK_monobank_api_alter
Fixed some phpcs issue and generates a MR !1. Please review. Thanks
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Updated issue summary.
Updated issue summary.
Updated issue summary.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Styled the search button and generate a MR !23.
Please review.
Thanks
Update issue summary.
Neha-Verma → changed the visibility of the branch 1.0.x to hidden.
Neha-Verma → changed the visibility of the branch revert-62f15970 to hidden.
Neha-Verma → made their first commit to this issue’s fork.
I have added a css to display active footer menu links. Please review.
I have capitalized the name of the main email_confirmer module and email_confirmer_user submodule.
Neha-Verma → made their first commit to this issue’s fork.
Updated issue summary.
Neha-Verma → made their first commit to this issue’s fork.
I have fixed the issues reported by phpcs. Please review! Thanks.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Neha-Verma → made their first commit to this issue’s fork.
Hi @kavbiswa, I have follow the steps to reproduce the issue but i am unable to reproduce the issue. I have installed the module and created accordian through Editor and accordion title is visible on hover without applying patch. I am using drupal 9.5.0 and my php version is 8.1 . Please let me know if the issue is related to a specific version and please see the attached screenshot.