Fix the issues reported by phpcs

FILE: /web/modules/contrib/monobank/misc/styles.css ------------------------------------------------------------------------------------- FOUND 18 ERRORS AFFECTING 10 LINES ------------------------------------------------------------------------------------- 1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 2 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 3 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 4 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 5 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 6 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 10 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/monobank.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/monobank.install ------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 11 WARNINGS AFFECTING 15 LINES ------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 3 | ERROR | [x] Missing function doc comment 3 | ERROR | [x] Expected 1 space before opening brace; found 0 4 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces 13 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 18 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 23 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 28 | WARNING | [x] A comma should follow the last multiline array item. Found: 100 33 | WARNING | [x] A comma should follow the last multiline array item. Found: 100 38 | WARNING | [x] A comma should follow the last multiline array item. Found: 255 43 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 48 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 53 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 54 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 65 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 66 | ERROR | [x] Whitespace found at end of line ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/monobank.libraries.yml ------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------- 5 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/monobank.module ------------------------------------------------------------------------------------------------------------- FOUND 28 ERRORS AND 3 WARNINGS AFFECTING 18 LINES ------------------------------------------------------------------------------------------------------------- 11 | ERROR | [x] Expected 1 space before opening brace; found 0 12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 18 | ERROR | [x] Expected 1 space before opening brace; found 0 20 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 21 | ERROR | [x] Array indentation error, expected 5 spaces but found 4 22 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 23 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 6 24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 24 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 31 | ERROR | [x] Expected 1 space before opening brace; found 0 32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 32 | ERROR | [x] Concat operator must be surrounded by a single space 32 | WARNING | [ ] Do not concatenate strings to translatable strings, they should be part of the t() argume 33 | ERROR | [x] Expected 1 blank line after function; 0 found 38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 39 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 39 | ERROR | [x] Expected 1 space after IF keyword; 0 found 39 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 41 | WARNING | [x] A comma should follow the last multiline array item. Found: nid 43 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4 43 | ERROR | [x] Expected 1 space after IF keyword; 0 found 43 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 44 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 44 | ERROR | [x] Line indented incorrectly; expected 7 spaces, found 5 45 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4 46 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2 ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/README.md ------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AFFECTING 7 LINES ------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] Missing file doc comment 4 | ERROR | [x] Missing function doc comment 4 | ERROR | [ ] Invalid function name, expected h_oo_k_monobank_payment_params_alter but found HOOK_monoban 4 | ERROR | [x] Expected 1 space before opening brace; found 0 5 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 5 | ERROR | [x] Whitespace found at end of line 11 | ERROR | [x] Expected 1 space after "<"; 0 found 11 | ERROR | [x] Expected 1 space before "?"; 0 found 11 | ERROR | [x] Expected 1 space after "?"; 0 found 12 | ERROR | [x] Missing function doc comment 12 | ERROR | [ ] Invalid function name, expected h_oo_k_monobank_api_alter but found HOOK_monobank_api_alter 12 | ERROR | [x] Expected 1 blank line before function; 0 found 12 | ERROR | [x] Expected 1 space before opening brace; found 0 14 | ERROR | [x] Expected 1 blank line after function; 0 found 15 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Controller/Pages.php ------------------------------------------------------------------------------------------------------------- FOUND 71 ERRORS AND 18 WARNINGS AFFECTING 64 LINES ------------------------------------------------------------------------------------------------------------- 7 | ERROR | [x] Missing class doc comment 9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 10 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 11 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 12 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 13 | ERROR | [x] Expected 2 space(s) before asterisk; 3 found 47 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 47 | ERROR | [x] Missing function doc comment 47 | ERROR | [x] Short array syntax must be used to define arrays 47 | ERROR | [x] Expected 1 space before opening brace; found 0 48 | WARNING | [ ] Only string literals should be passed to t() where possible 49 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2 51 | ERROR | [x] Missing function doc comment 54 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 54 | ERROR | [x] Expected 1 space after SWITCH keyword; 0 found 55 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 55 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 58 | WARNING | [x] A comma should follow the last multiline array item. Found: '-' 60 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 60 | ERROR | [x] Expected 1 space after IF keyword; 0 found 61 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 10 62 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 10 63 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 64 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 64 | ERROR | [x] Expected 1 space after IF keyword; 0 found 64 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 65 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 10 66 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 8 67 | ERROR | [x] Case breaking statements must be followed by a single blank line 69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 77 | WARNING | [x] A comma should follow the last multiline array item. Found: '-' 80 | ERROR | [x] Expected 1 space after IF keyword; 0 found 83 | ERROR | [x] Expected 1 space after IF keyword; 0 found 83 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 90 | ERROR | [x] Expected 1 space after IF keyword; 0 found 90 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 93 | ERROR | [x] Expected 1 space after IF keyword; 0 found 93 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 99 | ERROR | [x] Expected 1 space after IF keyword; 0 found 99 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 101 | ERROR | [x] Expected 1 space after IF keyword; 0 found 102 | ERROR | [x] Expected 1 space after IF keyword; 0 found 106 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 108 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 109 | ERROR | [x] Expected 1 space after IF keyword; 0 found 109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 111 | ERROR | [x] Expected 1 space after IF keyword; 0 found 111 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 113 | WARNING | [x] A comma should follow the last multiline array item. Found: $order 121 | ERROR | [x] Case breaking statements must be followed by a single blank line 122 | WARNING | [ ] Code after the EXIT statement on line 121 cannot be executed 127 | ERROR | [x] Expected 1 space after IF keyword; 0 found 127 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 129 | ERROR | [x] Expected 1 space after IF keyword; 0 found 129 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 132 | ERROR | [x] Expected 1 space after IF keyword; 0 found 132 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 134 | ERROR | [x] Expected 1 space after IF keyword; 0 found 134 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 138 | ERROR | [x] Expected 1 space after IF keyword; 0 found 138 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 150 | WARNING | [x] A comma should follow the last multiline array item. Found: 'success' 154 | WARNING | [x] A comma should follow the last multiline array item. Found: 'monobank/css' 155 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 156 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 158 | ERROR | [x] Expected newline after closing brace 165 | ERROR | [x] Concat operator must be surrounded by a single space 165 | ERROR | [x] Concat operator must be surrounded by a single space 171 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 172 | WARNING | [x] A comma should follow the last multiline array item. Found: 'pay' 173 | ERROR | [x] Expected one space after the comma, 0 found 175 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 178 | WARNING | [x] A comma should follow the last multiline array item. Found: $pid 179 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 180 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 183 | WARNING | [x] A comma should follow the last multiline array item. Found: 'error' 187 | WARNING | [x] A comma should follow the last multiline array item. Found: 'monobank/css' 188 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 189 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 193 | ERROR | [x] Case breaking statement indented incorrectly; expected 8 spaces, found 6 194 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 195 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 195 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3 196 | ERROR | [x] Expected 1 blank line after function; 0 found 197 | ERROR | [x] The closing brace for the class must have an empty line before it ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 87 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Form/monobankPaymentsForm.php --------------------------------------------------------------------------------------------------- FOUND 138 ERRORS AND 26 WARNINGS AFFECTING 109 LINES --------------------------------------------------------------------------------------------------- 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line 8 | ERROR | [x] Missing class doc comment 8 | ERROR | [ ] Class name must begin with a capital letter 8 | ERROR | [x] Expected 1 space before opening brace; found 0 9 | ERROR | [x] Whitespace found at end of line 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 10 | ERROR | [ ] Missing member variable doc comment 10 | ERROR | [ ] Class property $Monobank should use lowerCamel naming without underscores 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 13 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 14 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 15 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 16 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 17 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 18 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 19 | ERROR | [x] Array indentation error, expected 6 spaces but found 8 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 22 | ERROR | [x] You must use "/**" style comments for a function comment 22 | ERROR | [x] Expected 1 space before opening brace; found 0 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Expected 1 blank line after function; 0 found 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 26 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 26 | ERROR | [x] You must use "/**" style comments for a function comment 26 | ERROR | [x] Expected 1 space before opening brace; found 0 27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 28 | ERROR | [x] Expected 1 blank line after function; 0 found 29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 29 | ERROR | [x] Missing function doc comment 29 | ERROR | [x] Expected 1 space before opening brace; found 0 30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 30 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 34 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 41 | ERROR | [x] Expected 1 space before "=>"; 0 found 41 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 45 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 53 | WARNING | [x] A comma should follow the last multiline array item. Found: 'desc' 57 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.created' 61 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.nid' 65 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.sid' 69 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.uid' 73 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.amount' 77 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.status' 81 | WARNING | [x] A comma should follow the last multiline array item. Found: 'l.paytime' 82 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 83 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 85 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 86 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 88 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 89 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 90 | WARNING | [x] A comma should follow the last multiline array item. Found: id 92 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 93 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 96 | WARNING | [x] A comma should follow the last multiline array item. Found: '- - -' 98 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 99 | WARNING | [x] A comma should follow the last multiline array item. Found: '- - -' 101 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 102 | WARNING | [x] A comma should follow the last multiline array item. Found: '- - -' 104 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 105 | ERROR | [x] Concat operator must be surrounded by a single space 105 | ERROR | [x] Concat operator must be surrounded by a single space 105 | ERROR | [x] Concat operator must be surrounded by a single space 105 | WARNING | [x] A comma should follow the last multiline array item. Found: ')' 107 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 108 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 110 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 111 | WARNING | [x] A comma should follow the last multiline array item. Found: '- - -' 113 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 113 | ERROR | [x] Expected 1 space after IF keyword; 0 found 113 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 114 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 115 | WARNING | [x] A comma should follow the last multiline array item. Found: 'pay' 118 | ERROR | [x] There should be no white space after an opening "[" 118 | ERROR | [x] There should be no white space before a closing "]" 118 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 120 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 121 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 122 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 123 | WARNING | [x] A comma should follow the last multiline array item. Found: 'pager' 125 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 126 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 126 | ERROR | [x] Expected 1 blank line after function; 0 found 127 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 127 | WARNING | [ ] Possible useless method overriding detected 127 | ERROR | [x] Missing function doc comment 128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 128 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 5 129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 129 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 1 129 | ERROR | [x] Expected 1 blank line after function; 0 found 130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3 130 | ERROR | [x] Missing function doc comment 130 | ERROR | [x] Expected 1 space before opening brace; found 0 131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 133 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 134 | WARNING | [x] A comma should follow the last multiline array item. Found: $query 136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 137 | ERROR | [x] Closing brace indented incorrectly; expected 3 spaces, found 4 137 | ERROR | [x] Expected 1 blank line after function; 0 found 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 138 | ERROR | [x] Missing function doc comment 138 | ERROR | [x] Expected 1 space before opening brace; found 0 139 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 141 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 141 | ERROR | [x] Expected 1 space after IF keyword; 0 found 141 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 142 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 147 | ERROR | [x] Expected 1 blank line after function; 0 found 148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 148 | ERROR | [x] Missing function doc comment 148 | ERROR | [x] Expected 1 space before opening brace; found 0 149 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 150 | ERROR | [x] Expected 1 space after IF keyword; 0 found 150 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 151 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 154 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 154 | ERROR | [x] Expected 1 blank line after function; 0 found 155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 155 | ERROR | [x] Missing function doc comment 155 | ERROR | [x] Expected 1 space before opening brace; found 0 156 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 159 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 160 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 160 | ERROR | [x] Expected 1 space after IF keyword; 0 found 160 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 161 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16 162 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12 163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 164 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 166 | ERROR | [x] Expected 1 newline at end of file; 0 found 166 | ERROR | [x] The closing brace for the class must have an empty line before it --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 160 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Form/PaymentForm.php ------------------------------------------------------------------------------------------------------------- FOUND 20 ERRORS AFFECTING 16 LINES ------------------------------------------------------------------------------------------------------------- 51 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or clos 71 | ERROR | [x] Expected 1 space after IF keyword; 0 found 73 | ERROR | [x] Expected 1 space after IF keyword; 0 found 80 | ERROR | [x] There should be no white space after an opening "(" 80 | ERROR | [x] There should be no white space before a closing ")" 82 | ERROR | [ ] The array declaration extends to column 146 (the limit is 80). The array content should be 83 | ERROR | [ ] The array declaration extends to column 137 (the limit is 80). The array content should be 114 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or clos 117 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or clos 118 | ERROR | [ ] Variable "Token" starts with a capital letter, but only $lowerCamelCase or $snake_case is 122 | ERROR | [x] Concat operator must be surrounded by a single space 126 | ERROR | [ ] Variable "Token" starts with a capital letter, but only $lowerCamelCase or $snake_case is 130 | ERROR | [x] Expected 1 space after IF keyword; 0 found 134 | ERROR | [x] There should be no white space after an opening "(" 135 | ERROR | [x] There should be no white space after an opening "(" 135 | ERROR | [x] Space found before comma in argument list 138 | ERROR | [x] Expected 1 space after IF keyword; 0 found 138 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 146 | ERROR | [x] There should be no white space after an opening "(" 146 | ERROR | [x] There should be no white space before a closing ")" ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Form/SettingsForm.php ------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 10 WARNINGS AFFECTING 14 LINES ------------------------------------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the cl 42 | WARNING | [x] A comma should follow the last multiline array item. Found: '::ajaxSubmit' 60 | ERROR | [x] Concat operator must be surrounded by a single space 60 | ERROR | [x] Concat operator must be surrounded by a single space 63 | WARNING | [x] A comma should follow the last multiline array item. Found: 'status_messages' 64 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 74 | WARNING | [x] A comma should follow the last multiline array item. Found: TRUE 84 | ERROR | [x] Expected 1 space before "=>"; 0 found 89 | ERROR | [x] Expected 1 space before "=>"; 0 found 91 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 101 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 103 | WARNING | [x] A comma should follow the last multiline array item. Found: ajax 104 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 129 | ERROR | [x] Doc comment short description must start with a capital letter 129 | ERROR | [x] Doc comment short description must end with a full stop ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Monobank.php ------------------------------------------------------------------------------------------------------------- FOUND 43 ERRORS AND 4 WARNINGS AFFECTING 36 LINES ------------------------------------------------------------------------------------------------------------- 10 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the cl 40 | ERROR | [x] You must use "/**" style comments for a function comment 40 | ERROR | [x] Expected 1 space before opening brace; found 0 41 | WARNING | [ ] Only string literals should be passed to t() where possible 47 | ERROR | [x] You must use "/**" style comments for a function comment 50 | ERROR | [x] Expected 1 space after IF keyword; 0 found 53 | ERROR | [x] Expected 1 space after IF keyword; 0 found 56 | ERROR | [x] Expected 1 space after IF keyword; 0 found 59 | ERROR | [x] Expected 1 space after IF keyword; 0 found 64 | ERROR | [x] Expected 1 space after IF keyword; 0 found 68 | ERROR | [x] Expected 1 space after IF keyword; 0 found 68 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 69 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 78 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 81 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 90 | ERROR | [x] You must use "/**" style comments for a function comment 91 | ERROR | [x] Expected 1 space after IF keyword; 0 found 91 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 92 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found 104 | ERROR | [x] You must use "/**" style comments for a function comment 106 | ERROR | [x] Expected 1 space after IF keyword; 0 found 106 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 108 | ERROR | [x] Whitespace found at end of line 111 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 115 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 116 | ERROR | [ ] Variable "Token" starts with a capital letter, but only $lowerCamelCase or $snake_case i 120 | ERROR | [x] Concat operator must be surrounded by a single space 120 | ERROR | [x] Concat operator must be surrounded by a single space 123 | ERROR | [ ] Variable "Token" starts with a capital letter, but only $lowerCamelCase or $snake_case i 127 | ERROR | [x] Expected 1 space after IF keyword; 0 found 130 | ERROR | [x] Expected newline after closing brace 130 | ERROR | [x] There should be no white space after an opening "(" 131 | ERROR | [x] There should be no white space after an opening "(" 131 | ERROR | [x] Space found before comma in argument list 134 | ERROR | [x] Expected 1 space after IF keyword; 0 found 134 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 143 | ERROR | [x] Expected 1 space after IF keyword; 0 found 143 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 146 | ERROR | [x] Expected 1 space after IF keyword; 0 found 147 | ERROR | [x] Expected 1 space after IF keyword; 0 found 151 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 153 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or cl 154 | ERROR | [x] Expected 1 space after IF keyword; 0 found 154 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 156 | ERROR | [x] Expected 1 space after IF keyword; 0 found 156 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 158 | WARNING | [x] A comma should follow the last multiline array item. Found: $order ------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 43 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------- FILE: /web/modules/contrib/monobank/src/Plugin/Basket/Payment/BasketMonobank.php ----------------------------------------------------------------------------------------------------------- FOUND 34 ERRORS AND 11 WARNINGS AFFECTING 32 LINES ----------------------------------------------------------------------------------------------------------- 6 | WARNING | [x] Unused use statement 10 | ERROR | [ ] Missing short description in doc comment 41 | ERROR | [x] Doc comment short description must end with a full stop 48 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 52 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 55 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 56 | ERROR | [x] Concat operator must be surrounded by a single space 56 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 57 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 65 | ERROR | [x] Expected 1 space before opening brace; found 0 67 | ERROR | [x] Expected 1 space after IF keyword; 0 found 67 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 81 | ERROR | [x] Expected 1 space after IF keyword; 0 found 81 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 83 | ERROR | [x] Expected 1 space after IF keyword; 0 found 83 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 84 | WARNING | [ ] Only string literals should be passed to t() where possible 91 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 91 | WARNING | [x] A comma should follow the last multiline array item. Found: $value 92 | WARNING | [x] A comma should follow the last multiline array item. Found: ] 99 | ERROR | [x] Doc comment short description must end with a full stop 102 | ERROR | [x] Expected 1 space after IF keyword; 0 found 102 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 106 | WARNING | [x] A comma should follow the last multiline array item. Found: pay_price 108 | ERROR | [x] Expected 1 space after IF keyword; 0 found 108 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 111 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 111 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL 117 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 117 | WARNING | [x] A comma should follow the last multiline array item. Found: NULL 122 | ERROR | [x] Doc comment short description must end with a full stop 126 | ERROR | [x] Expected 1 space after IF keyword; 0 found 126 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 128 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed 129 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE 135 | ERROR | [x] Doc comment short description must end with a full stop 142 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 142 | ERROR | [x] Doc comment short description must end with a full stop 149 | ERROR | [x] Doc comment short description must end with a full stop 153 | ERROR | [x] Expected 1 space after IF keyword; 0 found 153 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 154 | ERROR | [x] Expected 1 space after IF keyword; 0 found 154 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 160 | ERROR | [x] Expected 1 blank line after function; 0 found 161 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 42 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Comments & Activities

Issue created by @aman_lnwebworks
Comment 12 months ago →
🇮🇳India Indranil Roy kolkata
Hey @aman_lnwebworks, i am working on this issue.
Assigned to Indranil Roy
Comment 12 months ago →
🇮🇳India Indranil Roy kolkata
First commit to issue fork.
Assigned to Neha-Verma
Comment 11 months ago →
🇮🇳India Neha-Verma
Merge request !1Fix phpcs issue → (Open) created by Neha-Verma
Issue was unassigned.
Status changed to Needs review 11 months ago11:58am 19 December 2023
Comment 11 months ago →
🇮🇳India Neha-Verma
Fixed some phpcs issue and generates a MR !1. Please review. Thanks

Comment 11 months ago →

🇮🇳India Neha-Verma

Fixed some PHPCS issues, still there are some warnings and errors that needs to be fixed.

FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Controller/Pages.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  72 | WARNING | Only string literals should be passed to t() where possible
 114 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 156 | WARNING | Code after the EXIT statement on line 154 cannot be executed
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/PaymentForm.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  72 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
  92 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  93 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 105 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 121 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 127 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 141 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 145 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/MonobankPaymentsForm.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
  38 | ERROR   | [x] Whitespace found at end of line
  43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  69 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 116 | ERROR   | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 160 | WARNING | [ ] Possible useless method overriding detected
 187 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 222 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Form/SettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  43 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 113 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 117 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 117 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Plugin/Basket/Payment/BasketMonobank.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 48 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 85 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/src/Monobank.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
 160 | ERROR   | unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the allowed_classes option.
 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 185 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 198 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 213 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/monobank.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /opt/lampp/htdocs/camp/web/modules/contrib/monobank/README.md
--------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------
  3 | ERROR | Missing short description in doc comment
 10 | ERROR | Doc comment is empty
 13 | ERROR | Invalid function name, expected h_oo_k_monobank_payment_params_alter but found HOOK_monobank_payment_params_alter
 22 | ERROR | Doc comment is empty
 25 | ERROR | Invalid function name, expected h_oo_k_monobank_api_alter but found HOOK_monobank_api_alter

Status changed to Needs work 3 months ago12:32am 15 August 2024

Comment 3 months ago →

a.aaronjake

Hi @Neha-Verma,

The change you made on MR!1 was applied not-so successfully, and as expected multiple errors were reported. Please see below:

➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig monobank

FILE: ...nterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/monobank/README.md
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  3 | ERROR | Missing short description in doc comment
 10 | ERROR | Doc comment is empty
 13 | ERROR | Invalid function name, expected
    |       | h_oo_k_monobank_payment_params_alter but found
    |       | HOOK_monobank_payment_params_alter
 22 | ERROR | Doc comment is empty
 25 | ERROR | Invalid function name, expected h_oo_k_monobank_api_alter but
    |       | found HOOK_monobank_api_alter
--------------------------------------------------------------------------------


FILE: ...-orgissue-v9/web/modules/contrib/monobank/templates/monobank-pay.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 2 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...-v9/web/modules/contrib/monobank/templates/monobank-success-page.html.twig
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../drupal-orgissue-v9/web/modules/contrib/monobank/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  38 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  43 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  98 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
 113 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 117 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 117 | WARNING | t() calls should be avoided in classes, use
     |         | \Drupal\Core\StringTranslation\StringTranslationTrait and
     |         | $this->t() instead
--------------------------------------------------------------------------------


FILE: ...e/drupal-orgissue-v9/web/modules/contrib/monobank/src/Form/PaymentForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 9 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
  36 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  37 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  67 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  72 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
  92 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
  93 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 105 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 121 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 127 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 141 | WARNING | \Drupal calls should be avoided in classes, use dependency
     |         | injection instead
 145 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------


FILE: ...Demo-site/drupal-orgissue-v9/web/modules/contrib/monobank/src/Monobank.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 5 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
  68 | ERROR   | [x] The first parameter of a multi-line function declaration
     |         |     must be on the line after the opening bracket
  69 | ERROR   | [x] Multi-line function declaration not indented correctly;
     |         |     expected 4 spaces but found 6
  70 | ERROR   | [x] Multi-line function declaration not indented correctly;
     |         |     expected 4 spaces but found 6
  71 | ERROR   | [x] Multi-line function declaration not indented correctly;
     |         |     expected 4 spaces but found 6
  72 | ERROR   | [x] Multi-line function declaration not indented correctly;
     |         |     expected 4 spaces but found 6
  72 | ERROR   | [x] Multi-line function declarations must have a trailing
     |         |     comma after the last parameter
  72 | ERROR   | [x] The closing parenthesis of a multi-line function
     |         |     declaration must be on a new line
 160 | ERROR   | [ ] unserialize() is insecure unless allowed classes are
     |         |     limited. Use a safe format like JSON or use the
     |         |     allowed_classes option.
 172 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 185 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 198 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 198 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
 213 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
     |         |     injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../web/modules/contrib/monobank/src/Plugin/Basket/Payment/BasketMonobank.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  6 | WARNING | [x] Unused use statement
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first
    |         |     wrong one is
    |         |     Drupal\basket\Plugins\Payment\Annotation\BasketPayment.
 11 | ERROR   | [ ] Missing short description in doc comment
 50 | WARNING | [ ] t() calls should be avoided in classes, use
    |         |     \Drupal\Core\StringTranslation\StringTranslationTrait and
    |         |     $this->t() instead
 87 | WARNING | [ ] Only string literals should be passed to t() where possible
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...e/drupal-orgissue-v9/web/modules/contrib/monobank/src/Controller/Pages.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  72 | WARNING | Only string literals should be passed to t() where possible
 114 | ERROR   | unserialize() is insecure unless allowed classes are limited.
     |         | Use a safe format like JSON or use the allowed_classes option.
 156 | WARNING | Code after the EXIT statement on line 154 cannot be executed
--------------------------------------------------------------------------------

Time: 501ms; Memory: 12MB

Kindly check

Thanks,
Jake

Comment 2 months ago →
System Message

helena zajika → committed d6cee80c on 1.0.x
Issue #3406123: Fix the issues reported by phpcs
Status changed to Fixed 2 months ago9:23am 4 September 2024
Comment 2 months ago →
🇺🇦Ukraine Helena Zajika
Changes have been made to the dev branch
Comment about 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Merge Requests

!1Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Merge Requests

!1Fix the issues reported by phpcsOpen

Comments & Activities

!1Fix the issues reported by phpcs
Open