- Issue created by @shweta__sharma
- Assigned to Esha_Kundu
- First commit to issue fork.
- Assigned to Neha-Verma
- Merge request !9Issue #3418802: There is no space below action button → (Closed) created by Esha_Kundu
- Issue was unassigned.
- Status changed to Needs review
12 months ago 2:09pm 3 February 2024 I have created an MR to fix the issue.
merge request !9
Added 1 commit- ae7d39e3 - Issue #3418802: There is no space below action button
Please review the added ss for reference.
- Status changed to Needs work
12 months ago 8:41am 5 February 2024 @Esha_Kundu, this has to be fixed for the condition when there is no content and the "filter" action button is visible. Added screenshots for reference
- Status changed to Needs review
12 months ago 11:25am 5 February 2024 The filters action button had a design break in the mobile view, I have also fixed that and included in the MR.
I added ss for reference.Tested MR 9 and it's fixed the issue now the space is added in both conditions. Moving to RTBC.
After Patch
- Status changed to Needs work
8 months ago 8:48am 29 May 2024 Hello there,
I've reproduced the issue on the specified version and tested the patch also. The MR solves the spacing issue of the action buttons.
But on the latest version the issue doesn't persist, I think it has been already addressed! Though on the latest version I've found some other style break issues related to the action button and filters. I think it'll be great if we address those in this!
I'm attaching MR testing screenshots as well as the screenshots for the newly found style break issues as well as some accessibility issues are there!
Hence I'm changing the version component on the metadata!- Assigned to Esha_Kundu
- Merge request !12Issue #3418802: Accessibility issue in action button and design breaks. → (Merged) created by Esha_Kundu
Hello,
I have fixed the accessibility issue for the action buttons globally, the design break as mentioned in #13 in devices.
I found design issue noted below:- In the bulk operations button in responsive devices the text App appeared along with the tick sign
- In the secondary tabs the border on the left side was not being visible for first tab
- In the recent logs page the Filter button size look too large
- In tab devices the operations buttons in content listing page looked larger
- In the extend page there was no space between the filter and the core
so I have fixed all the above issues.
I have attached the before and after for the issues.
Please have a look.- Issue was unassigned.
- Status changed to Needs review
7 months ago 12:19pm 14 June 2024 - Status changed to RTBC
7 months ago 7:32am 27 June 2024 - 🇯🇴Jordan Ahmad Alyasaki
ahmad-alyasaki → made their first commit to this issue’s fork.
-
ahmad-alyasaki →
committed 0916c569 on 2.x authored by
esha_kundu →
Issue #3418802: There is no space below action button
-
ahmad-alyasaki →
committed 0916c569 on 2.x authored by
esha_kundu →
- Status changed to Fixed
4 months ago 12:48pm 19 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.