Edit link not visible with Olivero

Created on 1 March 2024, 9 months ago
Updated 5 March 2024, 9 months ago

Problem/Motivation

Edit link is not visible with Olivero theme
HTML markup is there but the CSS "position: relative;" makes it invisible.

🐛 Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

🇭🇺Hungary Sweetchuck Budapest

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Sweetchuck
  • First commit to issue fork.
  • Assigned to Neha-Verma
  • Issue was unassigned.
  • 🇮🇳India Neha-Verma

    I have tried the Media Library Edit module. The edit link is visible with the Olivero theme.

  • Status changed to Needs review 9 months ago
  • 🇮🇳India dishakatariya

    Hi, @Neha-Verma I have tried to reproduce this issue but not able to do this. I can't see the edit link even after applying the patch the results were same. Can you please provide the detail steps to reproduce this issue.
    The steps i have followed:
    1. Install the Drupal 10.x version
    2. Install Media library modules.
    3. Now, go to the structure > add content type- article and add field.
    4. then, go to the content > add content > article > Add Media and check if the edit link is visible

    Thanks.!

  • 🇮🇳India Neha-Verma

    Hi @DishaKatariya, After adding the field in content type, go to the structure > content type- article > Manage form display. Then click on the Manage Form settings gear for the relevant Media field using the Media LIbrary widget and enable the "Show edit" option. See the attached screenshot.

  • 🇮🇳India dishakatariya

    Hi, I have verified and tested this issue. It looks good to me.
    Testing Steps:
    1. Install the Drupal 10.x version
    2. Set Olivero theme as default
    3. Install Media library modules.
    4. Now, go to the structure > add content type- article and Manage fields - add field- Field type as Media
    5. Then Go to Manage Form Display- admin/structure/types/manage/article/form-display
    6. Click to the Settings icon on the created Media Field and enable the show edit button.
    7. then, go to the content- add content > article > Add Media and check if the edit link is visible

    Testing Results:
    The Edit link is Visible on the Add Media with Olivero theme.
    Adding the Screenshots below:
    Hence, Can be move to RTBC.
    RTBC+1
    Thanks!

  • Status changed to RTBC 9 months ago
  • Status changed to Postponed: needs info 9 months ago
  • I'm a little confused by what's happening here. There don't seem to be any code changes so I'm not sure what is RTBC.

  • Assigned to Sweetchuck
  • 🇭🇺Hungary Sweetchuck Budapest
  • 🇭🇺Hungary Sweetchuck Budapest

    I think screenshot Create-Article-DrupalPod (1).png from comment #8 was made with Claro.
    That looks good.
    There is an "X" button to remove and a "pencil" button to edit the media in the top-right corner of the image.
    Everything in place and working.

    ---

    I think screenshot Create-Article-DrupalPod.png from comment #6 was made with Olivero,
    And it clearly shows that what the problem is.
    The "remove" button is not an overlay icon in the top-right corner of the image. Which is not a problem itself.
    The problem is that the edit button - "pencil" button - still wants to be an overlay icon in the top-right corner of the image according to the applied CSS, but the HTML markup of Claro is different than the HTML markup of Olivero.
    That is why the "edit" button is not visible.

    This CSS can't be used with Olivero.
    https://git.drupalcode.org/project/media_library_edit/-/blob/80e9857aa7b...

    Current CSS only works with Claro and Claro based themes.

    I think a contrib module should work with default core themes without any problem.

    ---

    A tester has to pay attention to this settings as well:

    Turn off: "Use the administration theme when editing or creating content"
    On the /admin/appearance page.

  • Issue was unassigned.
  • Status changed to Needs work 9 months ago
  • 🇭🇺Hungary Sweetchuck Budapest
  • 🇭🇺Hungary Sweetchuck Budapest

    @DishaKatariya In comment #4 you mentioned a patch:

    ... I can't see the edit link even after applying the patch the results were same. ...

    May I ask what kind of patch did you apply?

Production build 0.71.5 2024