@ahebrank

Thanks, Troy!

ahebrank → made their first commit to this issue’s fork.

That MR was targeted at 8.x-2.x so that's where it landed. So we'll need another one for 3.x, if it's intended to apply there.

I've brought the MR up to date. Looks like there are some code sniffer issues in the new class if anyone wants to fix, but not a dealbreaker (for me, anyway).

FILE: /builds/project/eva/web/modules/custom/eva/src/LazyBuilders.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
 31 | WARNING | \Drupal calls should be avoided in classes, use dependency
    |         | injection instead
    |         | (DrupalPractice.Objects.GlobalDrupal.GlobalDrupal)
 42 | WARNING | \Drupal calls should be avoided in classes, use dependency
    |         | injection instead
    |         | (DrupalPractice.Objects.GlobalDrupal.GlobalDrupal)
 93 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)
 95 | WARNING | Line exceeds 80 characters; contains 81 characters
    |         | (Drupal.Files.LineLength.TooLong)

I'm looking for testing from the community so if you're able to patch this on your site and confirm functionality, please set RTBC so we can merge!

@sirclickalot @s-jack I need an RTBC on this issue, ideally with testing from more than one person. If the current patch works for you and is bug-free, please update the issue status and I will merge so we can save @aaronbauman from rebasing again.

I guess core has caught up? Closing as out of date, please reopen or create a new more specific issue if there are still LB compatibility problems.

Sorry, current dev branch is 3.1.x now. It'll need to be rebased.

I've verified that `config_ignore` settings are respected by `config_patch` without the module doing anything, so closing as obsolete. Seeing as `config_filter` is marked deprecated, I've removed references to that module on 3.0.x (thought about an update hook to remove the `respect_filter` setting but don't think it matters that much).

> This operations dropdown might have other helpful stuff in it as well, like the core-provided diff popup on the "Synchronize" tab.

Added dropdown with "View diff" and "Revert" in https://git.drupalcode.org/project/config_patch/-/commit/e1babfa38ef827e...

> maybe add a link over by the "Config Patch Settings" to invalidate the config_patch cache tag

Added in https://git.drupalcode.org/project/config_patch/-/commit/56a88f062e6675d...

Now available at https://www.drupal.org/project/config_patch_github_api → !

Yeah, that's unfortunate, this should not have been RTBC. The service is part of config_filter, so I'll revert this change and then we can figure out how to move forward to best support config_ignore.

ahebrank → made their first commit to this issue’s fork.

ahebrank → made their first commit to this issue’s fork.

ahebrank → made their first commit to this issue’s fork.

Thanks, Troy.

ahebrank → made their first commit to this issue’s fork.

ahebrank → made their first commit to this issue’s fork.

ahebrank → made their first commit to this issue’s fork.

ahebrank → created an issue.

Makes sense, thanks!

ahebrank → made their first commit to this issue’s fork.

jan kellermann → credited ahebrank → .

Sure, happy to add you as a maintainer if I can remember how. I'll try to get a D11 release out shortly.

Merged, thanks for the MR and review.

LGTM, looking for a RBTC from someone to merge.

ahebrank → made their first commit to this issue’s fork.

Thanks!

Thanks @sorlov. Looks good to me, but since I don't have a way to test can you attach the "after" screenshot from config:inspect?

Just waiting on an RTBC. Also it looks like MR needs to be retargeted to 3.1.x

Well, I've tried. @Debdeep.Mukhopadhyay is credited in the commit message, but having the checkbox selected when I make the comment doesn't seem to do anything. Thanks for the image!

Huh, I always thought credit was by the commit message.

ahebrank → made their first commit to this issue’s fork.

Huh, yeah, I guess it's been a year and a half. I've tagged 3.1.0, I guess 3.2.0 will be coming shortly for D11

Appears to be fixed in dev branch: https://git.drupalcode.org/project/config_patch/-/blob/3.0.x/src/PluginM...

I think this was a duplicate report, maybe?

+1. I've patched for now with

diff --git a/vapn.module b/vapn.module
index ffcc861..35bb5ce 100644
--- a/vapn.module
+++ b/vapn.module
@@ -70,6 +70,12 @@ function vapn_node_access(NodeInterface $entity, $operation, AccountInterface $a
       $rid = $item->target_id;
       $allowed_roles[$rid] = $rid;
     }
+
+    // Nothing marked on a node? Allow by default.
+    if (empty($allowed_roles)) {
+      return AccessResult::neutral();
+    }
+
     $access_result = array_intersect($account->getRoles(), $allowed_roles)
       ? AccessResult::allowed()
       : AccessResult::forbidden();

but that if could be controlled by a settings flag.

Thanks, both, for the patch and review. I've merged to dev.

Huh, thanks -- I guess this always been a bug. Let's just use sprintf here since it's simpler and there's no need for this to be a renderable object.

Just did 3.0.2 for this since it's been a while.

ahebrank → made their first commit to this issue’s fork.

Committed and pushed to 2.0.x and 2.0.0

I'm a little confused by what's happening here. There don't seem to be any code changes so I'm not sure what is RTBC.

Thanks! Guess this hasn't had a ton of D10 use yet :)

Committed. Attaching the slightly different patch used on the dev branch.

How about this as a compromise? I think it's probably a more accessible solution anyway.

Should be fixed on 2.1 with https://git.drupalcode.org/project/soft_length_limit/-/blob/2.1.x/soft_l...

Yeah, I agree, thanks for pointing this out. I've tweaked the wording in 2.1.1 with a bunch of other little things.

This sounds a lot like https://www.drupal.org/project/media_library_edit/issues/3201011 🐛 Check access for each media entity Fixed -- I'll tag a new release on dev which should bring it up to date.

Not sure why this came out with the D10 updates. Seems fine to me -- do you have someone you can get to test and mark RTBC?

Committed. Thanks again!

Thanks for this @evac9. When I was looking at it I found some other little cleanups -- can you check that this patch works?

Can you please update MR to apply to 3.0.x?

Thanks for the patch. Is this positioning issue specific to Claro? Can someone share screenshots for before/after in Seven and maybe Gin so we can ensure it works across these admin themes?

Huh. It's frustrating that the commit is the same as #6 which sat for 18 months. But I'm glad it got fixed.

Just made release 2.1.0 for D10 and new dev branch 2.1.x, up to date with 2.0.x

I made branch 3.0.x from patch #5. If it's all working, please let me know and I'll tag as 3.0.0

Thanks, committed and tagged 4.0.1

Makes sense to me, guess the invalidator never expected to see multiple invalidations per tag per request.

ahebrank → created an issue.