- Merge request !11Issue #3246687: Prevents other submit handlers from working, such as media entity file replace → (Merged) created by prudloff
- 🇨🇦Canada teknocat
Yes I agree there is no reason for this module to wipe out all the submit handlers just to be able to do it's thing. @prudloff's solution looks great. I don't think I would have thought of that.
@prudloff can you change the name of _media_library_edit_media_edit_save() since it no longer saves?
Looking for an RTBC and then can merge.
- Status changed to Needs work
over 1 year ago 6:46pm 31 January 2024 - Assigned to dhruv.mittal
- 🇮🇳India divyansh.gupta Jaipur
Since there is a unresolved thread moving it to Needs Work, Please resolve the thread.
- 🇮🇳India divyansh.gupta Jaipur
I have reviewed and tested the latest patch in !11.
✅ The #submit callback is no longer being unset, allowing other submit handlers (such as from Media Entity File Replace) to function correctly.
✅ The function name update issue has been resolved, and $form['actions']['submit']['#ajax']['callback'] now correctly references the updated function.
✅ The form submission process works as expected, and the modal closes properly after submission.Everything looks good, and I don't see any regressions or issues. Moving this to RTBC.
- 🇨🇦Canada hargurpreet Kitchener
I also encountered an issue while replacing a file in the modal, but this patch resolved it.
-
ahebrank →
committed 98479951 on 8.x-2.x authored by
prudloff →
Issue #3246687 by dhruv.mittal, prudloff: Don't unset the #submit...
-
ahebrank →
committed 98479951 on 8.x-2.x authored by
prudloff →
That MR was targeted at 8.x-2.x so that's where it landed. So we'll need another one for 3.x, if it's intended to apply there.
- Issue was unassigned.
- First commit to issue fork.
- 🇩🇪Germany marcoliver Neuss, NRW, Germany
marcoliver → changed the visibility of the branch 3.0.x to hidden.
- 🇩🇪Germany marcoliver Neuss, NRW, Germany
Hey everybody, I ported the changes from 8.x-2.x to the 3.0.x branch and opened a new MR.
- 🇺🇸United States mlncn Minneapolis, MN, USA
marcoliver's merge requent !26 works beautifully for 3.0.x; good time to get it in now before further development on that branch!
-
ahebrank →
committed 3f944f08 on 3.0.x authored by
marcoliver →
Issue #3246687 by prudloff, dhruv.mittal, marcoliver: Don't unset the #...
-
ahebrank →
committed 3f944f08 on 3.0.x authored by
marcoliver →
- 🇺🇸United States mlncn Minneapolis, MN, USA
(Oh and respectfully upgraded to major because the way it manifests with Media Entity File Replace ✨ Incompatibility with media_library_edit Active results in the file not being replaced and it is extremely difficult to figure out exactly what is happening… if you even notice that people are being served the old file because the new one was never even uploaded (silently failing, no error or warning, seeming successful)!
- 🇺🇸United States mlncn Minneapolis, MN, USA
That has to be a record in speed of commit. Thank you so much! (And everybody who worked on this fix!)