Config Filter is no longer required by Config Ignore

Created on 2 January 2025, 3 months ago

Problem/Motivation

The respect filter options do not appear anymore since newer versions of config_ignore do not rely on Config Filter as a requirement.

Steps to reproduce

Proposed resolution

Change 'config_filter' references to 'config_ignore'. This should work for older existing sites and newer ones where config_filter won't be present.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇺🇸United States kevinquillen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kevinquillen
  • Hey,

    I have changed the 'config_filter' references to 'config_ignore'. I think this will work for both - older sites containing config_filter and the new ones where config_filter is not present.

    Please have a look.
    Thank you !

  • 🇮🇳India shivam_tiwari

    I checked MR 7, it looks fine to me. Moving it to RTBC.

  • Pipeline finished with Skipped
    about 2 months ago
    #426700
  • First commit to issue fork.
  • 🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬

    I started getting this error

    Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "config_ignore.storage_factory". in Drupal\Component\DependencyInjection\Container->get() (line 159 of /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php).

    with backtrace

    #0 /var/www/html/web/core/lib/Drupal.php(197): Drupal\Component\DependencyInjection\Container->get('config_ignore.s...')
    #1 /var/www/html/web/modules/contrib/config_patch/src/ConfigCompare.php(248): Drupal::service('config_ignore.s...')
    #2 /var/www/html/web/modules/contrib/config_patch/src/Controller/ConfigPatchToolbar.php(66): Drupal\config_patch\ConfigCompare->getChangelist()
    #3 [internal function]: Drupal\config_patch\Controller\ConfigPatchToolbar->toolbarAjax()
    #4 /var/www/html/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)

    Where is that service that you are using with the recent changes from this issue config_ignore.storage_factory coming from?

  • 🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬
  • Yeah, that's unfortunate, this should not have been RTBC. The service is part of config_filter, so I'll revert this change and then we can figure out how to move forward to best support config_ignore.

    • 873d5da0 committed on 3.0.x
      Revert Issue #3497034: Changed config filter references.
      
  • I've verified that `config_ignore` settings are respected by `config_patch` without the module doing anything, so closing as obsolete. Seeing as `config_filter` is marked deprecated, I've removed references to that module on 3.0.x (thought about an update hook to remove the `respect_filter` setting but don't think it matters that much).

Production build 0.71.5 2024