EVA views pollute the whole page with the view's cache contexts - should use a lazy builder

Rebased.

I can't seem to get this patch to apply on 3.0.x-dev or 3.0.0

https://git.drupalcode.org/project/eva/-/merge_requests/1.diff

It gets rejected on the module file.

Cheers Dan

I've rebased the branch - the diff will apply now.

It's still not applying for me on 3.0.0 or 3.0-dev.x

It seems that it rejects

@@ -50,63 +50,55 @@ function eva_entity_extra_field_info()

In the module file this line is actually line 51.

Ah, the MR was against the wrong branch.

Sorry my fault, I realised this was because I was using another patch that is modifying the module file
https://www.drupal.org/project/eva/issues/3083993 ✨ Hide output if empty option Fixed

hi @joachim
I've updated MR to make it work with 3.1 version.
could you pls change target branch in MR to 3.1.x ?
tnx

I've rebased the branch on 3.1.x, rather than have a merge commit. In general, rebasing produces a cleaner history for a feature branch.

Though now I revisit the code, I'm not sure about this bit:

              '#cache' => [
                'contexts' => $view_cache_metadata->getCacheContexts(),
                'max-age' => $view_cache_metadata->getCacheMaxAge(),
                'tags' => $view_cache_metadata->getCacheTags(),
              ],

Surely that's polluting the outer render array -- it should be inside instead?

Applying the patch from the latest MR gives me the following error. (Drupal 10.3)

Error: Class "Drupal\eva\View" not found in Drupal\eva\LazyBuilders->displayView() (line 90 of modules/contrib/eva/src/LazyBuilders.php).

Looks like a missing class import.

matej.lehotsky → made their first commit to this issue’s fork.