Set 'drupalAutoButtons' => FALSE for modal to stop all buttons being moved into modal actions

Whoops, I just messed up the MR by rebasing it with the 3.x version branch. But I rebuild the MR branch and now everything should be fine again. I will open up a new issue for for the 3.x version instead.

hctom → changed the visibility of the branch 3.0.x to hidden.

See the new MR for the 3.x version for review as well

This change definitely makes sense to me to make the functionality more robust! +1

Automatically closed - issue fixed for 2 weeks with no activity.

While the fix may have targeted the issue with "Add another item", but it introduced another issue in the gin_lb.
The "Save" button is not displayed at all.
See the screenshots before and after the fix:
Before

After

We must reopen the issue because the given solution is opinionated and doesn't consider themes.

@lexbritvin I remember that issue, we also had it and I believe this one fixed it: 🐛 Form buttons missing in modal/off-canvas Needs review
Do you have the latest gin version?

I hope this was the right issue... I can at least confirm we don't have the issue any more, and we had it and have no other patch in place.

Thank you for pointing out. That may be related.
Yes, I have Drupal 10.3.2, gin 3.0.0-rc13, gin_lb 1.0.0-rc8
But after further investigation, it doesn't seem to be correct.

I disabled the fix and it works well for me with multiple value field.
I tested the "Add another item" without gin_lb on content entity with Media library.

Meaning gin_lb is not making any specific magic to the buttons to make them work.

Are there specific steps to reproduce? Do I reproduce it correctly?

The auto buttons are not applied because the button is wrapped into `field-action` class, not `form-actions` like "Save" which are taken by dialog.
Regarding UI/UX, we have these buttons in the bottom in Media Library modal, in Media Add modal.
But somehow with the fix in Media Edit modal we have a different UI and different button placement.

For me the fix is not correct.
Can you please disable and quick check on your environments if I miss steps?

Because of my tests, I will attach a revert patch to use in my projects.

@lexbritvin perhaps you could open a follow-up issue containing a test that proves the issue?
If I got you right, the issue doesn't only appear with gin / gin_lb? (That would maybe mean it should be fixed over there)

Hello @anybody.
Probably yes, it's better to create a new issue then.

That's why I'm asking you if I follow the steps correctly.
Because with the latest versions of Drupal and modules, I was not able to reproduce the issue at all.
Maybe I miss the steps to reproduce.