Form buttons missing in modal/off-canvas

Closing as duplicate of 🐛 Save button missing in modal for editing media using Media Library Edit module Fixed

Apologies, I should have clarified. I used the patch from:

- https://www.drupal.org/project/gin/issues/3455080#comment-15650223 🐛 Save button missing in modal for editing media using Media Library Edit module Fixed
- and from the MR https://git.drupalcode.org/project/gin/-/merge_requests/435.patch

and in both cases it errored out.
Using core 10.3 and latest gin dev from today (26.06).
Please see screenshots patch1.png and patch2.png.

Oh wait, scratch that. I just tried rc11 with the patch from https://www.drupal.org/project/gin/issues/3455080#comment-15650223 🐛 Save button missing in modal for editing media using Media Library Edit module Fixed and it applied successfully. Unfortunately, that didn't fix the problem. Please see screenshots offcanvas1.png and offcanvas2.png.

I checked, I'm not hiding any fields on Manage form display and I don't have any CSS with display none or anything.

Maybe 🐛 Sticky action buttons doesn't save shipping method Needs review fixes your issue?

Thank you. This https://git.drupalcode.org/project/gin/-/merge_requests/430.patch got applied successfully but it didn't fix it.

I went one step further and installed D10.3 standard and I only enabled Gin theme and admin_dialogs and configured offcanvas for '/node/*' and when I clicked Edit on an existing node it still didn't show the Save node button (screenshot drupal-standard-offcanvas-test.png). Same thing with Modal.

Actually, I've tested this a bit more and no matter what form I open in offcanvas, there's no action button (save, delete, etc.).

This is still a problem.

@andreic maybe you can share more insights what exactly is still a problem? As I can't reproduce it anymore in 10.3 with the latest release. Make sure to clear all caches.

But how? There is no Save button.

I used these steps:
- installed D10.3 standard and I only enabled Gin theme and admin_dialogs
- configured offcanvas for '/node/*'
- when I clicked Content > Add content > Basic page it loads the form in offcanvas with no submit button.

I've attached 3 screenshots.

It seems this is a specific issue in combination with with admin_dialogs, is that assumption correct?

Yes, true.
How else did you test that modal/offcanvas node add/edit works?

How else did you test that modal/offcanvas node add/edit works?

We just tested with Core off-canvas integrations instead. So it either might be related to the node entity or to the admin_dialogs module (or the combination of both).

Can you try the following patch, I have a suspicion what the root cause might be.

The module authors seem to use Gin as well, maybe there is some work needed otherwise to make it compatible with the latest changes from RC11+.

Nice, it worked, thank you!
The only thing that still does not work is the Publish checkbox. It's just text, saying 'Not published'.

This needs a review 👀

Great, the MR fixes also the Published checkbox (screenshot attached). All good on my tests, thank you!

saschaeggi → credited DieterHolvoet → .

Strange, when I click Add content and the offcanvas opens, those buttons/links are not clickable.
Screenshot attached.

@andreic generally speaking it might not be a good idea to try to use the admin_dialog module to override all basic functionality with off-canvas dialogs as Drupal isn't designed for this. So you can always run into issues. The issue in #22 on the other hand has nothing to do with what we're trying to solve here as it's not a form at all.

If you want a better experience for the add content menu you can either use one of the following solutions:

• ✨ Improve "Add Content" on admin overview pages Needs work
• Use the new navigation module (Drupal 10.3+)
• Use Gin's experimental navigation implementation

Let's focus on fixing the modal/off-canvas form handling here 👀

Got it, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.