lexbritvin → created an issue.
Hello @anybody.
Probably yes, it's better to create a new issue then.
That's why I'm asking you if I follow the steps correctly.
Because with the latest versions of Drupal and modules, I was not able to reproduce the issue at all.
Maybe I miss the steps to reproduce.
Because of my tests, I will attach a revert patch to use in my projects.
Thank you for pointing out. That may be related.
Yes, I have Drupal 10.3.2, gin 3.0.0-rc13, gin_lb 1.0.0-rc8
But after further investigation, it doesn't seem to be correct.
I disabled the fix and it works well for me with multiple value field.
I tested the "Add another item" without gin_lb on content entity with Media library.
Meaning gin_lb is not making any specific magic to the buttons to make them work.
Are there specific steps to reproduce? Do I reproduce it correctly?
The auto buttons are not applied because the button is wrapped into `field-action` class, not `form-actions` like "Save" which are taken by dialog.
Regarding UI/UX, we have these buttons in the bottom in Media Library modal, in Media Add modal.
But somehow with the fix in Media Edit modal we have a different UI and different button placement.
For me the fix is not correct.
Can you please disable and quick check on your environments if I miss steps?
While the fix may have targeted the issue with "Add another item", but it introduced another issue in the gin_lb.
The "Save" button is not displayed at all.
See the screenshots before and after the fix:
Before
After
We must reopen the issue because the given solution is opinionated and doesn't consider themes.
lexbritvin → created an issue.
Reworked the drilling.
We lack some Functional tests for the fixed case when we have block layout builder with multiple sections.
lexbritvin → made their first commit to this issue’s fork.
lexbritvin → created an issue.
lexbritvin → created an issue.
lexbritvin → created an issue.
Reroll
Here is the patch to use in the project.
lexbritvin → changed the visibility of the branch 1.0.x to hidden.
lexbritvin → changed the visibility of the branch 3426687-close_dialog to active.
lexbritvin → changed the visibility of the branch 3426687-close_dialog to hidden.
lexbritvin → created an issue.
The provided patches don't consider install profile and default theme.
Here is a small enhancement to the patch.
The patch above broke style when using gin_lb.
Here is the patch that worked for me, it add a div wrapper for links.
lexbritvin → created an issue.
Reroll patch as the built styles were not correctly built.
Here is a patch with updated css.
lexbritvin → created an issue.
lexbritvin → created an issue. See original summary → .
lexbritvin → created an issue.
After investigation, the issue doesn't always reproduce. I added steps to reproduce to the issue summary. And updated the proposed resolution block.
I tested the solution on 9, 10 and 11-dev.
I opened a MR with the proposed solution. Likewise, I also attach a patch for history and usage in a project.
I'm not sure if we can add tests for this change.
lexbritvin → made their first commit to this issue’s fork.
The fix is ready. Please, review.
lexbritvin → created an issue.
lexbritvin → created an issue.
I think it's related to their EOL https://endoflife.date/drupal
Old versions may either work with an old version of a module, or if supported by someone, be updated to the latest Drupal version.
The issue appears again. Here is a little rework of format_size.
Please, reopen the issue and review the code.