Sidebar dialog close button is not visible in some cases

lexbritvin → changed the visibility of the branch 3426687-close_dialog to hidden.

lexbritvin → changed the visibility of the branch 3426687-close_dialog to active.

lexbritvin → changed the visibility of the branch 1.0.x to hidden.

Here is the patch to use in the project.

This doesn't fix anything for me. I'm still unable to configure blocks, as the layout builder settings are still on top.

Hi,

I think since the bug report there had been some update in Core or Gin because I can't reproduce the issue.

Need to specify on which Drupal core version it has been tested.

I have tested on (the project from which you have the problem):
- Core 10.1.8
- Gin 3.0.0-rc9
- Gin LB 1.0.0-rc6
- Gin Toolbar 1.0.0-rc5
No patch applied (I removed them from composer.json).
No problem.

I have also tested on:
- Core 10.2.4
- Gin 3.0.0-rc9
- Gin LB 1.0.0-rc6
- Gin Toolbar 1.0.0-rc5
No patch applied.
No problem.

Or am I testing something not related?

Yeah, adding a section is fine. The real problem, for me at least, is that the settings sidebar doesn't have a way to hide it.

Can you look at these? The side has "Layout Builder setting" (which should probably be plural "Layout Builder settings"), but there is no 'X' or "hide" button. How do I view the content that is behind the settings sidebar? It is blocking the Edit/Configure block buttons.

🐛 The new sidebar makes UI unusable when using Layout Builder Admin Theme Active

🐛 Preview Regions and Preview Content checkboxes are missing Active

I am seeing this issue come up when editing the Layout of a Menu or a custom Block entity, such as through urls like:
/admin/structure/menu/item/2/edit/layout
/admin/content/block/157/layout

The "Display options", "Save" and the little close button (for the sidebar) do not appear like they normally would when editing a node layout (i.e /node/1187/layout is fine) ...
which is quite rough because the Configure Block circle button for blocks on the right side of the page is hidden by that sidebar being overtop. No way to close it besides going into devtools and adding a hidden class to that section...

So, evidently the issue seems to deal with using Layout Builder on a front-end theme (fine) vs the admin theme (not fine)...

I am using:
* Core 10.2.6
* Gin 3.0-rc10
* Gin LB 1.0.0-rc7
* Gin TOOLBAR 1.0-rc5
All above currently latest available...

I also have the same issue with:
- Core 10.2.6
- Gin lb : 1.0.0-rc7
- Gin toolbar 8.x-1.0-rc5
- Layout Builder Modal 8.x-1.2
- Gin 8.x-3.0-rc10

@phjou Could you also look at the issues mentioned in #7 🐛 Sidebar dialog close button is not visible in some cases Needs review and see if you have them, too?