- First commit to issue fork.
- last update
about 1 year ago 30,136 pass - @lexbritvin opened merge request.
- Status changed to Needs review
about 1 year ago 5:46pm 7 September 2023 - last update
about 1 year ago 30,136 pass - π·πΊRussia lexbritvin
After investigation, the issue doesn't always reproduce. I added steps to reproduce to the issue summary. And updated the proposed resolution block.
I tested the solution on 9, 10 and 11-dev.
I opened a MR with the proposed solution. Likewise, I also attach a patch for history and usage in a project.I'm not sure if we can add tests for this change.
- Status changed to RTBC
about 1 year ago 8:17pm 8 September 2023 - πΊπΈUnited States smustgrave
Verified the issue following the steps in the IS
Patch #16 did solve the issue.Lowering to normal though as annoying as this is doesn't seem to break anything.
Thanks!
- last update
about 1 year ago 30,146 pass -
larowlan β
committed 928467a9 on 10.1.x
Issue #3152561 by lexbritvin, tim.plunkett, EricRondo, TwiiK: Layout...
-
larowlan β
committed 928467a9 on 10.1.x
-
larowlan β
committed 57366cba on 11.x
Issue #3152561 by lexbritvin, tim.plunkett, EricRondo, TwiiK: Layout...
-
larowlan β
committed 57366cba on 11.x
- Status changed to Fixed
about 1 year ago 6:01am 11 September 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I agree this would be difficult to test, and it can be easily manually tested. On the basis of our new proposed heuristics π± [policy, no patch] Better scoping for bug fix test coverage RTBC I think this can go in without tests.
I checked in gitlab for any other classes in contrib that extend this class that may not want this behaviour but could not find any.
Committed to 11.x and backported to 10.1.x
Automatically closed - issue fixed for 2 weeks with no activity.