- ๐ฎ๐ณIndia Nupur Badola
Errors in the patch exists.
git.drupalcode.org_project_session_limit_-_merge_requests_6.diff.txt:7: trailing whitespace. # Session-limit module git.drupalcode.org_project_session_limit_-_merge_requests_6.diff.txt:63: new blank line at EOF. + warning: 2 lines add whitespace errors.
- Status changed to Needs work
about 1 year ago 9:08am 25 October 2023 - ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Status changed to Needs review
about 1 year ago 12:52pm 25 October 2023 - Status changed to Needs work
about 1 year ago 7:03am 26 October 2023 - ๐ต๐ญPhilippines kenyoOwen
Hi chetan 11
I reviewed your MR!9 but it's not following the README.md template โ .
And Drupal recommends the following README sections:
Project name and introduction (required) Table of contents (optional) Requirements (required) Recommended modules (optional) Installation (required, unless a separate INSTALL.md is provided) Configuration (required) Troubleshooting & FAQ (optional) Maintainers (optional)
For more information visit the documentation. โ
Thank you.
- Assigned to nitin_lama
- Assigned to Neha-Verma
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
11 months ago 11:14am 3 January 2024 - ๐ฎ๐ณIndia ravi kant Jaipur
All required sections are not covered according README.md template suggestions. โ
- Status changed to Needs work
11 months ago 11:26am 3 January 2024 - Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 5:49am 4 January 2024 - ๐ฎ๐ณIndia Neha-Verma
Sections are covered according to README.md template suggestions.
Please review.
Thanks - Status changed to Needs work
11 months ago 12:18am 5 January 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Neha-Verma
I reviewed your changes and noticed that the "Configuration" text has ":"
Configuration:
colon symbol and maintainer section has only 4 but the module has 6 maintainers.Thank you.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Status changed to Needs review
11 months ago 4:44am 5 January 2024 - Status changed to RTBC
11 months ago 3:22am 8 January 2024 - ๐ต๐ญPhilippines kenyoOwen
Hi Neha-Verma
I reviewed your changes in MR!9 and it addressed comment #20 and followed the README.md template.
Thank you.
-
VladimirAus โ
committed 9f4e5f72 on 2.0.x authored by
chetan 11 โ
Resolve #3322435 "2"
-
VladimirAus โ
committed 9f4e5f72 on 2.0.x authored by
chetan 11 โ
- Status changed to Fixed
7 months ago 2:41pm 6 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.