Fix the issues reported by phpcs

Created on 11 January 2023, almost 2 years ago
Updated 19 January 2024, 11 months ago

Problem/Motivation

Running phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/gutenberg/css shows the following errors/warnings.

FILE: /app/modules/contrib/gutenberg/css/admin.css
 384 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/bartik.css
 17 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/block-library.css
 9 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/claro.css
  7 | ERROR | [ ] Style definitions must end with a semicolon
  8 | ERROR | [ ] Style definitions must end with a semicolon
  9 | ERROR | [ ] Style definitions must end with a semicolon
 10 | ERROR | [ ] Style definitions must end with a semicolon
 51 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/editor.css
  81 | ERROR | [x] Multiple selectors should each be on a single line
 172 | ERROR | [x] Multiple selectors should each be on a single line
 210 | ERROR | [x] Multiple selectors should each be on a single line
 214 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/olivero.css
   4 | ERROR | [x] Selectors must be on a single line
  83 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  84 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
  85 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 111 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 112 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces,
     |       |     found 0
 129 | ERROR | [ ] Class definition is empty
 417 | ERROR | [x] Multiple selectors should each be on a single line
 426 | ERROR | [x] Multiple selectors should each be on a single line
 431 | ERROR | [x] Multiple selectors should each be on a single line
 441 | ERROR | [x] Multiple selectors should each be on a single line
 446 | ERROR | [x] Multiple selectors should each be on a single line
 450 | ERROR | [x] Multiple selectors should each be on a single line
 455 | ERROR | [x] Multiple selectors should each be on a single line
 461 | ERROR | [x] Multiple selectors should each be on a single line
 465 | ERROR | [x] Multiple selectors should each be on a single line
 469 | ERROR | [x] Multiple selectors should each be on a single line
 473 | ERROR | [x] Multiple selectors should each be on a single line
 477 | ERROR | [x] Multiple selectors should each be on a single line
 481 | ERROR | [x] Multiple selectors should each be on a single line
 489 | ERROR | [x] Multiple selectors should each be on a single line
 493 | ERROR | [x] Multiple selectors should each be on a single line
 497 | ERROR | [x] Multiple selectors should each be on a single line
 501 | ERROR | [x] Multiple selectors should each be on a single line
 505 | ERROR | [x] Multiple selectors should each be on a single line
 509 | ERROR | [x] Multiple selectors should each be on a single line
 513 | ERROR | [x] Multiple selectors should each be on a single line
 523 | ERROR | [x] Multiple selectors should each be on a single line
 527 | ERROR | [x] Multiple selectors should each be on a single line
 531 | ERROR | [x] Multiple selectors should each be on a single line
 539 | ERROR | [x] Multiple selectors should each be on a single line
 543 | ERROR | [x] Multiple selectors should each be on a single line
 547 | ERROR | [x] Multiple selectors should each be on a single line
 551 | ERROR | [x] Multiple selectors should each be on a single line
 555 | ERROR | [x] Multiple selectors should each be on a single line
 565 | ERROR | [x] Multiple selectors should each be on a single line
 572 | ERROR | [x] Multiple selectors should each be on a single line
 652 | ERROR | [x] Expected 1 newline at end of file; 0 found

FILE: /app/modules/contrib/gutenberg/css/seven.css
  6 | ERROR | [ ] Style definitions must end with a semicolon
  7 | ERROR | [ ] Style definitions must end with a semicolon
 32 | ERROR | [x] Expected 1 newline at end of file; 0 found

Proposed resolution

Fix the errors and warnings.

📌 Task
Status

Closed: duplicate

Version

2.0

Component

Code

Created by

🇮🇳India shivam-kumar

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹
  • 🇮🇹Italy apaderno Brescia, 🇮🇹

    Anyway, why is PHP_CodeSniffer used only to check a single directory?

  • Pipeline finished with Skipped
    over 1 year ago
    #22815
  • Pipeline finished with Skipped
    about 1 year ago
    #48885
  • First commit to issue fork.
  • Status changed to Closed: duplicate 11 months ago
  • 🇷🇺Russia zniki.ru

    Close because there is another issue 📌 Fix the issues reported by phpcs Needs work

  • Pipeline finished with Running
    11 months ago
    #81759
  • Pipeline finished with Skipped
    11 months ago
    #83418
  • Pipeline finished with Failed
    10 months ago
    Total: 152s
    #106158
  • Pipeline finished with Success
    10 months ago
    Total: 153s
    #106388
  • Pipeline finished with Success
    10 months ago
    Total: 160s
    #111094
  • Pipeline finished with Failed
    9 months ago
    #123334
  • Pipeline finished with Success
    9 months ago
    Total: 2843s
    #125031
  • Pipeline finished with Success
    9 months ago
    Total: 148s
    #125074
  • Pipeline finished with Success
    9 months ago
    Total: 174s
    #125204
  • Pipeline finished with Success
    9 months ago
    Total: 197s
    #137635
  • Pipeline finished with Failed
    9 months ago
    Total: 636s
    #143691
  • Pipeline finished with Failed
    9 months ago
    #143716
  • Pipeline finished with Failed
    8 months ago
    Total: 34s
    #148128
  • Pipeline finished with Failed
    8 months ago
    #151892
  • Pipeline finished with Failed
    8 months ago
    #151897
  • Pipeline finished with Failed
    8 months ago
    Total: 238s
    #151953
  • Pipeline finished with Success
    8 months ago
    Total: 8004s
    #152063
  • Pipeline finished with Success
    8 months ago
    Total: 302s
    #153315
  • Pipeline finished with Success
    8 months ago
    Total: 247s
    #154575
  • Pipeline finished with Canceled
    8 months ago
    Total: 269s
    #160888
  • Pipeline finished with Failed
    8 months ago
    Total: 287s
    #160930
  • Pipeline finished with Success
    8 months ago
    Total: 177s
    #161714
  • Pipeline finished with Skipped
    8 months ago
    #167158
  • Pipeline finished with Success
    7 months ago
    Total: 284s
    #177152
  • Pipeline finished with Canceled
    7 months ago
    Total: 15s
    #179044
  • Pipeline finished with Failed
    7 months ago
    Total: 270s
    #183910
  • Pipeline finished with Failed
    7 months ago
    Total: 323s
    #185901
  • Pipeline finished with Success
    7 months ago
    Total: 269s
    #186719
  • Pipeline finished with Success
    7 months ago
    Total: 554s
    #194738
  • Pipeline finished with Success
    6 months ago
    Total: 301s
    #217047
  • Pipeline finished with Success
    5 months ago
    Total: 220s
    #224698
  • Pipeline finished with Failed
    5 months ago
    Total: 40s
    #224791
  • Pipeline finished with Failed
    5 months ago
    Total: 57s
    #224812
  • Pipeline finished with Success
    5 months ago
    Total: 256s
    #224832
  • Pipeline finished with Success
    5 months ago
    Total: 139s
    #231971
  • Pipeline finished with Success
    5 months ago
    Total: 136s
    #232084
  • Pipeline finished with Success
    5 months ago
    Total: 161s
    #232125
  • Pipeline finished with Success
    5 months ago
    Total: 161s
    #232157
  • Pipeline finished with Success
    5 months ago
    Total: 443s
    #232423
  • Pipeline finished with Failed
    5 months ago
    #232482
  • Pipeline finished with Failed
    5 months ago
    Total: 49s
    #233240
  • Pipeline finished with Failed
    5 months ago
    Total: 210s
    #234472
  • Pipeline finished with Failed
    5 months ago
    #234478
  • Pipeline finished with Failed
    5 months ago
    #234670
  • Pipeline finished with Failed
    5 months ago
    #234856
  • Pipeline finished with Canceled
    5 months ago
    Total: 183s
    #234868
  • Pipeline finished with Canceled
    5 months ago
    Total: 453s
    #234870
  • Pipeline finished with Success
    5 months ago
    Total: 413s
    #234893
  • Pipeline finished with Skipped
    5 months ago
    #240193
  • Pipeline finished with Canceled
    5 months ago
    Total: 78s
    #242217
  • Pipeline finished with Success
    5 months ago
    #242218
  • Pipeline finished with Success
    5 months ago
    Total: 140s
    #242366
  • Pipeline finished with Success
    5 months ago
    Total: 495s
    #243327
  • Pipeline finished with Success
    5 months ago
    Total: 636s
    #243335
  • Pipeline finished with Success
    5 months ago
    Total: 661s
    #243379
  • Pipeline finished with Success
    5 months ago
    Total: 466s
    #243550
  • Pipeline finished with Success
    5 months ago
    Total: 457s
    #243575
  • Pipeline finished with Success
    5 months ago
    Total: 481s
    #244229
  • Pipeline finished with Success
    5 months ago
    Total: 423s
    #244244
  • Pipeline finished with Success
    5 months ago
    #244656
  • Pipeline finished with Success
    5 months ago
    #244680
  • Pipeline finished with Success
    5 months ago
    Total: 172s
    #244844
  • Pipeline finished with Running
    5 months ago
    #245950
  • Pipeline finished with Success
    5 months ago
    #245995
  • Pipeline finished with Failed
    5 months ago
    Total: 938s
    #246580
  • Pipeline finished with Success
    5 months ago
    Total: 552s
    #248004
  • Pipeline finished with Success
    5 months ago
    Total: 633s
    #248057
  • Pipeline finished with Success
    4 months ago
    Total: 632s
    #254798
  • Pipeline finished with Success
    4 months ago
    Total: 149s
    #255131
  • Pipeline finished with Success
    4 months ago
    Total: 199s
    #258564
  • Pipeline finished with Success
    4 months ago
    Total: 141s
    #258576
  • Pipeline finished with Success
    4 months ago
    Total: 195s
    #260472
  • Pipeline finished with Success
    4 months ago
    Total: 304s
    #261582
  • Pipeline finished with Success
    4 months ago
    Total: 346s
    #261635
  • Pipeline finished with Success
    4 months ago
    Total: 387s
    #264277
  • Pipeline finished with Success
    4 months ago
    Total: 307s
    #264588
  • Pipeline finished with Failed
    3 months ago
    Total: 516s
    #287349
  • Pipeline finished with Success
    3 months ago
    Total: 172s
    #287355
  • Pipeline finished with Failed
    3 months ago
    Total: 111s
    #304505
  • Pipeline finished with Failed
    3 months ago
    Total: 81s
    #304891
  • Pipeline finished with Failed
    3 months ago
    Total: 65s
    #304918
  • Pipeline finished with Failed
    3 months ago
    Total: 31s
    #304943
  • Pipeline finished with Failed
    3 months ago
    Total: 31s
    #305107
  • Pipeline finished with Failed
    3 months ago
    Total: 31s
    #305117
  • Pipeline finished with Failed
    3 months ago
    Total: 78s
    #305120
  • Pipeline finished with Success
    3 months ago
    Total: 150s
    #307436
  • Pipeline finished with Failed
    about 2 months ago
    Total: 567s
    #322082
  • Pipeline finished with Failed
    about 2 months ago
    Total: 470s
    #322192
  • Pipeline finished with Failed
    about 2 months ago
    Total: 606s
    #322201
  • Pipeline finished with Success
    about 2 months ago
    Total: 667s
    #323457
  • Pipeline finished with Success
    about 2 months ago
    Total: 456s
    #323464
  • Pipeline finished with Canceled
    about 2 months ago
    Total: 222s
    #323470
  • Pipeline finished with Success
    about 2 months ago
    Total: 289s
    #323476
  • Pipeline finished with Success
    about 2 months ago
    Total: 34186s
    #323793
  • Pipeline finished with Success
    about 2 months ago
    Total: 737s
    #324287
  • Pipeline finished with Failed
    about 2 months ago
    Total: 269s
    #330562
  • Pipeline finished with Failed
    about 2 months ago
    Total: 533s
    #330573
  • Pipeline finished with Skipped
    about 1 month ago
    #347298
Production build 0.71.5 2024