- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
- Status changed to Needs review
over 2 years ago 9:45am 14 March 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 2 years ago Waiting for branch to pass - 🇮🇳India Yashaswi18
Tried applying the patch provided in #33, got the following error :
git apply 3255698-33.patch -v Checking patch gutenberg.services.yml... Checking patch src/Ajax/UpdateMediaEntitiesCommand.php... Checking patch src/BlockProcessor/DuotoneProcessor.php... Checking patch src/BlockProcessor/OEmbedProcessor.php... Checking patch src/BlockProcessor/ReusableBlockProcessor.php... Checking patch src/BlocksRendererHelper.php... Checking patch src/Controller/BlocksController.php... Checking patch src/Controller/MediaController.php... Checking patch src/Controller/ReusableBlocksController.php... Checking patch src/Controller/SearchController.php... error: while searching for: return new JsonResponse([]); } $query = \Drupal::entityQuery('node'); $query->condition('title', $search, 'CONTAINS') ->condition('status', 1) ->sort('created', 'DESC') error: patch failed: src/Controller/SearchController.php:35 error: src/Controller/SearchController.php: patch does not apply Checking patch src/Controller/UtilsController.php... Checking patch src/DataProvider/BaseDataProvider.php... Checking patch src/DataProvider/FileEntityDataProvider.php... Checking patch src/DataProvider/MediaEntityDataProvider.php... Checking patch src/Discovery/BlockJsonDiscovery.php... Checking patch src/Form/BlockSettingsForm.php... Checking patch src/GutenbergElementInfoAlter.php... Checking patch src/GutenbergLibraryManager.php... Hunk #3 succeeded at 254 (offset 7 lines). Checking patch src/GutenbergMediaLibraryUiBuilder.php... Checking patch src/MappingFieldsHelper.php... Checking patch src/MediaSelectionProcessor/MediaSelectionProcessorInterface.php... Checking patch src/OEmbedResolver.php... Checking patch src/Parser/BlockParser.php... Checking patch src/Parser/BlockParserFrame.php... Checking patch src/Plugin/Filter/GutenbergFilter.php... Checking patch src/Plugin/GutenbergPlugin/DrupalImage.php... Checking patch src/ScanDir.php... Checking patch src/Service/MediaService.php... Hunk #8 succeeded at 476 (offset 2 lines). Checking patch src/TinyColor.php... - 🇷🇺Russia zniki.ru
I think no changes to vendor folder needs to be made
Please use command and ignore vendor folder.phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme modules/contrib/gutenberg/ --ignore=*/vendor/*I update IS.
- Status changed to Needs work
almost 2 years ago 4:43pm 19 January 2024 - First commit to issue fork.
- Merge request !227Created a merge request to get a report of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno