Incorrect color for active menu item in dark mode

@jabeler
Created the patch for this issue.

@ravi kant can you please create a MR? We don't use patches anymore! Thanks 🙇

@saschaeggi
I have created the MR now. Please review.

I just tested this MR. This MR solved the issue. Attaching a screenshot for reference.

Moving to RTBC

kksandr → made their first commit to this issue’s fork.

@kksandr
According to me, The active link is more highlighting with background color.

The active link is more highlighting with background color.

This is not a fix, but an improvement. I restored it to the way it was before the breakdown.
I think design changes should create a separate issue.

I've made some additional changes. Let's get this merged 🚂

Thanks for participating in fixing this issue 🎉

Colors are back to normal in the latest dev build (21 Dec 2023 at 11:42 UTC). Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

I am still seeing the background color on the active menu which should not.
I think the background color in this class ".gin--horizontal-toolbar #toolbar-administration .toolbar-menu-administration .menu-item > .toolbar-icon.is-active" should be removed.

@mahde
What Gin theme version is using by you?

FYI the active item should have a background color, it wasn't there before as it was a bug.

@ravi kant - I am using the latest version of gin theme RC8.
@saschaeggi - I thought it's not having the background color as it was in previous versions.
Although it's better looking without background but thanks for clarification!

Although it's better looking without background but thanks for clarification!

This might be very subjective but I'd argue otherwise. Also it helps stand out more especially if you use the White/Black combination.