🇮🇳India @Meeni_Dhobale

meeni_dhobale → made their first commit to this issue’s fork.

I tried the solution provided the in the #38 but it doesn't work if there is more than 2 or 3 menu items. Instead of that I tried another with to setting position and alignment to unset. It works fine with the extra <li>'s and with extra menus as well.
Attaching the before and after images.

Before:

With Single Item:

With multiple <li> menu:

With multiple menu items:

meeni_dhobale → made their first commit to this issue’s fork.

Adding a MR for the issue. It is same as a .patch

meeni_dhobale → made their first commit to this issue’s fork.

Working on this issue....

meeni_dhobale → made their first commit to this issue’s fork.

Meeni_Dhobale → made their first commit to this issue’s fork.

Meeni_Dhobale → made their first commit to this issue’s fork.

Kristen Pol → credited Meeni_Dhobale → .

Hi, @ckrina, @quietone can we have a more detailed summary of this issue? Also, the Tour module has been deprecated → from the core since D10 so what do we want exactly with Tour module integration?
Do we want the tour button to be placed in the navigation panel after the user installs the Tour module?
OR do we want the actual tour of the navigation module? The same as view has its tour in D9.
OR we want something else.

Meeni_Dhobale → made their first commit to this issue’s fork.

I just get a fresh pull of 11.x-dev branch, But I'm not able to reproduce this issue. @dreamleaf or @Hetal.Solanki can you please elaborate more how to reproduce this issue. Because I followed all the steps which is mentioned earlier.

I reviewed and tested the current MR. The changes are looks fine to me. the changes are worked for Non-hyperlink anchors only. Adding before and after effects.
Before:

After:

I think this issue has to be in RTBC.

Meeni_Dhobale → changed the visibility of the branch 3458215-migrate-toolbar-button-sdc to hidden.

I just checked and reviewed the latest MR, the changes resolved the Drupal\Core\Render\Component\Exception\InvalidComponentException: [extra_classes] String value found, but an array or an object is required in Drupal\Core\Theme\Component\ComponentValidator->validateProps() (line 203 of core/lib/Drupal/Core/Theme/Component/ComponentValidator.php) error.

Meeni_Dhobale → made their first commit to this issue’s fork.

lauriii → credited Meeni_Dhobale → .

Tried to fix wget https://www.drupal.org/files/projects/drupal-x.y.z.tar.gz URL to download Drupal.

Meeni_Dhobale → made their first commit to this issue’s fork.

Meeni_Dhobale → made their first commit to this issue’s fork.

Hi, this "X" button is added by the Media module. This module overrides the base Gin theme CSS. I tried to find the exact button design with the icon but didn't get it anywhere.

However, We can override that Media file CSS to stay consistent overall.

Otherwise, we have to change
background-image: url("data:image/svg+xml,%3csvg xmlns='http://www.w3.org/2000/svg' width='16' height='16'%3e%3cpath fill='%23000000' d='M3.51 13.925c.194.194.512.195.706.001l3.432-3.431c.194-.194.514-.194.708 0l3.432 3.431c.192.194.514.193.707-.001l1.405-1.417c.191-.195.189-.514-.002-.709l-3.397-3.4c-.192-.193-.192-.514-.002-.708l3.401-3.43c.189-.195.189-.515 0-.709l-1.407-1.418c-.195-.195-.513-.195-.707-.001l-3.43 3.431c-.195.194-.516.194-.708 0l-3.432-3.431c-.195-.195-.512-.194-.706.001l-1.407 1.417c-.194.195-.194.515 0 .71l3.403 3.429c.193.195.193.514-.001.708l-3.4 3.399c-.194.195-.195.516-.001.709l1.406 1.419z'/%3e%3c/svg%3e");

with our expected fill colour.

I am trying to review this commit on 11.x branch but I'm not able to reproduce the main issue.

I am trying to review this MR, but I am not able to add those buttons in my paragraph. I am using 11.x branch.

I removed the @nest deprecated directive and solved the linting errors. Adding before and after screenshots.
RTL-Before

RTL-After

LTR-Before

LTR-After

Meeni_Dhobale → made their first commit to this issue’s fork.

Here are some steps to reproduce:
* Login as admin
* Go to any content type/contact form or anything where we can see the tabs menu. eg. /admin/structure/types/manage/article/fields
* Try to replicate those tab menus by inspecting the page, So we can see the multiple tabs that can get the whole display width or adjust the screen size accordingly.
* Now check the tabs by enabling focus on it.

Here are the before and after images:
Before:

After:

Meeni_Dhobale → made their first commit to this issue’s fork.

@swatidhurandhar, @phjou I tried to reproduce this issue, but I'm not able to reproduce this on my local. Can you please provide detailed steps to reproduce this issue?

I added the MR by changing the nav bottom padding and alignment centre. Those two property solves the issues. Adding a screenshot for reference.

Meeni_Dhobale → made their first commit to this issue’s fork.

I tried the javascript approach mentioned in the #9 🐛 The scrollbar moves the content of the sidebar Needs work to add scrollbar-gutter only when the overflow-Y is true; but at this point, it's also having a moving effect and it also works same as a browsers native behaviour.

here is the implementation.

To container the UI constant I manage the right padding space by taking reference from Figma.
Here is the output:

I just tested this MR. This MR solved the issue. Attaching a screenshot for reference.

Moving to RTBC

I added some spacing between top-level menus.

Meeni_Dhobale → made their first commit to this issue’s fork.

I updated the MR and made suggested changes. Can anyone please review it? Changing status to NR.

I refactor the .pcss.css file. I was trying to rebase the current branch but facing some issues, so adding patch for now.
Here is the previous module list file.

Here are the screenshots of the changes.

Working on this issue as a part of Claro Contribution Day.

I added a new classes and prev button icon to the back button. Adding reference image.

I am working on this issue as a part of Claro Contribution Day.

As @ckrina mentioned in the above discussion, we have to add a button theme and an icon to it.

I have added padding on both sides as 12px. Here is how it looks now.

Meeni_Dhobale → made their first commit to this issue’s fork.

Here are some steps that I followed:
First I check the version of the current font file. It show me Version 3.019;git-0a5106e0b

After that, I go to the given link and download the font. Multiple font variations are available, so I choose InterVariable.woff2 variation. Here is the reason why I use the variable file. Now it's updated to the latest font version.

I updated the asset font file with the Inter v4 font file. I used InterVariable.woff2 file.

Meeni_Dhobale → made their first commit to this issue’s fork.

MR Updated and added scrollbar-gutter for the footer nav and menu nav.

I made the suggested changes, but I see another issue is occurring by using the scrollbar-gutter property. This will only be applying the stable spacing to the upper menus. For footer menus, we need to add overflow property which messes with the previous designs. So I am thinking about getting the current width (after applying scrollbar-gutter) of the top menu and setting it for the footer menus by using JS. Any suggestions on this approach?

I raised the MR by adding some comments and tags where needed. I also followed the javascript coding standards → as well.

while checking for the linting errors I found one.

modules/contrib/navigation/js/toolbar-popover.js
  102:15  error  'close' was used before it was defined  no-use-before-define

✖ 1 problem (1 error, 0 warnings)

the same error shown by the delayedClose() as well, So I moved it upwards before the close() and open() functions, but inside he delayedClose() the close() is called. So here circular deadlock occurs.
Is there any solution to solve this.

Meeni_Dhobale → made their first commit to this issue’s fork.

I modified JavaScript where previously we checked that our menu link is the same as our URL. Now it checks whether the URL contains our menu link or not. This is solving our problem.

Meeni_Dhobale → made their first commit to this issue’s fork.

Making the toolbar-block a bit smaller as required by the scrollbar also made the scrollbar thumb with a smaller width. So it helps to solve this content movement issue.

@kostyashupenko & @ckrina Yes it is the browser's native behaviour, but what if we can make that scroll bar a little small to match the theme, it seems very weird to see that big scroll bar. What if we can make it custom and set its width, height and colour the same as our hover effect's bar?

I tried to reproduce this issue. I set the maximum alias length to 150 and add 200. Pathauto can generate a path up to a given maximum alias length very correctly. Not able to reproduce this issue on my end.

I also tried to reproduce this issue without applying the patch with title "A.Foo" and my URL is "/afoo". I didn't see any kind of 403 HTTP code. I am also not able to reproduce this issue.

Thanks for the clarification on the core_version_requirement changes. These new changes provide more clarity about Drupal core versions.

Yes, I think this MR will solve this issue, I also tried this solution on my local and it is working fine for me. The animation looks much smoother than previous.

Meeninath Dhobale - Session/Speaker Volunteer.

Meeni_Dhobale → made their first commit to this issue’s fork.

Done changes as requested. Made MR.

Meeni_Dhobale → made their first commit to this issue’s fork.

I am trying to get the pull of the current working branch but always getting the access denied error.

Adding patch

Hi @alok_singh I review your MR, I notice some points in it. Here we have SASS files to change the CSS. Without directly change the compile CSS, we can change the . Scss file. So Whenever next time the cases will generate then it's not going to modify. For now your changes will removed when next time all cases will compile. Instead of changing CSS you can make changes in /school_zymphonies_theme/sass/media.scss and compile them.
You can change code like this

.region-primary-menu {
    .menu-base-theme {
      ul {
        display: flex;
        align-items: center;
      }
    }
  }

Hi @alok_singh I review your MR and also tried it on local. It is solving the issue, but there is some other issue occurring after the theme installation. Embedding the error message.

Hi @apaderno I test and review this patch #13, and it is applied very cleanly. But there has still one error remained. In PrivateMessageIniviteForm.php file. Adding error message below.:

FILE: ...Source/drupal-10-1/modules/contrib/private_message_invite/src/Form/PrivateMessageIniviteForm.php
------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
36 | WARNING | Line exceeds 80 characters; contains 86 characters
------------------------------------------------------------------------------------------------------

Hi @Sahana_N I test your patch. It is working fine. But I think it is better to have more descriptive help text in it. So, updating patch with additional setup steps.

I tried the last updated #26, and it seem that issue is not soved yet. Need to work on this.

Hi @paraderojether thank you so much for review my patch.

I tried to solve it, and spend some time but, but didn't understand why this happening, this issue not coming in Drupal core 9.5. I compared both files and view for the same blocks in both Drupal versions but didn't see any difference. Not understanding why this happening, If someone has any idea regarding it please share.

I tried to add wrapper element by using the preprocessor. I only added the wrapper for default formater.
The output is as follows:

Hi @PCate,
I tried the module with the png images, but I noticed that when I use a PNG image, it is already converted as PNG. Maybe I am looking somewhere else so I do not understand what you are trying to say. If you can provide some more context on it then it will be very helpful.

I added the patch for the truncate the title as per the user given number.

Here I added the new field.

Hello,
I reviewed the patch #21 and it's working fine for me. I also check with the other two options, Remove special characters and Re-save. This patch is working fine so issue can be move to RTBC.

Is we realy need the quickedit button on the empty filed...? Because if the field is not visible on the node page, then why, how and where we need to show the quickedit button. @Yuri I didn't understand the use case.

I'll looking on that.