- 🇮🇳India athyamvidyasagar
I have added the patch, it's working fine for me.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 1:07pm 13 June 2023 - 🇮🇳India shyam_bhatt Gujarat
Verified and tested patch#52 on the Drupal 11.x-dev version and Claro. Patch was applied successfully and looks good to me for DESKTOP and MOBILE.
Testing Steps:
- Install Drupal 11.x-dev version.
- Go to Appearance -> Set Claro theme as admin and default theme
- Add content and click on "PREVIEW"
- Observe broken content displayed on the preview page, please check the before-preview image.
- Now apply the patch and clear the cache.
- Again go to previe
w and verify after the patch proper content displayed on the preview page for desktop and mobile.
Testing Results:
After applying the patch proper content preview is displayed on the desktop view.
After applying the patch proper content preview is displayed on the mobile view.
Working as expected, We can move this ticket to RTBC. - Status changed to Needs work
over 1 year ago 1:42pm 13 June 2023 - 🇺🇸United States smustgrave
Think a solution similar to 🐛 Improve preview usability Fixed should be implemented.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 2:40pm 13 November 2023 - Status changed to Needs work
about 1 year ago 3:10pm 13 November 2023 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 1:11am 20 November 2023 Tested MR 5372 on Drupal 11 and it is cleanly applied, the issue has been fixed now. Back to content link is not overlapping now with the content.
But In the proposed resolution mentioned - the solution is that we should add a back icon on the link so that the user experience can be better.- Status changed to Needs work
about 1 year ago 6:16am 23 November 2023 - 🇮🇳India ameymudras
@shweta__sharma My understanding of #57 implementation was to move all the styles related node preview to a separate css file alltogether
Yes, @ameymudras you're correct but in the proposed resolution there is a back icon just before the link so I was talking about that icon do we need to add it or not? Because in the current implementation, there is no back icon. If we don't need to add the back icon then we can move the status to RTBC.
Thanks- Assigned to Meeni_Dhobale
- 🇮🇳India Meeni_Dhobale
I am working on this issue as a part of Claro Contribution Day.
As @ckrina mentioned in the above discussion, we have to add a button theme and an icon to it.
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:42am 15 December 2023 - 🇮🇳India Meeni_Dhobale
I added a new classes and prev button icon to the back button. Adding reference image.
- Assigned to divya.sejekan
- Issue was unassigned.
- Status changed to RTBC
about 1 year ago 11:35am 15 December 2023 - 🇮🇳India divya.sejekan
Hi, I have verified this issue in Drupal 11.x-dev with Claro theme . The issue related to the overlapping of Back to content editing link in preview view of the claro has been fixed .
Testing steps followed :
1. Install drupal 11
2. Make Claro theme default
3. Apply the patch
4. Add content and swtich to preview mode
5. Observe the Back to content editing link and the view mode dropdown.Attaching the screenshots . Moving to RTBC
Thanks! I am working on this issue as a part of Claro Contribution Day.
- Open on Drupal.org →Environment: PHP 8.0 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 29,260 pass, 20 fail - Status changed to Fixed
about 1 year ago 5:39pm 15 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.