Navigation Top Bar hides entity local tasks even if the user has no access to the bar

MR created.

Hello,
Tested and verified on Drupal 11,
MR applied successfully
Looks good before and after MR
Attaching screenshots for before and after

This looks good!

I tested by installing the standard profile, and enabling navigation_top_bar module. I then created a new role with bypass node access permission, created a user of that role and logged in. As expected the local tasks were inline in the page.

I then gave that role access navigation permission, refreshed the page for the test user session, and local tasks were moved to the top bar as expected.

RTBC+1 on the D11 branch.

However, it doesn't apply to 10.4.x, so I added another MR (https://git.drupalcode.org/project/drupal/-/merge_requests/10627/diffs) hoping that it gets ported to 10.4.

Keeping the RTBC status of the issue per D11.

larowlan → closed merge request !10469

larowlan → closed merge request !10627

Committed to 11.x and backported to 10.5.x, 11.1.x and 10.4.x

Nice work all

This broke head, opening a follow-up MR to fix the test.

So what happened is we added the new performance test, the last MR run here was before that commit, so we didn't get a test run with the new test. Just one extra cache get, probably from the permissions check. Going ahead and committing here to unbreak HEAD.

catch → closed merge request !10636

@catch, Thanks for fixing tests.