- Issue created by @dreamleaf
- Assigned to Hetal.Solanki
- ๐ฎ๐ณIndia Hetal.Solanki
@dreamleaf,
For testing purposes, I added padding.
I've attached two screenshots: one without the display border, which does not look well, and one with the border.
As I tested, there are two scenarios: with and without the Display Mode border. So I divided it into two points.1. Display Mode has a border.
When we add padding to the second child, it looks excellent if Display Mode has a border.
2. Display Mode without Border.
However, if Display Mode does not have a border and we add padding, it will look weird.So, in my opinion, the second child looks terrific without any padding.
Thank you!!
- Issue was unassigned.
- Status changed to Needs review
about 2 months ago 7:34am 24 July 2024 - ๐ฎ๐ณIndia Meeni_Dhobale
I just get a fresh pull of 11.x-dev branch, But I'm not able to reproduce this issue. @dreamleaf or @Hetal.Solanki can you please elaborate more how to reproduce this issue. Because I followed all the steps which is mentioned earlier.
- ๐ฌ๐งUnited Kingdom dreamleaf
@Meeni_Dhobale Apologies, I'll add this to the issue, but I spotted this in the experimental version on a 10.3.1 install.
I assumed that due to the requirement to work on issues on the highest version, it would have been backported if fixed.
- Status changed to Needs work
about 1 month ago 12:49pm 26 July 2024 - ๐ฎ๐ณIndia ehsann_95
ahsannazir โ made their first commit to this issueโs fork.
- Merge request !8992Issue #3463356: Add padding to level 2 menu items. โ (Open) created by Unnamed author
- Status changed to Needs review
about 1 month ago 3:59am 1 August 2024 - ๐ฌ๐งUnited Kingdom dreamleaf
@ahsannazir I notice you went for a smaller padding increment of
padding-block-start: var(--admin-toolbar-space-8);
- to my eye this still looks uneven between the top and bottom of UL. It's very minor, and probably needs a space of 10, but the variables increment in 4's, so neither is 100% correct.As my original issue, I would still recommend using the 12 padding size.
- Status changed to Postponed: needs info
about 1 month ago 9:40am 2 August 2024 - ๐ท๐ธSerbia finnsky
From what i see here
https://www.figma.com/design/VCPAxetieAC2pzw7hgX3ij/Drupal-Admin-UI---De...This padding top was never designed.
Probably i'm wrong.
Needs designer review here.