%AutoEntityLabel% title when "Preserve already created node titles." option is enabled

Here's an alternate patch that moves the "isTitlePreserved()" check into the "autoLabelNeeded()" method and ignores preserving the title if the title is empty or is "%AutoEntityLabel%".

Hello,
I reviewed the patch #21 and it's working fine for me. I also check with the other two options, Remove special characters and Re-save. This patch is working fine so issue can be move to RTBC.

Hi,

I am still experiencing the same issue as described in #6 and #7 so not sure if this should be RTC.

Here's an update for patch from #21 that checks the entity ID is not empty when determining if generating the auto label is needed, i.e., if empty ID then auto label is not needed (don't auto-generate label).

#24 seems to not work correctly on newly created entities when the "Automatically generate the label and hide the label field" option is set, it creates entities with empty labels. This can be seen by the tests failing.

A variation of #24 that includes this change:

@@ -161,8 +161,7 @@ function auto_entitylabel_entity_presave(EntityInterface $entity) {
     $decorator = \Drupal::service('auto_entitylabel.entity_decorator');
     /** @var \Drupal\auto_entitylabel\AutoEntityLabelManager $decorated_entity */
     $decorated_entity = $decorator->decorate($entity);
-    if ($decorated_entity->hasLabel() && $decorated_entity->autoLabelNeeded()
-      && !$decorated_entity->isTitlePreserved()) {
+    if ($decorated_entity->autoLabelNeeded()) {
       $decorated_entity->setLabel();
     }
   }

Forgot a second part of the fix.

Clearly this needs some more work.

I opened 🐛 Generate+Hide option fails when Preserve Title option selected Needs review for a similar problem creating nodes when the "Preserve" option is enabled; it might ultimately be same bug, but I thought cleanly starting with test coverage would be a good approach.

I did not realize that setLabel() threw an exception if the entity didn't allow labels.

- needs to pass tests
- the patch doesn't apply tokens, eg [node:nid] is not being added to the label if it's part of the auto label template

I can also confirm this issue, resulting in "" when using that option

Please also note the remarkable work done by @DamienMcKenna in 🐛 Generate+Hide option fails when Preserve Title option selected Needs review regarding tests. Should we eventually combine the changes in one issue and MR?

+++ b/src/AutoEntityLabelManager.php
@@ -199,11 +199,14 @@ public function hasOptionalAutoLabel() {
+    return $not_applied && ($required || $optional) && !$title_preserved && !$entity_id;

This change makes it such that entity labels are not updated, they only trigger on new content...

With the latest release, I was able to correct this without a patch by checking the option "Create label before first save" for new content.

Thank you @pookmish - super cool to hear that this is fixed now with the latest feature from 🐛 Set Label runs two times on node creation Needs work ! 🎉

So shell we close this fixed?

I am sorry but I do not seem to understand the new logic. For example if I check `Automatically generate the label and hide the label field` and `title` field is required. And then also I check `Preserve already created node titles.` I end up with `Integrity constraint violation: 1048 Column 'title' cannot be null` because code inside `auto_entitylabel_entity_presave` for `$entity->isNew()` skips the next check.

The way I understand option `Preserve already created node titles.` is e.g. I set title to use date token. Then on first node save I get title and I want to preserve it on the next node update. But I want to set titles automatically with the same pattern and hide title field from user for consistency of title naming and I set `Automatically generate the label and hide the label field`. So with these options set I end up with SQL error. And this option to preserve already created titles is only visible with option that sets title automatically and hides title field.

Therefore I don't understand if code comment:

// Handle the case where the automatic label is optional.
// Check to see if isTitlePreserved is set. If the autolabel is
// optional AND the user has filled this title in then the
// the autolabel should not be set.

fits with the code checks below.

Also what I think happens is that `Preserve already created node titles.` checkbox (which is visible only in combination with `Automatically generate the label and hide the label field`) doesn't seem to be set to unchecked when being hidden if we switch options.

I opened a new issue https://www.drupal.org/project/auto_entitylabel/issues/3470585 🐛 New changes to set label logic cause integrity constraint violation Active