Set Label runs two times on node creation

Attaching a refactored patch to address the following:

- coding standards (I hope I caught all of them),
- added the missing AutoEntityLabelManager class reference,
- re-rolled the patch against 3.x (it was something below 3.x it and was not applying),
- fixed issue with info.yml file - the patch would not apply due to presence of the auto-generated package information.

This patch applied cleanly and looks like it fixed our issue with duplicate aliases - since we don't rely on any funky tokens, this should work in our situation.

Well, what do you know - it is failing here due to info.yml again. Attaching same file with a slight change around that hunk.

Last attempt...

Creating MR instead of patches.
Make sure to push your changes to MR. 🎉

Applied patch #77 to MR with few extra coding standards.

No longer applies to 3.0 version

@SocialNicheGuru did you use diff from MR?

All works for me

  - Installing drupal/auto_entitylabel (3.0.0): Cloning 8.x-3.0 from cache
  - Applying patches for drupal/auto_entitylabel
    https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/10.diff (Set Label runs two times on node creation https://www.drupal.org/project/auto_entitylabel/issues/3076302)

From what I understand, at least locally (with Composer), when it comes to info.yml file failing the patch - it looks like it conflicts with the lines auto-generated by DO packaging script. However, I was able to figure out a workaround - just adding an extra context line... IDK

the MR does not apply to 3.0.

- Installing drupal/auto_entitylabel (3.0.0): Extracting archive
- Applying patches for drupal/auto_entitylabel
https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/10.... (Set Label runs two times on node creation - https://www.drupal.org/project/auto_entitylabel/issues/3076302 🐛 Set Label runs two times on node creation Needs work )
Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/auto_entitylabel/-/merge_requests/10....

To apply the diff (from the MR) with a composer install, #84 is correct you just need one more blank line of context. I'm not sure how to adjust this so it works for non-composer and composer installs, but my updated patch is attached and applies to 3.0.0. I am skipping submitting this change to the MR since it would break the patch for non-composer users. Anyone who knows the best way to handle this problem (I've seen it before with patching info.yml files) please let us know.

Hi,
I am using 3.0.0 version of 'Entity Auto Label' module. With this version i am facing issue with content moderation, when I create a content first time in Draft state it does not reflect in Moderated Content tab. However if I resave that content then it start reflecting in Moderated content tab.

To fix this I used the Re roll patch provided in https://www.drupal.org/project/auto_entitylabel/issues/3076302#comment-1... 🐛 Set Label runs two times on node creation Needs work Using this patch my issue got resolved.

But now when I am creating node first time then it is invoking hook_entity_insert, that is fine. But it also invoking hook_entity_update due to which, the code that i only want to run on node update is also triggering at the node create issue.

So to fix both the above mentioned issue, I just use the 3.0.0 version and removed the hook_entity_insert() from module file then my both use cases are working perfectly.

So need to verify is there any issue if I remove hook_entity_insert() for module file from module 3.0.0 version? Please clarify.

Resolved conflicts.