🇺🇦Ukraine @lobodacyril

This patch is for 10.3.x version

#54 patch stopped working after last updates on dev branch.

Did you find solution for that?

It works as expected. I don't see any issues in code.

After 10.2.5 the patch stoped working. I quickly fixed it.

Now it works on my side.

Merge request #7 works for me and views embed button works correctly but other embed buttons stoped working. For example, if I add new embed button that embeds webform, block or media, then this buttons works as views embed buttons and show View Embed modal form. If I disable "Display embedded views" filter, then they works as expected.

This patch solves the problem but I'm not sure that this way can be officially used.

lobodacyril → created an issue.

Patch #116 contains JS syntax error so it doesn't work.

The previous patch was wrong. This is a correct one.

This patch work for me but we need to get rid of Drupal::service calling in the patch.

I have the same issue after update to 1.13:

Error: Cannot instantiate abstract class Drupal\office_hours\EventSubscriber\OfficeHoursEventSubscriber in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /web/core/lib/Drupal/Component/DependencyInjection/Container.php).

I have the same problem

It works on my side.

This is a patch

My suggestion to solve this issue in the patch. It solves only issue for the drupal_entity and I suppose we will have the same issue for drupal_entity_form and maybe for other functions.

lobodacyril → created an issue.

I got the same error but in different place: Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /code/web/modules/contrib/adsense/adsense.module on line 192

And this patch works for me.

@RobLoach I think the problem is that maintainers don't log in to Drupal.org and don't see any message for a long time so it's better to write direct messages to their social media and ask to add you as a maintainer.

If I remove injection from Drush command class, it solves the issue.

Just want to notice that it worked on Drupal 9.

lobodacyril → created an issue.

Rerolled patch for D10.1.x

This is a patch for 10.1.x version

The previous patch contained issue

I use bootstrap 4 and it requires the structure I described above. This is the official documentation: https://getbootstrap.com/docs/4.1/components/navs/#tabs

It's a bug, since the module should work for 4.x bootstrap. Patch #7 works for the new version and for me.

Rerolled Patch from #44

Comment #75 worked form me. Thank you.

I think is fixed in 2.0.2 version.

I found a way to set it to array and patch works for me.

lobodacyril → created an issue.

It seems you need to remove for JSON. It adds trailing commas when I save composer.json and it's wrong.

larowlan → credited lobodacyril → .

@adriancid why you set status to Active? If it's fixed, then the status should be Fixed.

I've noticed that TMGMT supports nested revisionable reference fields by this code:

$target_save = FALSE;
$target_entity->needsSave();

So it has to be postpone saving but since $target_entity->needsSave(); doesn't set needsSave property and just return in, it doesn't work. So the code should be the next:

$target_save = FALSE;
$target_entity->setNeedsSave(TRUE);

I'm not sure why it works for Nodes but this change works for Products and for Nodes.

lobodacyril → created an issue.

Sorry wrong patch

The patch stopped working so I changed and it works on 9.5.3

I'm not sure that's possible to solve without changing JS code since each AJAX request is sent using URL. Look at the JS code, it takes window.location.search and sends all the URL query parameters via AJAX. It means if the query contains page parameter, it will be sent also. That's why we need to remove sending page param.

This patch solves the problem.

lobodacyril → created an issue.