🇺🇦Ukraine @lobodacyril

It seems that the menu module sometimes uses the menu name for bundle and sometimes the menu_link_content value. I'm not sure what's going on there, but it looks like a major issue for now. I can't reproduce it on my side since all my websites that use this module had a smooth transition to the new version.

It'd be good if someone gave me the configuration files and composer.json that you use.

Patch #141 also doesn't work since it has a critical issue: Uncaught PHP Exception Error: "Call to a member function hasSession() on null" at /core/lib/Drupal/Core/Access/RouteProcessorCsrf.php line 44

I understand MR is better, but I didn't have enough time to do that.

The patch stopped working. I use it for pages that don't have entities, such as custom routes with templates. On these pages, I place a custom block with metatag and use it to replace page meta tags. I understand that this is not a good way to solve a problem, but this is the only fast way to do it.

For me, it seems obvious to select the default variation from the filtered variation list (option C). In my case, I remove some variations from the list in some conditions, so if I remove the first variation, then it can't be the default. In the case of the current code, I can pull the default variation, which doesn't consist in the current user list. Of course, it's possible to redefine using ProductEvents::PRODUCT_DEFAULT_VARIATION but I'm expecting another result.

The patch looks fine to me but I can't apply it to drupal/commerce:2.40.0

It happened because the menu name was previously used to get to the menu to which the link belonged. Later, the bundle field was defined for this purpose, and the menu name field is a rudiment field now. We didn't notice it in time, so you have the bundle field empty for menu items that were created by this module or by other modules. So if you have several menus, for example, header, and footer, then all menu items for the header will have bundle and menu name field as "header" and "footer" for footer.

For me, the menu_link_content bundle is incorrect since it doesn't belong to any menu. I'm curious how you created translation for menus that don't have a bundle since you can't create a translation configuration for that.

The patch #135 stopped working after updating to 10.4.2

Some time ago, Drupal Core added a bundle field to content menu items, and by default, it's always the same as the menu name. Unfortunately, no one noticed that, and the module created menu items without a bundle, and the core changed the bundle with the "menu_link_content" which is the entity name. Because of that, you can't translate menu items. If your menu is "main_menu", and you set translation for that, the core identifies menu items you created via this module as "menu_link_content" and this bundle doesn't have translation settings. To solve this, all the bundles should be the same as the menu names. This update did this.

I couldn't reproduce this issue you experienced, please provide more information about your menu names, menu items, and maybe screenshots what happened after update.

Translation works now in 3.0.4. If you still have an issue, reopen this ticket.

I suppose this issue is connected to https://www.drupal.org/project/taxonomy_menu_ui/issues/2949553 →

Please describe how to reproduce it and what version of Drupal you use. I can't reproduce it when Drupal 10 is installed.

I don't know what's the purpose of that .handle element, but I temporary hid it and this patch works for me.

It doesn't work for 10.4 and the Claro theme because of this element:

It was fixed in https://www.drupal.org/project/tca/issues/3333680 🐛 Drupal Coding Standards Issues | phpcs Needs review

Good job guys.

lobodakyrylo → made their first commit to this issue’s fork.

Patch #23 doesn't work for the 10.4 version.

berdir → credited lobodakyrylo → .

Try to use this patch link: https://git.drupalcode.org/project/views_entity_embed/-/merge_requests/7...

lobodakyrylo → created an issue.

This patch is for 10.3.x version

#54 patch stopped working after last updates on dev branch.

Did you find solution for that?

It works as expected. I don't see any issues in code.

After 10.2.5 the patch stoped working. I quickly fixed it.

Now it works on my side.

Merge request #7 works for me and views embed button works correctly but other embed buttons stoped working. For example, if I add new embed button that embeds webform, block or media, then this buttons works as views embed buttons and show View Embed modal form. If I disable "Display embedded views" filter, then they works as expected.

This patch solves the problem but I'm not sure that this way can be officially used.

lobodacyril → created an issue.

Patch #116 contains JS syntax error so it doesn't work.

The previous patch was wrong. This is a correct one.

This patch work for me but we need to get rid of Drupal::service calling in the patch.

I have the same issue after update to 1.13:

Error: Cannot instantiate abstract class Drupal\office_hours\EventSubscriber\OfficeHoursEventSubscriber in Drupal\Component\DependencyInjection\Container->createService() (line 259 of /web/core/lib/Drupal/Component/DependencyInjection/Container.php).

I have the same problem

It works on my side.

This is a patch

My suggestion to solve this issue in the patch. It solves only issue for the drupal_entity and I suppose we will have the same issue for drupal_entity_form and maybe for other functions.

lobodacyril → created an issue.

I got the same error but in different place: Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /code/web/modules/contrib/adsense/adsense.module on line 192

And this patch works for me.

@RobLoach I think the problem is that maintainers don't log in to Drupal.org and don't see any message for a long time so it's better to write direct messages to their social media and ask to add you as a maintainer.

If I remove injection from Drush command class, it solves the issue.

Just want to notice that it worked on Drupal 9.

lobodacyril → created an issue.

Rerolled patch for D10.1.x

This is a patch for 10.1.x version

The previous patch contained issue

I use bootstrap 4 and it requires the structure I described above. This is the official documentation: https://getbootstrap.com/docs/4.1/components/navs/#tabs

It's a bug, since the module should work for 4.x bootstrap. Patch #7 works for the new version and for me.

Rerolled Patch from #44

Comment #75 worked form me. Thank you.

I think is fixed in 2.0.2 version.

I found a way to set it to array and patch works for me.

lobodacyril → created an issue.

It seems you need to remove for JSON. It adds trailing commas when I save composer.json and it's wrong.

larowlan → credited lobodacyril → .

@adriancid why you set status to Active? If it's fixed, then the status should be Fixed.

I've noticed that TMGMT supports nested revisionable reference fields by this code:

$target_save = FALSE;
$target_entity->needsSave();

So it has to be postpone saving but since $target_entity->needsSave(); doesn't set needsSave property and just return in, it doesn't work. So the code should be the next:

$target_save = FALSE;
$target_entity->setNeedsSave(TRUE);

I'm not sure why it works for Nodes but this change works for Products and for Nodes.

lobodacyril → created an issue.

Sorry wrong patch

The patch stopped working so I changed and it works on 9.5.3

I'm not sure that's possible to solve without changing JS code since each AJAX request is sent using URL. Look at the JS code, it takes window.location.search and sends all the URL query parameters via AJAX. It means if the query contains page parameter, it will be sent also. That's why we need to remove sending page param.

This patch solves the problem.

lobodacyril → created an issue.