Automated Drupal 10 compatibility fixes

Since the patch has been already merged with the dev branch, tried installing the dev release through composer.

Encountered the following issue.

Info from https://repo.packagist.org: #StandWithUkraine
./composer.json has been updated
Running composer update drupal/like_and_dislike
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - drupal/like_and_dislike dev-1.x requires drupal/core ^8.7.7 || ^9.0 -> found drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.0.0 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - drupal/like_and_dislike 1.x-dev is an alias of drupal/like_and_dislike dev-1.x and thus requires it to be installed too.
    - Root composer.json requires drupal/like_and_dislike 1.x-dev@dev -> satisfiable by drupal/like_and_dislike[1.x-dev (alias of dev-1.x)].

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.
composer [require drupal/like_and_dislike:1.x-dev@dev] failed, composer command failed: exit status 2. stderr=

As mentioned in comment #2 of Project Update Bot, the patch is not fully covering the Drupal 10 compatibility.

Since the patch has already been merged with the development branch submitting a new patch with only the additional changes required.

Changes:

• Composer rules updated as per https://www.drupal.org/node/2514612#s-drupal-9-compatibility → . Drupal core composer dependency not required.
• Updated the core version requirement.
• Updated the behaviours as per https://www.drupal.org/node/3158256 → .

Note:
This module is dependent on https://www.drupal.org/project/votingapi → .
VotingApi module doesn’t have a drupal 10 release yet. Manually installed drupal 10 compatible dev version using
composer require 'drupal/votingapi:3.x-dev@dev’

Manually fixed query issue with voting api module as per https://www.drupal.org/node/3201242 →

Testing Steps:

1. Clone the 8.x-1.x branch of the module.
2. Install the voting api module by using composer require 'drupal/votingapi:3.x-dev@dev’.
3. Apply the patch.
4. Install the module.
5. Configure like and dislike feature on any content type.
6. There will be error thrown from the voting api module. Fix it as per https://www.drupal.org/node/3201242 → .
7. Clear the cache and review the like and dislike functionality.

P.S. - New developement branch for drupal 10 would be better.

When I was Installing this module in Drupal 10.0.3, it shows incompatible with 10.0.3.

Attached image.

I have created a new patch which makes this module D10 compatible and is working fine for me in my local.

I have also run drupal-check for this and as the errors were ignorable, no fixes were added in this patch.
Adding file with drupal-check errors.

I have tested patch #9 in drupal 9.5.7 and 10.0.3 which applied cleanly and makes module Drupal 10 compatible. Functionality is working as expected. So, moving this to RTBC.

Thanks

@adriancid why you set status to Active? If it's fixed, then the status should be Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.