Contrib.social

Allow to configure translation per property on link fields (for translating only the title, not the url itself)

Open on Drupal.org →
Created on 17 June 2020, over 4 years ago
Updated 4 February 2023, almost 2 years ago

Problem/Motivation

In images, we can configure that only title and alt texts are translated, and not the original file.
I think it will make sense in some cases to do the same for links, where you may want to allow to translate the title but not the url.

Proposed resolution

Add columns to modules/link/src/Plugin/Field/FieldType/LinkItem.php definition.

Add a UI mark depending on #3152587: Add a mark when editing a field property will affect all the translations as we do with fields themselves → outcome.

Remaining tasks

  • Ensure this is an acceptable feature request.
  • Have a working patch
  • Add tests
  • Right now, the (*all translation) markers doesn't work for subfields, so it's not obvious that this will affect all translations (see #3152587: Add a mark when editing a field property will affect all the translations as we do with fields themselves → ). We need to figure out a way to do that before this lands, as the UI would remain the same but you won't know you are updating all the translations.
  • Decide on the defaults: should be translatable or not by default?
  • Add an upgrade path: for existing sites, the url should be always translatable on upgrade, for avoiding to change the expected behavior on sites upgrading.
  • Add upgrade path tests.

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

✨ Feature request
Status

Postponed: needs info

Version

10.1 ✨

Component
Link  →

Last updated 4 days ago

Created by

🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Think it's a valid request to be able to translate links but isn't that already possible?

    During content translation you can change the title text to the language you are translating too.

    If the desire is to use for user interface translation not sure that's the correct way but tagging for subsystem maintainer for their thoughts. Would also leverage the #contribute slack channel.

  • Comment almost 2 years ago →
    🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

    @smustgrave Right now, you can translate all or nothing. The issue is about adding that granularity. You might want to let translators translate the link title, but not the url destination itself.

  • Comment almost 2 years ago →
    🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺

    Adding screenshot so it's more clear.

  • Status changed to Needs work 7 months ago
  • Comment 7 months ago →
    🇺🇸United States smustgrave

    We did something very similar for image fields lately so don't see why links could be any different.

  • First commit to issue fork.
  • Merge request !8793Issue #3152582: Allow to configure translation per property on link fields... → (Open) created by duaelfr
  • Comment 5 months ago →
    🇫🇷France duaelfr Montpellier, France

    I rerolled @penyaskito's #4 patch on 11.x in a new MR

  • Pipeline finished with Failed
    5 months ago
    Total: 177s
    #225658
  • Pipeline finished with Success
    5 months ago
    Total: 590s
    #227503
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇫🇷France duaelfr Montpellier, France

    Rerolled on the latest 11.x
    + added the ability to configure link options translatability (might be used by contrib like Link Target → )

  • Pipeline finished with Success
    4 months ago
    Total: 759s
    #261740
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States smustgrave

    Thanks for reviving, Moving to NW for test coverage.

  • Comment 3 months ago →
    🇪🇸Spain ipitbiz

    Hi all,

    I add a patch for version 10.3 and 11 because the one that is visible now only works for 10.2.

  • Comment 28 days ago →
    🇬🇧United Kingdom dahousecat

    The last patch fails on 10.2.7 as LinkItem now provides it's config via annotation.

  • Comment 4 days ago →
    🇺🇦Ukraine lobodacyril

    Patch #23 doesn't work for the 10.4 version.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024