Block visibility conditions

Open on Drupal.org →

Created on 19 July 2016, over 8 years ago

Updated 31 August 2023, over 1 year ago

We can set visibility conditions (variant selection criteria) at page and variant level, but it would be nice to apply visibility rules on individual blocks (panes). You used to be able to do this in D7.

There's a patch doing exactly this for Page Manager in ✨ Allow for block visibility rules Needs work . The patch currently being worked on in this issue leverages that. However it currently means introducing a new dependency on Page Manager. Possible solutions:

Factor the visibility/condition form functionality into core.
Factor the visibility/condition form functionality into ctools (which is already a dependency of both Page Manager and Panels).
Make Panels only show/use the visibility conditions if Page Manager is installed (ugly imho).
Any other ideas...?!

@vbouchet took a different approach in solving the problem by providing a new kind of access plugin for Panels 3.x and 4.x in #11.

Remaining tasks

Decide how best to share the visibility subform.
Add tests (might be able to steal from ✨ Allow for block visibility rules Needs work .

📌 Task

Status

Needs work

Version

4.0

Component

User interface

Created by

🇧🇪Belgium kriboogh

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇺🇦Ukraine lobodacyril
Rerolled Patch from #44
First commit to issue fork.
Comment over 1 year ago →
🇺🇦Ukraine lobodacyril
The previous patch contained issue
Open in Jenkins → Open on Drupal.org →
Core: 9.5.5 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
23 pass, 10 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
last update over 1 year ago
23 pass, 10 fail
Status changed to Needs review over 1 year ago11:20pm 9 October 2023
Comment over 1 year ago →
🇨🇦Canada joseph.olstad
Comment over 1 year ago →
🇨🇦Canada joseph.olstad
expecting 1 fail from HEAD
🐛 Fix HEAD test failures for 4.x Needs review
Comment over 1 year ago →
System Message
The last submitted patch, 60: panels-block_visibility_conditions-2769099-60.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.
Status changed to Needs work over 1 year ago11:40pm 9 October 2023
Comment over 1 year ago →
🇨🇦Canada joseph.olstad
The latest patch #60 introduces 9 new test failures.
see
🐛 Fix HEAD test failures for 4.x Needs review

we only have 1 head failure currently, and looking to fix that.
Comment about 1 year ago →
🇧🇷Brazil renatog Campinas
Aware that #60 needs works according to comment above

On this meantime, for any reason if someone needs to use on 8.x-4.7 tag, this is the patch

P.S. Making as hidden since tests needs to be done development branch
Comment about 1 year ago →
🇧🇷Brazil renatog Campinas
Aware that #60 needs works according to comment above

On this meantime, for any reason if someone needs to use on 8.x-4.7 tag, this is the patch

P.S. Making as hidden since tests needs to be done development branch
Comment 2 months ago →
🇧🇷Brazil murilohp
Just uploading a patch for the release 4.8, leaving as NW since the tests are required.
Comment about 1 month ago →
🇧🇪Belgium ludo.r Brussels
FYI,

The patches provided here work with page_manager patches till this one https://www.drupal.org/project/page_manager/issues/2858877#comment-14787260 ✨ Allow for block visibility rules Needs work

But does not work with subsequent patches or with the MR, as the page_manager.condition_access_resolver service has been removed.

You can use the MR and apply this patch: https://www.drupal.org/project/page_manager/issues/2858877#comment-16016365 ✨ Allow for block visibility rules Needs work

Hopefully this mentioned page_manager patch will get into the MR (https://git.drupalcode.org/project/page_manager/-/merge_requests/24).

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024